the daily wtf

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > YOSPOS > the daily wtf

The Management: Jan 2, 2010; sup, bitch?

this thread is for posting your colleagues� (and your own) terrible code and laughing at it. today I found this (api anonymized and condensed for clarity). see how many things you can find wrong with it.

code:


while (true) {
  success = thing->open();
  if (success) {
    createThreadToDoWork();
    joinWorkThread();
  }
  thing->close();
}

# ? Oct 4, 2017 16:46

Adbot: ADBOT LOVES YOU

# ? May 29, 2024 06:54

burning swine: May 26, 2004

heh it's bad

# ? Oct 4, 2017 16:54

cinci zoo sniper: Mar 15, 2013

*81 kilobyte large uncommented sql select query*

# ? Oct 4, 2017 16:59

burning swine: May 26, 2004

I once wrote some bitwise logic for parsing arguments in, of all things, ruby

can't find it now though

# ? Oct 4, 2017 17:02

cinci zoo sniper: Mar 15, 2013

COACHS SPORT BAR posted:

I once wrote some bitwise logic for parsing arguments in, of all things, ruby

can't find it now though

i wrote a salary parser in python last week

20 branch if statement because i couldnt be arsed to parse salary ranges

# ? Oct 4, 2017 17:06

RISCy Business: Jun 17, 2015; bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork bork; Fun Shoe

im piss

# ? Oct 4, 2017 17:19

Stymie: Jan 9, 2001; by LITERALLY AN ADMIN

the joke is that all code is terrible and laughable even if implemented "correctly"

# ? Oct 4, 2017 21:47

Agile Vector: May 21, 2007; scrum bored

omg the truest stymie post

# ? Oct 5, 2017 01:11

akadajet: Sep 14, 2003

Stymie posted:

the joke is that all code is terrible and laughable even if implemented "correctly"

i've been saying this poo poo and quoting stymie for years

# ? Oct 5, 2017 01:50

atomicthumbs: Dec 26, 2010; We're in the business of extending man's senses.

sounds like whoever did this was a real bastard operator from hell, op

# ? Oct 5, 2017 06:42

ADINSX: Sep 9, 2003; Wanna run with my crew huh? Rule cyberspace and crunch numbers like I do?

I once wrote some code that was really dumb and bad

# ? Oct 5, 2017 15:09

ADINSX: Sep 9, 2003; Wanna run with my crew huh? Rule cyberspace and crunch numbers like I do?

it was yesterday and almost every day before that for the last 15 years :unsmigghh:

# ? Oct 5, 2017 15:10

lampey: Mar 27, 2012

who wrote this garbage

check on it and realize i wrote it six months ago

must have been a good idea at the time

# ? Oct 6, 2017 00:37

Moo Cowabunga: Jun 15, 2009; [Office Worker.

looks good to me,op?

# ? Oct 6, 2017 06:37

The Management: Jan 2, 2010; sup, bitch?

Displeased Moo Cow posted:

looks good to me,op?

it creates a thread, waits for it to finish, then restarts and creates another thread. instead of just having a loop. it literally has thread whose whole job is to wait on another thread to run to completion.
it closes the thing even if failed to open it.
if open fails, it will be an infinite loop of system calls that will bring your system to its knees.

# ? Oct 6, 2017 07:01

A Pinball Wizard: Mar 23, 2005; I know every trick, no freak's gonna beat my hands; College Slice

today's wtf is these forums

# ? Oct 6, 2017 12:05

George: Nov 27, 2004; No love for your made-up things.

no that was yesterdays

# ? Oct 6, 2017 13:10

Moo Cowabunga: Jun 15, 2009; [Office Worker.

Coding is for nerds with brains and bad social skills and wads of dosh :smugmrgw:

# ? Oct 6, 2017 23:28

Adbot: ADBOT LOVES YOU

# ? May 29, 2024 06:54

post hole digger: Mar 21, 2011

lampey posted:

who wrote this garbage

check on it and realize i wrote it six months ago

must have been a good idea at the time

# ? Oct 6, 2017 23:33

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > YOSPOS > the daily wtf