mister_gosh fucked around with this message at 21:42 on Jun 11, 2010

56    my $dbquery = "alter table tablename reorganize partition p0, p1 into (
57                     partition p1 values less than (1)";
58    my $sth = $dbh->prepare($dbquery) or die "Could not prepare statement: " . $dbh->errstr;
59    $sth->execute or die "Could not execute statement: " . $dbh->errstr;
60
61    # This doesn't work either
62    # my @res = $sth->fetchrow_array;
63
64    print $sth->dump_results;

0 rows (19: fetch() without execute())

DBD::mysql::st dump_results failed: fetch() without execute() at ./rotatePartitions.pl line 64.

SynVisions fucked around with this message at 01:08 on Jun 26, 2010

SynVisions fucked around with this message at 02:32 on Jun 26, 2010

Erasmus Darwin fucked around with this message at 18:01 on Jun 30, 2010

• Too many global variables (KISS)
  
• Don't use shift() on @ARGV or @_ unless you know you need to
  
• You can move those two inner foreachs into a single sub (DRY)
  
• This may be a matter of personal preference but I shudder when seeing more than one/two levels of nested blocks (e.g. a foreach inside an if inside another foreach)
  
• Don't need to call ls using backticks, just use something like File::Glob, which is a core module
  

foreach (@foo) {
  my $bar = $_;
}

for my $bar (@foo) {
  ### Work with $bar here
}

$indv = $1;
$plate = $2;
$direction = $3;

print "Type 1\n";
print "indv = $indv\n";
print "plate = $plate\n";
print "direction = $direction\n\n";


### Associate related data into a single variable, a hash...
my %item;
$item{indv} = $1;
$item{plate} = $2;
$item{direction} = $3;

print "Type 1\n";
for my $value (qw/indv plate direction/) {
  print "$value = $item{$value}\n"
}
print "\n";


### Or condense even more with hash slices and map...
### Don't worry about writing stuff like this quite yet though.
my %item;
@item{qw/ indv plate direction/} = ($1, $2, $3);
print map {"$_ = $item{$_}\n"} qw/ indv plate direction/, "\n";

Roseo fucked around with this message at 07:14 on Jul 7, 2010