Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Locked thread
Yakattak
Dec 17, 2009

I am Grumpypuss
>:3

Ferg posted:

Just rolled out 1.1.1. Quick edit is now available and a handful of fixes all submitted by SneakingMission.

Live preview for quick reply will be coming in 1.2.0 as will Waffle Images uploading. Pretty much have the guts built for Waffle Images, but of course the service is down right now.

Is it possible to offer other image services like imgur?

Adbot
ADBOT LOVES YOU

Ferg
May 6, 2007

Lipstick Apathy

Yakattak posted:

Is it possible to offer other image services like imgur?

As long as it has an API. Baby steps though. Once I get the waffleimages thing implemented I'll look at other services.

Edit: I lied, imgur's API is pretty good. Defaulting to that for now.

Ferg fucked around with this message at 20:49 on Sep 9, 2010

fishbacon
Nov 4, 2009
wonderful yet strange smell
Instant Waffleimage/imgur support? Great!

Ferg
May 6, 2007

Lipstick Apathy

Mr. Fish posted:

Instant Waffleimage/imgur support? Great!

Drag and drop the file into the sidebar panel, yeah. Still working out the kinks though.

some kinda jackal
Feb 25, 2003

 
 
Looks like I picked the right time to start using SALR and Chrome :glomp:

Vykk.Draygo
Jan 17, 2004

I say salesmen and women of the world unite!
Thanks for adding in the Quick Edit. Unfortunately it suffers from the same problem the firefox extension had for a while where if you edit a post in a subscribed thread, it'll unsubscribe you from the thread.

Maker Of Shoes
Sep 4, 2006

AWWWW YISSSSSSSSSS
DIS IS MAH JAM!!!!!!

Vykk.Draygo posted:

Thanks for adding in the Quick Edit. Unfortunately it suffers from the same problem the firefox extension had for a while where if you edit a post in a subscribed thread, it'll unsubscribe you from the thread.

Is that what that is?! Jesus gently caress me sideways I thought I was going insane.

Ferg
May 6, 2007

Lipstick Apathy

Vykk.Draygo posted:

Thanks for adding in the Quick Edit. Unfortunately it suffers from the same problem the firefox extension had for a while where if you edit a post in a subscribed thread, it'll unsubscribe you from the thread.

Should be easy to fix. I'll get it into 1.2.

STING 64
Oct 20, 2006

Quick Edit isn't working at all for me and I don't see an option for it in Configure SALR.

Ferg
May 6, 2007

Lipstick Apathy

ADRIEN GRODYS FIFE posted:

Quick Edit isn't working at all for me and I don't see an option for it in Configure SALR.

Are you up to date? Make sure you're running 1.1.1 (and that you have quick reply enabled).

STING 64
Oct 20, 2006

Ferg posted:

Are you up to date? Make sure you're running 1.1.1 (and that you have quick reply enabled).

Doesn't chrome auto-update these things? Quick reply and quote work fine, is there a way to force a check for updates?

Never mind, works now.

STING 64 fucked around with this message at 01:09 on Sep 10, 2010

Yakattak
Dec 17, 2009

I am Grumpypuss
>:3

Can you also do link uploading? I rarely ever save images.

Ferg
May 6, 2007

Lipstick Apathy

Yakattak posted:

Can you also do link uploading? I rarely ever save images.

Yeah it will, still need to flesh out the UI though.

The Relentless
Sep 27, 2002

ANTI KITTY-PORN TASK-FORCE - "It's Hell-Bag eatin' time! Rowwwwrrrr!!!"
What does the "Fix forums cancer posts" do?

STING 64
Oct 20, 2006

The Relentless posted:

What does the "Fix forums cancer posts" do?

stops their posts from being grayed out.

Ferg
May 6, 2007

Lipstick Apathy
'sup imgur uploading :smug:



This is the fruits of me dissecting W3C specs and coming up with about a million alternative implementations to somehow get this working despite Chrome's security features, so the implementation is a bit out there. Will polish it up for release now.

Ferg
May 6, 2007

Lipstick Apathy
More testing.

Here's an image full size that was appended to this message:


I am adding this image as a thumbnail:

Click here to view the full image

some kinda jackal
Feb 25, 2003

 
 
Cookie monster's expression basically sums up how I feel about the upcoming changes.

Captain Capacitor
Jan 21, 2008

The code you say?
I was struck by inspiration today and put together a quick feature that fits into my category of "Why the hell didn't I think of this sooner", quote collapsing. Double-clicking a quote will collapse it, and includes an option to automatically collapse quotes that are too tall.

Before:


After:

Ferg
May 6, 2007

Lipstick Apathy

Captain Capacitor posted:

I was struck by inspiration today and put together a quick feature that fits into my category of "Why the hell didn't I think of this sooner", quote collapsing. Double-clicking a quote will collapse it, and includes an option to automatically collapse quotes that are too tall.

Before:


After:


So uhhh these images were uploaded while you were testing the new drag/drop feature, RIGHT?

Seriously, I need people to test the gently caress out of it.

brylcreem
Oct 29, 2007

by FactsAreUseless

Ferg posted:

Just rolled out 1.1.1. Quick edit is now available and a handful of fixes all submitted by SneakingMission.

Just a small UI-thing - It still says "Preview/Submit Reply", when it should be "Edit" :spergin:

Sneaking Mission
Nov 11, 2008

Ferg posted:

So uhhh these images were uploaded while you were testing the new drag/drop feature, RIGHT?

Seriously, I need people to test the gently caress out of it.

Captain Capacitor
Jan 21, 2008

The code you say?


Actually, just noticed a visual bug. When switching from the Tag panel to the imgur panel, the scrollbar remains.


Captain Capacitor fucked around with this message at 20:43 on Sep 11, 2010

Ferg
May 6, 2007

Lipstick Apathy

Captain Capacitor posted:



Actually, just noticed a visual bug. When switching from the Tag panel to the imgur panel, the scrollbar remains.



I noticed that too. It's the overflow property used for the smiley/bbcode lists that's sticking around. The scrollbar goes away with overflow: visible; I just need to figure out a not-retarded way to turn overflow on/off per sidebar.

fishbacon
Nov 4, 2009
wonderful yet strange smell
So, isn't the OP in need of an update about now? It still says 0.8.2 ;)

Image:

Click here to view the full image

Edit: I really like quote collapse.

Yakattak
Dec 17, 2009

I am Grumpypuss
>:3



Looks like it works.

Yakattak
Dec 17, 2009

I am Grumpypuss
>:3

However, if you do something that would produce an error on imgur it just displays a broken image. For instance try uploading something that is over 7 mb or whatever their limit is.

Ferg
May 6, 2007

Lipstick Apathy

Yakattak posted:

However, if you do something that would produce an error on imgur it just displays a broken image. For instance try uploading something that is over 7 mb or whatever their limit is.

Good catch, I have it handling 500/400 response codes but nothing that would be a successful response with an error message attached.

Rohaq
Aug 11, 2006

Yakattak posted:



Looks like it works.
I must know, what is this from? :)

Yakattak
Dec 17, 2009

I am Grumpypuss
>:3

Rohaq posted:

I must know, what is this from? :)

Unfortunately I have no idea, but it is hilarious.

Vykk.Draygo
Jan 17, 2004

I say salesmen and women of the world unite!
Are thumbnails going to remain square or will they eventually have the correct aspect ratio?

Ferg
May 6, 2007

Lipstick Apathy

Vykk.Draygo posted:

Are thumbnails going to remain square or will they eventually have the correct aspect ratio?

That's imgur making it square. It provides a "large thumbnail" but it's pretty drat large. I can experiment and see if resizing at runtime is feasible.

Captain Capacitor
Jan 21, 2008

The code you say?
Maybe an option to post at full size with timg tags.

Javid
Oct 21, 2004

:jpmf:
e: nevermind

Javid fucked around with this message at 06:21 on Sep 12, 2010

hirvox
Sep 8, 2009
There's a small layout bug in version 1.1.1 with embedded YouTube links where the extra line break is not removed when the link is closed.

becomes

after opening and closing the Youtube A video link.

Aatrek
Jul 19, 2004

by Fistgrrl
I'm running 1.1.1, and I don't have the image-upload button on my quick-reply box.

Aatrek
Jul 19, 2004

by Fistgrrl
Also, is there any way that the QR buttons could be rearranged a little bit? When I'm typing out a reply in the normal reply screen, it's so easy (especially on a laptop or netbook) to simply press TAB then SPACE, and the 'Submit' button gets pressed, uploading the post.

If the QR buttons were like this, you wouldn't have to jump to your mouse to reply:

Ferg
May 6, 2007

Lipstick Apathy

Aatrek posted:

I'm running 1.1.1, and I don't have the image-upload button on my quick-reply box.

It's in the 1.2.0 development build. Haven't released it yet.

Aatrek posted:

Also, is there any way that the QR buttons could be rearranged a little bit? When I'm typing out a reply in the normal reply screen, it's so easy (especially on a laptop or netbook) to simply press TAB then SPACE, and the 'Submit' button gets pressed, uploading the post.

If the QR buttons were like this, you wouldn't have to jump to your mouse to reply:



Could do one better and just set the tab index for those buttons so that it comes after the entry form. No need to move anything around.

Edit: Fixed

Ferg fucked around with this message at 15:12 on Sep 12, 2010

Aatrek
Jul 19, 2004

by Fistgrrl

Ferg posted:

Could do one better and just set the tab index for those buttons so that it comes after the entry form. No need to move anything around.

That would be perfect. I probably browse the forums the most on my Netbook, and doing everything from the keyboard makes life so much easier.

Adbot
ADBOT LOVES YOU

Maker Of Shoes
Sep 4, 2006

AWWWW YISSSSSSSSSS
DIS IS MAH JAM!!!!!!

Ferg posted:

Could do one better and just set the tab index for those buttons so that it comes after the entry form. No need to move anything around.

Edit: Fixed

I was just about to ask for exactly this. Thanks a million. :)

  • Locked thread