Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Locked thread
Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Thanks Ferg!

LastInLine posted:

I think this is broken. The menu and the gesture icons appear, but moving the cursor to the icons does nothing. That would occasionally happen before and a secondary click on the desired icon usually caused it to activate but this time there was no way to make the icons go away. I just had to refresh the page and disable the option.

e: Just checke the new SALR settings and the option to Enable default chrome right click menu to appear after overlay was not checked and yet I was getting the right click menu. As far as I could tell, toggling the checkbox does nothing.

e2: Now the option is working, but the one with both the right click menu and the gestures fails as I describe above. :confused:
I missed up the logic of the setting and so when you first update, the setting is set to be "undefined". Which isn't equal to 'false', so the menu would appear and I have learned an important lesson of always use '==' in extensions. Learning!

However, after the setting is defined, it seems to work fine for me where if I have both, it works, but the right menu appears (and works) and if the second one isn't set, no right click menu. I'm going to put out 1.5.10 that fixes these small bugs as well as add a "setting dump" page. So if it's still broken, I'll be asking for you to give me your settings then because it might be another part of the extension messing things up.

Also, as a user who uses the mouse gestures, do you have any preference for what the bottom button would be? As of now, I don't think it has a use, and I feel setting it to something like "usercp.php" would be useful as hell.

100 HOGS AGREE posted:

Yep that did it. Fix that and split up the "Display threads with new posts first" into two options so I can have it on only in the UserCP and not the forums at large and that's basically all the features I want forever. :)

Thanks for picking up development on the extension!
Adding issue for splitting up all settings that work on multiple areas of the site so that you can activate the setting, and then choose where it works. Now that you mention it, I think having that set-up would be ideal for me too though.

Master_Odin fucked around with this message at 14:27 on Apr 15, 2013

Adbot
ADBOT LOVES YOU

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

Also, as a user who uses the mouse gestures, do you have any preference for what the bottom button would be? As of now, I don't think it has a use, and I feel setting it to something like "usercp.php" would be useful as hell.
Refresh would the thing I'd use because I mostly post in only two forums so I use Up to go back to the forum listing while refreshing it at the same time. I'd imagine someone who relies on bookmarks would prefer Up to be toggleable between forum list and bookmarks as they seem mutually exclusive depending on one's browsing style.

100 HOGS AGREE
Oct 13, 2007
Grimey Drawer

Master_Odin posted:

Adding issue for splitting up all settings that work on multiple areas of the site so that you can activate the setting, and then choose where it works. Now that you mention it, I think having that set-up would be ideal for me too though.
:swoon:

Thank you so much, this is the main feature I missed after transitioning over from Firefox to Chrome (and from android to iOS but that's a different issue).

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
1.5.10 released

Changelog posted:

### v1.5.10 (4/15/2013)

- Fixed "Open Updated Threads" opening tabs twice
- Fixed right click menu being enabled even when the box wasn't ticked on initial installion of 1.5.9
- Moved "Pages per thread" to be a sub-setting of First/Last Three Pages
- Added ability to dump settings into a table of values for easy copy/paste.

It seems that the right click context menu acts funky on my laptop (but not my desktop) where the action to use it properly is:
1) Hold right click briefly so I see overlay and context menu
2) Let go right click so context menu disappears but overlay remains
3) Right click on proper box I want to go to
4) Don't hit anything on the second context menu to appear while the page is transitioning.

It's a weird effect and I'm honestly not sure how to fix this beyond get it so hitting alt or something would also bring up the overlay to free it from right click for those that want the context menu at this time. If there's some other issue at work (ie. really not working), please use the new dump settings button on the bottom of the settings page, post it to pastebin and give it to me?

RandomPauI
Nov 24, 2006


Grimey Drawer
I'd run into the undefined problem too and had to disable SALR. The trigger word that caused the error to pop up in a post was literally "undefined".

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

RandomPauI posted:

I'd run into the undefined problem too and had to disable SALR. The trigger word that caused the error to pop up in a post was literally "undefined".
Yeah, that makes sense because I guess when some setting is scanning a post, it hits "undefined" which has a special definition in javascript (that the variable isn't set) so it gets mixed up. However, without knowing the setting (or the specific set-up), I have no idea why it'd happen. Turning on all the settings doesn't cause it to happen, so it might just be a very specific combination of settings.

Luckily v1.5.10 of Redux offers a way to dump the settings for easy copy/pasting!

ClassActionFursuit
Mar 15, 2006

The Configure SALR link now leads to this thread :confused:

Edit: That time it both opened another instance of this thread and the Options screen. I enabled the right click menu but it still has the same problem in that I can't select any of the arrows. I'd rather just have it do the gestures unless you use a modifier (Control, Option, or Command doesn't matter to me), having both appear just doesn't work.

ClassActionFursuit fucked around with this message at 00:17 on Apr 16, 2013

Zen Punk
Dec 26, 2005

interfaced
The rightclick context menu was working just fine for me on my desktop. I'll see how it works with .10 when I get home.

Also usercp would awesome for bottom button. I'm always going back and forth between there and threads.

edit: Yeah, 1.5.10 braoke it. The mouse gestures and context menu seemed to be working on 1.5.9, now I only get the context menu.

Zen Punk fucked around with this message at 02:12 on Apr 16, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Zen Punk posted:

The rightclick context menu was working just fine for me on my desktop. I'll see how it works with .10 when I get home.

Also usercp would awesome for bottom button. I'm always going back and forth between there and threads.

edit: Yeah, 1.5.10 braoke it. The mouse gestures and context menu seemed to be working on 1.5.9, now I only get the context menu.

LastInLine posted:

Edit: That time it both opened another instance of this thread and the Options screen. I enabled the right click menu but it still has the same problem in that I can't select any of the arrows. I'd rather just have it do the gestures unless you use a modifier (Control, Option, or Command doesn't matter to me), having both appear just doesn't work.
Me using it on my desktop on 1.5.10: https://dl.dropboxusercontent.com/u/6782048/mouse-gestures.avi

And it worked on my linux laptop as well. Holding right click gets overlay to appear, then move mouse over option, release to select, then left click to get rid of context menu on my desktop. How I did it on my laptop is posted above. I'm not sure why it's broken for you guys, but works fine for me (and then Zen reports it worked fine before, but now it broke (which really doesn't make sense as I only changed a conditional to be the opposite of what it was ($ != true instead of == false, more robust if setting is undefined). I'm absolutely baffled on why this is happening. I would say perhaps that if you guys use the "Dump Settings" button at the bottom of the page, copy the contents of the page and put it on pastebin.com, and then give me the link, I'll take a look at it. It might be another setting that's breaking it for whatever reason because I don't see it?

I might be able to apply a key modifier to make either the overlay appear or not on the right click actually by changing the rightmousedown function now that I figured out how the context menu was originally disabled. I'll look into it as I agree the current solution is inelegant as all hell and you really end up with a poor mix of both worlds.

LastInLine posted:

The Configure SALR link now leads to this thread :confused:
I have no idea as I definitely didn't touch anything about this in 2 patches? The link is always http://www.forums.somethingawful.com/ with an onclick modifier to open settings.html so uh... :psyduck:

Master_Odin fucked around with this message at 04:34 on Apr 16, 2013

Lprsti99
Apr 7, 2011

Everything's coming up explodey!

Pillbug

Master_Odin posted:

I have no idea as I definitely didn't touch anything about this in 2 patches? The link is always http://www.forums.somethingawful.com/ with an onclick modifier to open settings.html so uh... :psyduck:

If I had to guess, I'd say it's something to do with middle clicking to open it. When you middle click to open the SALR config, it opens in a new tab at the end of your tab list, but the same page that you're currently on also opens one tab to the right of your current tab. Maybe he didn't notice the config page at the far right tab?

ClassActionFursuit
Mar 15, 2006

Lprsti99 posted:

If I had to guess, I'd say it's something to do with middle clicking to open it. When you middle click to open the SALR config, it opens in a new tab at the end of your tab list, but the same page that you're currently on also opens one tab to the right of your current tab. Maybe he didn't notice the config page at the far right tab?
This is on a MacBook Air, so it was cmd-click to get the options to come up in a new tab. I did it three or four times and each time only a new tab with this thread (at the first post) loaded. Then it opened that plus the options finally. I'm at work at the moment but I'll see if I can't reproduce it.

e: This was exactly what it was except the first few times the Options didn't load. Even just regular clicking reloads the current page so cmd-clicking opens a new tab at the current page and the Options. By the way this only happens from within a thread. On the thread listing the current tab does not reload and cmd-clicking and regular clicking does the same thing.

As for the gestures, it doesn't work like the video at all for me on OSX. Both the gesture squares and the secondary click menu open simultaneously when you initiate the right click obscuring the bottom two-thirds of the right gesture pad. Holding and moving to a pad then releasing does nothing. Releasing will allow you to select and click an option on the right click menu, but none of the gesture pads will do anything with either single click, double click, or a right click. Here is my settings dump.

ClassActionFursuit fucked around with this message at 10:35 on Apr 16, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

LastInLine posted:

This is on a MacBook Air, so it was cmd-click to get the options to come up in a new tab. I did it three or four times and each time only a new tab with this thread (at the first post) loaded. Then it opened that plus the options finally. I'm at work at the moment but I'll see if I can't reproduce it.

e: This was exactly what it was except the first few times the Options didn't load. Even just regular clicking reloads the current page so cmd-clicking opens a new tab at the current page and the Options. By the way this only happens from within a thread. On the thread listing the current tab does not reload and cmd-clicking and regular clicking does the same thing.
Yeah, you should just be left clicking the Configure SALR link and it'll open a new tab to adjust settings. You shouldn't have to click anything else to get it to do that. The behavior breaks down if you try other clicks I guess and I'll see if I can't change that to only open the tab.

LastInLine posted:

As for the gestures, it doesn't work like the video at all for me on OSX. Both the gesture squares and the secondary click menu open simultaneously when you initiate the right click obscuring the bottom two-thirds of the right gesture pad. Holding and moving to a pad then releasing does nothing. Releasing will allow you to select and click an option on the right click menu, but none of the gesture pads will do anything with either single click, double click, or a right click. Here is my settings dump.
Alright, so the base mouse gestures still works for you?

Anyway, alt key now can be used to turn on/off overlay and turn off/on context menu which works way better I think (and should not be computer dependent unless you lack an alt key or something). Bottom button now also refreshes the current page. I'll push the update later today.

Master_Odin fucked around with this message at 19:25 on Apr 22, 2013

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

Yeah, you should just be left clicking the Configure SALR link and it'll open a new tab to adjust settings. You shouldn't have to click anything else to get it to do that. The behavior breaks down if you try other clicks I guess and I'll see if I can't change that to only open the tab.
Yeah that's my bad. I've just gotten in the habit of whenever I want something to open in a new tab I cmd-click because you just NEVER KNOW :tinfoil:.

Master_Odin posted:

Alright, so the base mouse gestures still works for you?
Yes. Believe me if they didn't I'd mention it, I couldn't live without them.

Master_Odin posted:

Anyway, alt key now can be used to turn on/off overlay and turn off/on context menu which works way better I think (and should not be computer dependent unless you lack an alt key or something). Bottom button now also refreshes the current page. I'll push the update later today.
Do you know how the Alt key will translate to OS X? I only ask because Alt is only accessible by hitting Fn+Opt so to open the menu it would be Fn+Opt+Cmd click and while it's doable it'd be nicer to have the modifier be a single key. If it's not possible or if it just translates to Opt I can live with it. I've been living without it for so long I just forget the menu exists.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

LastInLine posted:

Do you know how the Alt key will translate to OS X? I only ask because Alt is only accessible by hitting Fn+Opt so to open the menu it would be Fn+Opt+Cmd click and while it's doable it'd be nicer to have the modifier be a single key. If it's not possible or if it just translates to Opt I can live with it. I've been living without it for so long I just forget the menu exists.
Macs, the bane of my existance clearly. :suicide:

e: Actually, I'll just have it trigger on option/alt. I think they may have the same keycode. Time to ask my friend to borrow his computer. Thanks for letting me know about this though.

Master_Odin fucked around with this message at 20:11 on Apr 22, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Master_Odin posted:

Macs, the bane of my existance clearly. :suicide:

e: Actually, I'll just have it trigger on option/alt. I think they may have the same keycode. Time to ask my friend to borrow his computer. Thanks for letting me know about this though.
Yeah, Option key does use the same option code so you don't have to use a keyboard shortcut to get to the actual alt key.

Anyway is v1.5.11 released which hopefully is the last drat patch on mouse gestures (beyond some style stuff and minor changes to the top button I guess).

Changelog posted:

v1.5.11 (4/22/2013) - "I really hate mouse gestures"

- Replaced right click option with alt key option
+ Alt key can be used to switch between mouse gestures or default
context menu
+ Button button in Mouse Gestures now refreshes current page
- Mouse Gesture disables left/right on single page thread/forums properly
- Mouse Gesture overlay appears above images on forum

Master_Odin fucked around with this message at 07:34 on Apr 24, 2013

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

Yeah, Option key does use the same option code so you don't have to use a keyboard shortcut to get to the actual alt key.

Anyway is v1.5.11 released which hopefully is the last drat patch on mouse gestures (beyond some style stuff and minor changes to the top button I guess).
You may hate mouse gestures but I love you. This is absolutely perfect. Thank you so much for your work on this.

I was wondering if there's a way to use analytics in an extension to find out what features people actually use or if you have to work blind?

v1ld
Apr 16, 2012

Friend Post Highlighting works for me only in threads where they're also the OP. They're not highlighted in other threads. Does this work for anyone else? The highlight friends in threads where they're the OP works irrespective of whether OP Post Highlight is selected.

Thanks for the updates to the extension.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

v1ld posted:

Friend Post Highlighting works for me only in threads where they're also the OP. They're not highlighted in other threads. Does this work for anyone else? The highlight friends in threads where they're the OP works irrespective of whether OP Post Highlight is selected.

Thanks for the updates to the extension.
Fixed for the next release. An issue within the jQuery selector was making it select only a limited number of friends within the UserCP friend panel.

Endymion FRS MK1
Oct 29, 2011

I don't know what this thing is, and I don't care. I'm just tired of seeing your stupid newbie av from 2011.
Why did my new thread button disappear?

Though it was the custom Stylish thing I had, but even with it disabled, the post button remains hidden. Only disabling SALR made the button come back.

With stylish:


Without:


No Post button at the bottom there on either.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Endymion FRS MK1 posted:

Why did my new thread button disappear?

Though it was the custom Stylish thing I had, but even with it disabled, the post button remains hidden. Only disabling SALR made the button come back.

With stylish:


Without:


No Post button at the bottom there on either.
Setting got removed (that technically seems to do more than it should) when I originally forked the code. Not sure how it happened, but it did. I'll push a quick update fixing the friend thing and this in a few minutes.

e: Note, the setting you have on is called "Hide the "Post" button in threads". It used to affect forum display (but that's fixed), so you shouldn't see the button in threads if it's on though now.

Changelog posted:

### v1.5.12 (5/1/2013)

- Fixed friend highlighting only working for first two friends in UserCP.php
- Fixed Post thread button disappearing on all pages if a missing setting got set in the past (by re-adding setting)
- Separated out function calls between forumdisplay.php and showthread.php so aforementioned setting doesn't affect forum post button

e: while friend highlighting works, I have to test it for having a large number of friends in-case more action is required. For now, I've tested on <10 friends.

Master_Odin fucked around with this message at 07:43 on May 1, 2013

v1ld
Apr 16, 2012

Master_Odin posted:

e: while friend highlighting works, I have to test it for having a large number of friends in-case more action is required. For now, I've tested on <10 friends.

Working again, thanks much! I've got < 10 too, though.

E: Thanks again for fixing this - it's nice to be able to skim some threads quickly again! And for picking up the maintenance/continued dev of this rather essential extension.

v1ld fucked around with this message at 21:52 on May 1, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Changelog posted:

### v1.5.13 (5/2/2013)

+ Added defaults for all settings
- Fixed style being for old forum layout on settings.html (most noticable in the quote box)
- Fixed coloring on settings.html for thread highlighting
- Fixed star column not being colored appropriately when using thread highlighting

So while you all can safely ignore the first thing, the rest is all applicable. This should allow for better color matching between SALR options and the actual forum/usercp views, as well as update on the quote box being the main things in the update.

I guess next is to add a way to have a "Pop-Up" help box that explains some things (such as having to go to Usercp.php to have friend highlighting, or hotkeys for Keyboard Navigation, or having a certain setting on to use OP highlighting).

Vykk.Draygo
Jan 17, 2004

I say salesmen and women of the world unite!
Here's a strange issue: I was using the thread search at the top of the page to search for a word in the Adam Carolla Show thread in RGD that I know is in the thread, but it says no results found. Any word I search, even if I'm looking right at the word, comes back with no results. I don't know if this is an extension issue or a forums issue.

Lprsti99
Apr 7, 2011

Everything's coming up explodey!

Pillbug
So, I don't suppose the "don't convert images in a post with a NWS/NMS warning" could be extended to posts that have the literal strings "not work/mind safe" and "not safe for work," could it? Because I just got blasted by a huge picture of a harlequin baby right before I was about to pass out.

The Relentless
Sep 27, 2002

ANTI KITTY-PORN TASK-FORCE - "It's Hell-Bag eatin' time! Rowwwwrrrr!!!"

Lprsti99 posted:

So, I don't suppose the "don't convert images in a post with a NWS/NMS warning" could be extended to posts that have the literal strings "not work/mind safe" and "not safe for work," could it? Because I just got blasted by a huge picture of a harlequin baby right before I was about to pass out.

Pleasant dreams. I hope they don't eat your soul...

JohnnyCanuck
May 28, 2004

Strong And/Or Free

Lprsti99 posted:

So, I don't suppose the "don't convert images in a post with a NWS/NMS warning" could be extended to posts that have the literal strings "not work/mind safe" and "not safe for work," could it? Because I just got blasted by a huge picture of a harlequin baby right before I was about to pass out.

Kids these days, can't even handle a horribly deformed baby picture on the internet. Why, in my day, we used to...

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Vykk.Draygo posted:

Here's a strange issue: I was using the thread search at the top of the page to search for a word in the Adam Carolla Show thread in RGD that I know is in the thread, but it says no results found. Any word I search, even if I'm looking right at the word, comes back with no results. I don't know if this is an extension issue or a forums issue.
I think this might be a forum issue as it works for me? If it continues to not work on other pages, mind giving me your settings?

Lprsti99 posted:

So, I don't suppose the "don't convert images in a post with a NWS/NMS warning" could be extended to posts that have the literal strings "not work/mind safe" and "not safe for work," could it? Because I just got blasted by a huge picture of a harlequin baby right before I was about to pass out.
Based on the following replies, I guess this might be a feature request. I'll look into implementing text based replacement as well then.

Javid
Oct 21, 2004

:jpmf:
This is the kind of fire you play with when you auto-convert links to images.

Vykk.Draygo
Jan 17, 2004

I say salesmen and women of the world unite!

Master_Odin posted:

I think this might be a forum issue as it works for me? If it continues to not work on other pages, mind giving me your settings?

I may not have been clear enough. It works in some forums (I can use it fine in this thread), but it doesn't seem to work in any threads in RGD. I haven't tested many other subforums so I don't know if RGD is the only subforum it doesn't work in.

SirJoeKCB
Dec 24, 2003
Are photobucket URLs being rewritten somewhere? Some images are not working for me, but are fine when SALR is disabled. I tried toggling all of the options that seemed relevant, but nothing worked.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Vykk.Draygo posted:

I may not have been clear enough. It works in some forums (I can use it fine in this thread), but it doesn't seem to work in any threads in RGD. I haven't tested many other subforums so I don't know if RGD is the only subforum it doesn't work in.
Yeah, you're right, there are issues with that particular forum. I'll have to do more testing to see if it's just an issue with that particular forum or what.

SirJoeKCB posted:

Are photobucket URLs being rewritten somewhere? Some images are not working for me, but are fine when SALR is disabled. I tried toggling all of the options that seemed relevant, but nothing worked.
Do you have a link to a thread that has them?

SirJoeKCB
Dec 24, 2003

Master_Odin posted:

Do you have a link to a thread that has them?

The first post on this page is doing it: http://forums.somethingawful.com/showthread.php?noseen=0&threadid=3210214&perpage=40&pagenumber=899#post415207539

chocolateTHUNDER
Jul 19, 2008

GIVE ME ALL YOUR FREE AGENTS

ALL OF THEM
Is there some reason SALR now keeps doing this?



The bottom preview/reply buttons are chopped off in the quick reply box. I can see them when I click the reply button for a brief second, but it looks like it quickly shifts down after that and they're hiddden.

Seems to have started within the last few weeks or so :(

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
It gets broken when you have the option "Convert links into inline images" enabled. Please disable it for the time being I guess and I'll look into fixing it.

e: To better explain what's happening: Photobucket (and I guess potentially imgur, but only very rarely) likes to give you links that show you the image, but then link to their site to view it in their little box or whatever. So you have a <a><img></a> type content in the post, which that setting associates as just having a link to the image (around say text) which then breaks things. I believe the code should ignore the link (as it goes to a HTML page), but it gets confused when you have something like .jpg.html (like that page has for that first post)

chocolateTHUNDER posted:

Is there some reason SALR now keeps doing this?



The bottom preview/reply buttons are chopped off in the quick reply box. I can see them when I click the reply button for a brief second, but it looks like it quickly shifts down after that and they're hiddden.

Seems to have started within the last few weeks or so :(
I have not seen this happening to me. Does this happen consistently? Can you give me a dump of your options page (using tinypaste or some other site)? Do you have any other extensions that might affect the forum?

Master_Odin fucked around with this message at 16:34 on May 18, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Vykk.Draygo posted:

I may not have been clear enough. It works in some forums (I can use it fine in this thread), but it doesn't seem to work in any threads in RGD. I haven't tested many other subforums so I don't know if RGD is the only subforum it doesn't work in.
After looking into this a bit more, I think RGD is the only forum this won't work in. I have no idea why SA has done this, but RGD seems completely unsearchable. If you go to the search page RGD is not on the list on the right and I have no idea why. If it gets added to the list, this feature should work in that forum then.

releasing new version to fix img rewriting.

Changelog posted:

### v1.5.14 (5/18/2013)

- Fixed "Convert links into inline images" to properly deal with links that have ".(jp?eg|png|gif|bmp).html" in them (they made broken images)

feller
Jul 5, 2006


Every time I try to hit the red X to mark a thread unread, it instead just takes me to the OP like I had clicked the title instead. The jump to unread posts button works; it's just the first one that doesn't. I just made sure to update to the most recent version and it's still happening.

e: this doesn't seem to be a SALR thing after all. It happened even when I disabled all my extensions.

feller fucked around with this message at 04:07 on Jun 1, 2013

RickoniX
Dec 4, 2005

A human or elf?

NO NOT A BADGER YOU GOON
is there any way to not have the extension convert image links to inline images if the link is already an image itself?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

RickoniX posted:

is there any way to not have the extension convert image links to inline images if the link is already an image itself?
This makes sense. This should probably be the default behavior.

Test:
1. Normal behavior (image link with text inside)
test 1!
2. Link has image in it

3. Link has text that is a link to an image (so it should still be replaced)
http://fi.somethingawful.com/safs/titles/fa/d8/00163390.0002.jpg

Seems good for 1.5.15

Master_Odin fucked around with this message at 19:29 on Jun 11, 2013

Riso
Oct 11, 2008

by merry exmarx
I just want to say that, should you get the extension installed, it seems to work fine in Opera's new Chromium based browser, Opera Next/15.

Adbot
ADBOT LOVES YOU

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
v1.5.15 released:

Changelog posted:

### v1.5.15 (6/11/2013)

- Change "Convert links into inline images" to ignore when the link is of a picture (eg. [img]test.jpg[/img])
- Remove ForumPostKey from settings dump page
- Fix regression in "Use custom thread highlighting" checkbox toggle for thread examples above not leaving custom highlighting

1.5.16 will be forthcoming to fix a bit more about the setting as it requires a bit more work (new setting, dealing with reverse option {image -> link}, etc.) but this should be fine for now.

Omelette du Fromage posted:

Every time I try to hit the red X to mark a thread unread, it instead just takes me to the OP like I had clicked the title instead. The jump to unread posts button works; it's just the first one that doesn't. I just made sure to update to the most recent version and it's still happening.

e: this doesn't seem to be a SALR thing after all. It happened even when I disabled all my extensions.
Yeah, I'm not getting this error (though I do see a different unrelated bug related to thread highlighting, which I'll try and fix for 1.5.16).

  • Locked thread