import-module ActiveDirectory
Import-CSV -prompt | foreach-object
{
	#utilizing location to get full computer name#
	$Store = "STORE"+$_.Location 
	$Host = "HOST"+$_.Location
	
	#Utilizing full computer name to get object#
	$StoreDN = (Get-ADUser -identity $Store)
	$HostDN = (Get-ADUser -identity $Host)
	$targetOU = (ou=$_.region, ou=$_.division, ou=PROD, ou=Stores, DC=my.domain.name)
		
		Move-ADObject -identity $StoreDN -TargetPath $TargetOU
		Move-ADObject -identity $HostDN -TargetPath $TargetOU
}

MF_James fucked around with this message at 21:58 on Jan 22, 2015

• Import-CSV doesn't take a "-Prompt" parameter. You can handle this a few different ways. You can use Read-Host to get user input which might be the easiest to understand if you're new to this:
  

  code:

  $csv = Read-Host -Prompt 'Where is the CSV?!'
  Import-Csv -Path $csv
  

  For bonus points, use Test-Path to make sure the file given by the user actually exists.
  
  What I'd prefer instead is to make the script itself take a -Path parameter, and make it required. If the user doesn't supply a path when calling the script, Powershell will prompt for you. To do that, you'd add stuff like this to the top of the script:
  

  code:

  [CmdletBinding()]
  param(
      [Parameter(
          Mandatory = $true,
          HelpMessage = 'Enter the path to the CSV file.'
      )]
      [ValidateScript( { $_ | Test-Path -PathType Leaf } )]
      [String]
      $Path
  )
  
  # your code here
  
  $Path | Import-Csv | ForEach-Object {
      # ...
  }
  
  # your code here
  

  This code also makes sure whatever the user enters exists on the file system and is a file (Leaf) rather than a folder. It's a lot more elegant and it's the "powershell way" of doing it, but it can be tough to understand if you're new to both this language and scripting itself.
  
  
• If you're trying to retrieve a computer object from AD, you should probably use Get-ADComputer rather than Get-ADUser.
  
• Your assignment of $targetOU is at best creating an array, but is probably invalid as written. Try this:
  

  code:

  $targetOU = "ou=$($_.region),ou=$($_.division),ou=PROD,ou=Stores,DC=my.domain.name"
  

  You can use variables directly in a double quoted string, but if you're trying to access a property with dot notaton it won't work. $(...) is a sub-expression and can be used in strings. Inside the parentheses you can use variables, cmdlets, entire pipelines. The result of all the code is the result of the sub-expression and will be put into the string.
  
• Regarding building the $targetOU string, also just be careful that your regions and divisions don't contain commas. If they do, you need to escape them with \, (for AD's sake, not powershell).
  
• Your variable names for $StoreDN and $HostDN imply that you think you'll get a DN as a string in response from Get-ADUser (or Get-ADComputer). You will in fact receive a complete object. It doesn't matter that you called the variables what you did, but you should be aware of what you'll have.
  

Import-CSV -prompt | foreach-object
{
	#utilizing location to get full computer name#
	$Store = "STORE"+$_.Location 
	$Host = "HOST"+$_.Location
	
	#Utilizing full computer name to get object#
      try {
	$StoreDN = (Get-ADUser -identity $Store)
	$HostDN = (Get-ADUser -identity $Host)
	$targetOU = (ou=$_.region, ou=$_.division, ou=PROD, ou=Stores, DC=my.domain.name)
		
		Move-ADObject -identity $StoreDN -TargetPath $TargetOU
		Move-ADObject -identity $HostDN -TargetPath $TargetOU
      } catch {
        $_   # set a breakpoint here so the whole script stops and you can see what happened?
      }
}

import-module ActiveDirectory
$Path = Read-Host -Prompt "CSV Location Please, Sir"
if ((Test-Path -path $Path))
{
$csv = Import-CSV $Path
	foreach($item in $csv)
	{
		$Store = "STORE"+$item.Location
		$VMHost = "HOST"+$item.Location
		$targetOU = "ou=" + $item.region + ",ou="+ $item.division + ",ou=PROD,ou=Stores,DC=qastr,DC=qapos,DC=bfrc"
		try{$teststore = Get-ADComputer -identity $Store}
		catch{$Store + "Could not be found" | Out-File C:\error.txt -Append}
		try{
			if(!$error){Get-ADComputer -identity $Store | Move-ADObject -TargetPath $TargetOU}
			else{$error.clear}
			}
		catch{$Store + "Could not be moved" | Out-File C:\error.txt -Append}
		try{$testhost = Get-ADComputer -identity $VMHost}
		catch{$VMHost  + "Could not be found" | Out-File C:\error.txt -Append}
		try{
			if(!$error){Get-ADComputer -identity $VMHost | Move-ADObject -TargetPath $TargetOU}
			else{$error.clear}
			}
		catch{$VMHost + "Could not be moved" | Out-File C:\error.txt -Append}
	}
}
else{Write-Output "The CSV path failed"}

MF_James fucked around with this message at 19:22 on Jan 29, 2015

Dr. Arbitrary fucked around with this message at 16:01 on Jan 31, 2015

Dr. Arbitrary fucked around with this message at 16:55 on Jan 31, 2015