|
CPColin posted:Reject it because it mixes tabs and spaces. that was me trying to sanitize it for posts on public forums cause this one is worth it
|
# ? Nov 3, 2018 00:16 |
|
|
# ? May 21, 2024 02:49 |
|
synapse posted:I just got a code review request and let's just say I don't exactly know what to do with this one. I am a junior developer relative to this man. Just because you write a test to figure something out about the how the language works doesn't necessarily mean it should be part of the unit test suite for all time, especially if it sleeps for seconds...
|
# ? Nov 3, 2018 01:46 |
|
Hargrimm posted:How fuckin big is that project for that much tech debt to be an A rating? That was the first scan, so it’s a baseline. boo_radley posted:(Slides large stack of chips to "npm dependencies", rolls the dice) Spatial posted:I've seen plenty of codebases where people shamelessly copied and pasted huge chunks of code around. This, and: boo_radley posted:(Slides large stack of chips to "npm dependencies", rolls the dice) This
|
# ? Nov 3, 2018 01:52 |
|
CPColin posted:Reject it because it mixes tabs and spaces. Spaces for life
|
# ? Nov 3, 2018 02:00 |
|
iospace posted:Spaces for life please don't start this again
|
# ? Nov 3, 2018 02:36 |
|
redleader posted:please don't start this again Sounds like you need a Safe space (I'm sorry)
|
# ? Nov 3, 2018 03:04 |
|
jit bull transpile posted:Sounds like you need a I fixed that
|
# ? Nov 3, 2018 04:37 |
|
Vertical tabs and newlines: the only valid whitespace™
|
# ? Nov 3, 2018 04:38 |
|
Is caring a lot about white space a legitimate reason to call someone a nazi?
|
# ? Nov 3, 2018 04:44 |
|
I mean it’s basically the definition!
|
# ? Nov 3, 2018 04:47 |
|
jit bull transpile posted:Sounds like you need a Hey I can get you a safe space no problem, and if they ask for money you can put it on my tab (I'm sorry too)
|
# ? Nov 3, 2018 04:53 |
|
iospace posted:Spaces for life I really don't give a toss whether a codebase uses spaces or tabs, but a pet peeve I have with my current place is that there's no rule on which it is. So we end up with loads of files that are a mishmash of tab-indented and space-indented lines, because one person's VS is set up to use spaces and another person's is set up for tabs. I would bring it up to someone, but a previous foray in that direction gave me the impression that complaining about it would be seen as "making a fuss about tabs/spaces", i.e. that advocating for consistency would not be distinguished from advocating for one over the other. So I don't bring it up. I mean, it's a very minor thing, but it annoys me because it feels untidy. (there is a company-wide policy that defines how many spaces a tab must be, so it doesn't affect the appearance of files on different machines.)
|
# ? Nov 3, 2018 14:14 |
|
At some point my company switched from tabs (or not having a policy) to spaces but just left all the tabs in place, so in older files you can use the distinct strata of tabs and spaces to tell which code is new and which code hasn't been touched since the 2000s
|
# ? Nov 3, 2018 14:43 |
|
It's just a find and replace to go from one to the other.
|
# ? Nov 3, 2018 15:34 |
|
ratbert90 posted:It's just a find and replace to go from one to the other. ... five weeks pass ... “Hey ratbert weren’t you the one heading up our code reformatting initiative? Whatever happened to that?”
|
# ? Nov 3, 2018 16:32 |
|
ratbert90 posted:It's just a find and replace to go from one to the other. I sometimes contribute to the Erlang standard library and it works that way for them. They basically have some tooling that handles blaming and diffs and don’t want indentation change to have an impact on file history when inspecting code. So you are allowed to reindent code, but only if you are actively working on that bit.
|
# ? Nov 3, 2018 17:36 |
|
I used to use tabs for reasons but goddamn Visual Studio kept resetting my settings every 3 months, so eventually I gave up and said gently caress it, I'll use the defaults (spaces). This is how the tabs and spaces war is won.
|
# ? Nov 3, 2018 18:24 |
|
MononcQc posted:I sometimes contribute to the Erlang standard library and it works that way for them. They basically have some tooling that handles blaming and diffs and don’t want indentation change to have an impact on file history when inspecting code. This to me is the most sensible solution. That or have a pre-commit that reformats (though I've never tried it). Tabs vs spaces is just bike shedding time waster (especially since they format their code all wrong, with tabs)
|
# ? Nov 3, 2018 20:33 |
|
We settled on a standard style at work. I'm not wild about it, but I like having a style much better than I like having every file having a mix of styles, some of which might not be found anywhere else. If you're using git, you can set up the formatter to run as a pre-commit hook, so you can write whatever you want and it goes in as the correct format.
|
# ? Nov 3, 2018 21:06 |
|
Our blame tools ignore changesets that are marked as purely reformatting/cleanup, which seems like a way better solution than banning people from making cleanup changes.
|
# ? Nov 3, 2018 23:40 |
|
EssOEss posted:gently caress it, I'll use the defaults (spaces) This is the correct response whereever possible. Note that for any people using VS2017: you can enforce a single style on a project using VS's editorconfig extensions.
|
# ? Nov 3, 2018 23:40 |
|
I used to be a huge spaces over tabs guy. As I got older I stopped caring so much what the code formatting looked like, just so long as it was all consistent.
|
# ? Nov 4, 2018 00:51 |
|
The real argument is relative vs absolute indentation. And sometimes you need both
Pie Colony fucked around with this message at 23:48 on Nov 4, 2018 |
# ? Nov 4, 2018 23:46 |
|
Just go whole
|
# ? Nov 5, 2018 00:31 |
|
The real argument is
|
# ? Nov 5, 2018 02:15 |
|
Jabor posted:Our blame tools ignore changesets that are marked as purely reformatting/cleanup, which seems like a way better solution than banning people from making cleanup changes. Try that in a language with significant whitespace!
|
# ? Nov 5, 2018 03:30 |
|
xtal posted:Try that in a language with significant whitespace! It seems like that doesn't affect anything? Deciding which changes should be marked as "cleanup" is a human problem, not a technical one.
|
# ? Nov 5, 2018 03:45 |
|
CPColin posted:Reject it because it mixes tabs and spaces. iospace posted:Spaces for life Look at what you've done. Are you proud?
|
# ? Nov 5, 2018 04:16 |
|
redleader posted:Look at what you've done. Are you proud? Very!
|
# ? Nov 5, 2018 05:03 |
|
redleader posted:Look at what you've done. Are you proud? Hey I didn't take a stand on which was better; I just said they shouldn't be mixed!
|
# ? Nov 5, 2018 05:56 |
|
This subforum needs a CoC so we can do some call and response at meetups. When I say CoC you say CoC CoC (CoC) CoC (CoC)
|
# ? Nov 5, 2018 06:43 |
|
Absurd Alhazred posted:He's absolutely serious and really saddened that people think it's a joke: Argh the Arabic letter "N" makes my chud-sense tingle (ISIS is said to paint that letter - for "Nazarene" - on the houses of Christians to mark them for ethnic cleansing. A very common "virtue signal" for conservatives on Twitter and a huge red flag) hackbunny fucked around with this message at 18:21 on Nov 5, 2018 |
# ? Nov 5, 2018 18:10 |
|
pokeyman posted:This subforum needs a CoC so we can do some call and response at meetups. Yeah, you know me!
|
# ? Nov 5, 2018 19:40 |
|
EssOEss posted:I used to use tabs for reasons but goddamn Visual Studio kept resetting my settings every 3 months, so eventually I gave up and said gently caress it, I'll use the defaults (spaces). This is how the tabs and spaces war is won. Embrace. Indent. Extinguish.
|
# ? Nov 6, 2018 19:36 |
|
Magissima posted:At some point my company switched from tabs (or not having a policy) to spaces but just left all the tabs in place, so in older files you can use the distinct strata of tabs and spaces to tell which code is new and which code hasn't been touched since the 2000s Lol if ur code base doesn't go back to the late 80s
|
# ? Nov 7, 2018 21:32 |
|
feedmegin posted:Lol if ur code base doesn't go back to the late 80s Scars from multiple VCS migrations. Files that it's easier to build new parsers than to represent any other way. Comments that stylistically evolve from Jargon file to XKCD to HN.
|
# ? Nov 8, 2018 03:10 |
|
The true horror are languages that care about your tabs and spaces (you know the one).
|
# ? Nov 8, 2018 14:40 |
|
I can’t think of a language that truly never cares about whitespace. Brainfuck?
|
# ? Nov 8, 2018 14:59 |
|
comedy option
|
# ? Nov 8, 2018 15:05 |
|
|
# ? May 21, 2024 02:49 |
|
Oh, is that the language Gab is written in?
|
# ? Nov 8, 2018 15:28 |