carry on then fucked around with this message at 16:56 on Feb 25, 2019

Soricidus fucked around with this message at 01:16 on Feb 26, 2019

• Severe lack of good OOP and abstraction; classes thousands of lines long, loads of JavaBean-style classes passed around and used like structs instead of encapsulating their behaviour
  
• Lack of documentation of method contracts (most javadocs are just a less concise reiteration of the method name, like init(): /** Initialises the Foo */, even when there's important side-effects going on
  
• Lack of tests on said methods / web services for anything other than common cases (at best), making refactoring onerous if not impossible since there is a fear of changing current behaviour in any of the possible edge cases
  
• 15 years of SOAP web service versions being bolted on top of each other. Boilerplate classes everywhere, and spaghetti logic operating on them all.
  
• Reams of XML config all over the place, requiring various environment property files to be in the right place and updated with the right values for a successful build, which is managed through a huge collection of Ant scripts that have accumulated over 15 years
  

/*
Write a program to read a list of exam scores given as integer percentages in the range 0 to 100.
Display the total number of grades and the number of grades in each letter-grade category as follows:
90 to 100 is an A, 80 to 89 is an B, 70 to 79 is an C, 60 to 69 is an D, 0 to 59 is an F.
Use a negative score as a sentinel value to indicate the end of the input.
(The negative value is only used to end the loop, so do not use it in the calculations.).

For example, if the input is

98, 87, 86, 85, 78, 73, 72, 72, 70, 66, 63, 50, -1

the output would be:

Total number of grades = 14
Number of A's = 1
Number of B's = 4
Number of C's = 6
Number of D's = 2
Number of F's = 1
*/

import java.io.FileNotFoundException;
import java.util.HashMap;
import java.util.Scanner;
import java.io.File;

public class GradeReader {
    // Fields
    final String SENTINEL = "q";
    private HashMap<String, Integer> markBook = new HashMap<String, Integer>();
    private int marks = 0;

    GradeReader(){
        // Init with a list of possible grades + inited markbook.

        // Failing - GradeInformation[] possibleGrades = new GradeInformation[5];

        String[] possibleGrades = {"A", "B", "C", "D", "F"};
        for (String grade : possibleGrades)
        {
            markBook.put(grade, 0);
        }
    }
    /*
    class GradeInformation{
        private String letterGrade;
        private int lowerBoundary;
        private int upperBoundary;
        GradeInformation(){
            System.out.println("Init GradeInfo");
        }
    */

    public static void main (String[] args){

        GradeReader reader = new GradeReader();
        reader.getInput();
        reader.printMarkBook();
    }

    void getInput(){
        // Tries to read in from a file, otherwise gets keyboad input
        File file = new File("/Users/obow/Dropbox/Coding/Java/MiscProjects/src/results.txt");
        Scanner scanner;
        try {
            scanner = new Scanner(file);
        }
        catch (FileNotFoundException e) {
            System.out.println("File not found" + file.getAbsolutePath());
            System.out.println("Using keyboard instead.");
            scanner = new Scanner(System.in);
        }

        do{
            // Loops through the input (keyboard or file) until hitting a q.
            System.out.print("Please enter a score : ");
            String line = scanner.nextLine();
            if (SENTINEL.equalsIgnoreCase(line)){
                break;
            }
            else{
                try{
                    int score = Integer.parseInt(line);
                    if (isBetween(score, 0, 100)) {
                        this.updateMarkBook(score);
                    }
                    else{
                        System.out.println("Score must be between 0 and 100.");
                    }
                }
                catch(NumberFormatException e){
                    System.out.println("Invalid input. Whole numbers only.");
                }
                catch(Exception e){
                    System.out.println(e);
                }
            }
        } while(true);
    }

    void updateMarkBook(int score){
        // Updates a grade. Based on the idea that there's only one markbook per instance.
        String grade = scoreToGrade(score);
        this.marks ++;
        System.out.printf("%d - Adding grade %s for score %d to markbook.\n", this.marks, grade, score);
        this.markBook.put(grade, this.markBook.get(grade)+1);
    }

    void printMarkBook(){
        // Iterates through the keys in a markbook and outputs
        System.out.printf("\nTotal number of grades %d\n", this.marks);
        for(String key : this.markBook.keySet()){
            System.out.printf("Number of %s's : %d\n", key, this.markBook.get(key));
        }
    }

    String scoreToGrade(int score){
        // Takes a score, checks it and turns it into a grade.
        String grade = "";
        if (isBetween(score, 90, 100)){
            grade = "A";
        }
        else if (isBetween(score, 80, 89)){
            grade = "B";
        }
        else if (isBetween(score, 70, 79)){
            grade = "C";
        }
        else if (isBetween(score, 60, 69)){
            grade = "D";
        }
        else if (isBetween(score, 0, 59)){
            grade = "F";
        }
        return grade;
    }

    boolean isBetween(int score, int lower, int upper){
        // Checks if a value is between two values. Returns true/false.
        return lower <= score && score <= upper;
    }
}

Sad Panda fucked around with this message at 23:13 on Apr 8, 2019

1. Using a try-with-resources block to initialize the Scanner
   
2. Using a foreach loop instead of the do-while
   
3. Rather than call updateMarkBook from getInput, have getInput return a List<Integer> and iterate over that to update the markbook - you generally want each method to be responsible for as few things as possible
   
4. For the love of dog, get yourself an IDE that has an auto-format function (IntelliJ Community Edition is free and really good)
   

• read and parse your grading scheme, producing Grades
  
• create a MarkBook with that set of Grades
  
• read and parse your scores
  
• hand scores to the MarkBook, let it handle them internally (whatever data structure, whatever grouping logic, whatever error handling)
  
• print the MarkBook (you could override toString in the class if you like)
  

private HashMap<String, Integer> markBook = new HashMap<String, Integer>();

private Map<String, Integer> markBook = new HashMap<String, Integer>();

baka kaba fucked around with this message at 20:14 on Apr 9, 2019

oh no computer fucked around with this message at 13:51 on Apr 10, 2019