void LogHourlyBackgroundJobDone(long executionTimeMillis)
{
    // This is fine
    logger.Log($"Finished background job that executes once per hour, execution time was {executionTimeMillis} ms.");

    // I'm not going to do more then drop a NIT if I thought using a different string format/concatenation/interpolation method would be better
    var logString = string.Format("Finished background job that executes once per hour, execution time was {0} ms.", executionTimeMillis);
    logger.Log(logString);

    // This is fine too, the primary factor for how this code is written should be consistency with how the rest of your codebase does log string construction
    logger.Log("Finished background job that executes once per hour, execution time was " + executionTimeMillis + " ms.");

    // This seems a little verbose for this situation and is probably the worst-looking example out of all of these,
    // but if someone really wanted to use it I could live with approving most PRs that had this as long as it wasn't obnoxious
    var logStringBuilder = new StringBuilder();
    logStringBuilder.Append("Finished background job that executes once per hour, execution time was ");
    logStringBuilder.Append(executionTimeMillis);
    logStringBuilder.Append(" ms.");
    logger.Log(logStringBuilder.ToString());
}

void LogSomeMetricsInHotPath(List<long> giantListOfExecutionTimesToLogInHotPath)
{
    if (giantListOfExecutionTimesToLogInHotPath.Count < 1000000)
    {
        throw new ArgumentException("Please only use this method to log batches of at least 1 million execution times.", nameof(giantListOfExecutionTimesToLogInHotPath));
    }

    // var logStringBuilder = new StringBuilder().AppendLine("Building a log string"); // just use the recommended API
    var logString = "Building a log string\n";

    foreach (var executionTimeMillis in giantListOfExecutionTimesToLogInHotPath)
    {
        // logStringBuilder.Append("Here's an Execution Time: ").Append(executionTimeMillis).AppendLine(" ms"); // this is just about as readable as the concatenation
        logString += "Here's an Execution Time getting logged in a really, really hot path: ";
        logString += executionTimeMillis;
        logString += "ms\n";
    }

    // logger.Log(logStringBuilder.ToString()); // that's all it takes
    logger.Log(logString);
}

ThePeavstenator fucked around with this message at 04:06 on Mar 3, 2022

    [MemoryDiagnoser]
    public class StringFormatTest
    {
        private readonly int Digits = 8;

        [Benchmark]
        public string Concatted() => "Finished background job that executes once per hour, execution time was " + Digits + " ms.";

        [Benchmark]
        public string Interpolated() => $"Finished background job that executes once per hour, execution time was {Digits} ms.";

        [Benchmark]
        public string Formatted() => string.Format("Finished background job that executes once per hour, execution time was {0} ms.", Digits);

        [Benchmark]
        public string StringBuilding()
        {
            var logStringBuilder = new StringBuilder();
            logStringBuilder.Append("Finished background job that executes once per hour, execution time was ");
            logStringBuilder.Append(Digits);
            logStringBuilder.Append(" ms.");
            return logStringBuilder.ToString();
        }
    }

.NET5
|         Method |      Mean |    Error |   StdDev |    Median |  Gen 0 | Allocated |
|--------------- |----------:|---------:|---------:|----------:|-------:|----------:|
|      Concatted |  31.51 ns | 0.699 ns | 1.347 ns |  30.96 ns | 0.0421 |     176 B |
|   Interpolated | 221.54 ns | 3.846 ns | 5.001 ns | 222.79 ns | 0.0477 |     200 B |
|      Formatted | 228.65 ns | 4.607 ns | 8.765 ns | 226.90 ns | 0.0477 |     200 B |
| StringBuilding | 150.77 ns | 3.037 ns | 5.923 ns | 151.26 ns | 0.1624 |     680 B |

.NET6
|         Method |      Mean |    Error |   StdDev |  Gen 0 | Allocated |
|--------------- |----------:|---------:|---------:|-------:|----------:|
|      Concatted |  29.83 ns | 0.701 ns | 2.035 ns | 0.0421 |     176 B |
|   Interpolated | 211.89 ns | 4.284 ns | 7.941 ns | 0.0477 |     200 B |
|      Formatted | 195.37 ns | 2.401 ns | 2.005 ns | 0.0477 |     200 B |
| StringBuilding | 124.16 ns | 2.521 ns | 4.348 ns | 0.1624 |     680 B |

insta fucked around with this message at 18:45 on Mar 3, 2022

No Pants fucked around with this message at 19:47 on Mar 3, 2022

rarbatrol fucked around with this message at 21:43 on Mar 6, 2022

Kyte fucked around with this message at 00:43 on Mar 7, 2022

New Yorp New Yorp fucked around with this message at 01:38 on Mar 7, 2022

LongSack fucked around with this message at 03:40 on Mar 7, 2022

fuf fucked around with this message at 18:55 on Mar 8, 2022

Munkeymon fucked around with this message at 20:42 on Mar 8, 2022

fuf fucked around with this message at 12:16 on Mar 9, 2022