Treytor posted:

This is an ip logger and checker, which outputs to a text file on the server. Is there a more efficient way to do this? Say for example if my site was getting hammered and my host was complaining about the PHP slowing down the entire server...

EDIT: also, how would I delete expired entries?

Treytor posted:

duz posted:

Instead of using explode and what not, look up fgetcsv and fputcsv.

Treytor posted:

This is an ip logger and checker, which outputs to a text file on the server. Is there a more efficient way to do this? Say for example if my site was getting hammered and my host was complaining about the PHP slowing down the entire server...

admiraldennis posted:

you should probably consider paying somebody to do the code correctly for you instead of asking a bunch of questions here just so you can use some crappy file database that's going to choke to death if your site ever gets a lot of traffic.

admiraldennis posted:

I know you "want to do it yourself" but seriously if your site is getting hammered and your host is complaining just buck up and either 1) go learn to do this with a database, or 2) have somebody else do it for you and study the code and db schema to figure out how it works.

duz posted:

The roll-your-own kind. Good luck figuring out that system!


Alt tags on inputs are for screen readers. jQuery has a nice form validation plugin that uses class names or you can use JSON to build you validation requirements.


Edit: fopen is GET only, not POST, sorry. vv Learn something new all the time, that might come in handy.

omgwtfnoway posted:

I'm trying to use exec() in a php script to add and commit some files to SVN.

I'm doing something like:

code:

$cmd = "cd c:\pathWithSVN";
exec($cmd);
$cmd = "svn add $abaFilename";
exec($cmd);

...

The problem is: neither of these commands are being run. Any ideas? I've never tried executing command line commands from a script before. This is run on a windows machine with apache/php5.

drcru posted:

How can I improve this system of including/defining?

code:

define('ROOT_PATH', '/home/username');	// set the ROOT_PATH here
define('BACKYARD', '/lawn');		// set the backyard path here
include_once(ROOT_PATH . BACKYARD . '/config.inc.php');
include_once(ROOT_PATH . BACKYARD . '/skin.php');
include_once(ROOT_PATH . BACKYARD . '/db.inc.php');
include_once(ROOT_PATH . BACKYARD . '/error.inc.php');

I've set up 3 pages so far but I'm worried about making changes for when we go live...

omgwtfnoway posted:

I'm trying to use exec() in a php script to add and commit some files to SVN.

duz posted:

Install the SVN PECL extension then do it natively.

fletcher posted:

All my classes refer to $this->database to interact with the database. Is there any way to avoid having to pass it in as a parameter to a static function of a different class that needs the db?

nbv4 posted:

is there a more elegant way to do this?:

code:

$variable = $field . "_sel";
$$variable = "checked";

Evil Angry Cat posted:

When this is absolutely neccesary I go with ${$variable} = "whatever"; . I'd have to see a bigger section of your code to see if there was an easier/cleaner way around it (which there usually is).

OlSpazzy posted:

Does anyone see a reason why the "show news comments" section of this code is only displaying the newest comment for each post?

$comments_list_commentbit is being called from within the template for "news_newsbit_commentslink". Note that some classes and variables may not appear to be defined as this is only a portion of the script.

php:

<?
code
?>

bt_escm posted:

I looks like you are assigning $comments_list_commentbit each time. I think you want to use .= instead of =

Also I see no reason to use eval here or anywhere else in your code and it's really just a style and readability thing, but never use select * from table, even when you want to select everything from the table. List out the columns. It will save your sanity in the future.

OlSpazzy posted:

Also, the evals are necessary, without them unp_printTemplate('comments_list_commentbit') returns, for example:

OlSpazzy posted:

php:

<?
$newsid = $news['newsid'];
?>

OlSpazzy posted:

So it's needed to get the variables within the templates to actually parse. Thanks for the suggestion on table selections.

fletcher posted:

I might be alone on this, but I don't understand the point of doing that. It adds lines to the code and makes it less readable, in my opinion.

Finite posted:

I do it in a few places to do things like...

code:

$colour = $data['colour'];
$string = "The lazy $colour fox jumps over the I can't remember the rest of this."

But I decided that was a little stupid the other day and I'm trying to use sprintf instead.

duz posted:

You're supposed to use braces when you want the contents of a variable.

php:

<?
$string = "The quick {$data['colour']} fox jumps over the lazy dogs."
?>

Finite posted:

I do it in a few places to do things like...

code:

$colour = $data['colour'];
$string = "The lazy $colour fox jumps over the I can't remember the rest of this."

But I decided that was a little stupid the other day and I'm trying to use sprintf instead.

duz posted:

You're supposed to use braces when you want the contents of a variable.

php:

<?
$string = "The quick {$data['colour']} fox jumps over the lazy dogs."
?>

fletcher posted:

Finite posted:

...

...

I had no idea you could do that.

admiraldennis posted:

Thats the only way one should include variables within a double-quoted string, in my opinion. Either that or with a concatenation. It's borderline ambiguous otherwise and hurts readability.

Treytor posted:

Here is the script edited a bit, and this is what will get run repeatedly as people refresh like mad. What line do I throw in there to check to see if a time stamp is $timeout older than $now? And if so, delete that entry.

code:

<?php ?>

admiraldennis posted:

Thats the only way one should include variables within a double-quoted string, in my opinion. Either that or with a concatenation. It's borderline ambiguous otherwise and hurts readability.

Scarboy posted:

I disagree. If you're going to be outputting this, and it's data from the user then I would use sprintf and wrap the variable in htmlentities() (I don't write PHP much, is this the correct function to use?) to not allow html/js injection.