Coding Horrors: You can gather all your technical debt into one easy framework!

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!

ohrwurm: Jun 25, 2003

Some gems from an ASP app that I inherited:

code:

if strCompanyID = "1" then
    intCompanyID = 1
elseif strCompanyID = "2" then
    intCompanyID = 2
elseif strCompanyID = "3" then
    intCompanyID = 3
elseif strCompanyID = "4" then
    intCompanyID = 4
end if

code:

strsql = ""
  strsql = "select AppVars.RecordID From AppVars where AppVars.VarName = 'RAFDE'" 
  set rsGetRAFDE = Server.CreateObject("ADODB.Recordset")
  rsGetRAFDE.ActiveConnection = connection
  rsGetRAFDE.Open(strsql)
  if not rsGetRAFDE.EOF then
    strRAFDE = cstr(rsGetRAFDE.Fields("RecordID"))
  end if
  rsGetRAFDE.Close
  set rsGetRAFDE = nothing

  strsql = ""
  strsql = "select AppVars.RecordID From AppVars where AppVars.VarName = 'RAF2'" 
  set rsGetRAF2 = Server.CreateObject("ADODB.Recordset")
  rsGetRAF2.ActiveConnection = connection
  rsGetRAF2.Open(strsql)
  if not rsGetRAF2.EOF then
    strRAF2 = cstr(rsGetRAF2.Fields("RecordID"))
  end if
  rsGetRAF2.Close
  set rsGetRAF2 = nothing

This block above gets used about 10 more times in the exact same way, just to set some variables. It's like they have never heard of functions.

Imagine at least 25 pages of this at several thousand lines each littered with inline sql, years of uncommented edits, and tons of copied and pasted code and you will see what I work with daily.

# ¿ Mar 25, 2008 15:34

Adbot: ADBOT LOVES YOU

# ¿ May 3, 2024 00:19

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!