SALR Chrome Extension - New browser, same great taste!

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Chrome Extension - New browser, same great taste!

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

iospace posted:

Cis autodrag indicated they would in the Firefox thread, contact them.

Ya, I was gonna do some work over my Thanksgiving break but then a bunch of poo poo came up and well Goon projects. I'll poke at this temp version if I have time but I'm not gonna pretend to be remotely dependable.

Edit: at a minimum, I'll make a github fork of chrome salr with the changes that were already made for ff compatibility and then work on it as I can. If people want to write issues against that fork to help me find/prioritize the things that don't work that'd be great. If ppl want to also contribute to that fork that would be double amazing. I'll post later this evening or tomorrow with a link.

The MUMPSorceress fucked around with this message at 22:59 on Nov 27, 2017

# ¿ Nov 27, 2017 22:44

Adbot: ADBOT LOVES YOU

# ¿ May 22, 2024 10:07

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Capsaicin posted:

The only thing I really want is just the "SA" dropdown between History and Bookmarks at the top of the window

loving same. That is likely the first thing on my list.

# ¿ Nov 27, 2017 23:14

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

tithin posted:

I liked the coloring on the control panel and the button arrow

Can you test it in Serfer's fixed version and just jot down what happens to add as an issue to the fork?

# ¿ Nov 28, 2017 00:07

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Serfer posted:

So far, everything is cross compatible. I'm sure issues will crop up between the two implementations, but they look super close.

This is my gut feel but I'd prefer to start with a fork and PR it into the main repo only after we're sure it works in chome too.

# ¿ Nov 28, 2017 03:23

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Clone is here: https://github.com/cisautodrag/salr-chrome

I'll add Serfer's changes tonight and then I'll look at the coloring and buttons.

# ¿ Nov 28, 2017 03:33

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Serfer posted:

I added this to manifest.json to get the settings page back, which allows you to enable custom thread highlighting, which enables the green coloring in the usercp and forum displays.

Also it lets you change your options.
Under
code:
"options_page":"settings.html",
I put
code:
  "options_ui": {"page": "settings.html"},
Which is also chrome compatible, btw, so the options_page could just be removed

Edit: I updated my extension.zip, which also has one other change, where I changed
code:
    jQuery('#nav-last-post').click(function() {
        var post = jQuery('div#thread > table.post').eq(findFirstUnreadPost());

        jQuery(window).scrollTop(post.offset().top);
to
code:
jQuery('#nav-last-post').first().attr('href', window.location.href.replace(/\?.*threadid/,'?threadid').replace(/\&.*$/,'&goto=newpost'));
So the lastread button works more like the old firefox version, where it reloads the page for new posts

The getthreadid function needs to be rewritten, since it should use that, but I just hacked it together to be whatever

Edit2: changed hotkey-manager.js switch(event.keyCode) to switch(event.which) to make it cross-compatible

You work fast! thanks. I've got everything in my local branch except the lastread button since it doesn't sound like it was broken, just different.

# ¿ Nov 28, 2017 07:06

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

tithin posted:

I've still got the temporary addon installed from the other night, assuming you've not updated it since then?

this is what my UCP looks like

related: the smilies button on the right of the in-page quick reply javascript window doesn't work.

You have to enable the highlighting in the settings. Should work in the version he linked a couple posts up.

Currently trying to work out how the SA menu works in chrome (does it exist in chrome? I see the button but no way to add forums to its menu).

edit: i'm giving up defeated for the night cuz my typing's keeping my partner awake.

The MUMPSorceress fucked around with this message at 07:57 on Nov 28, 2017

# ¿ Nov 28, 2017 07:55

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

tithin posted:

Bearing in mind I'm a functional moron - I have no idea how to edit JSON's to match the updated version differences he mentioned above, short of just... opening it in notepad?

that's basically it, yeah. Like I said, I have it in my local branch but there's a bunch of problems I need to fix over the next week or two before I'd have something worthy of testing. For example, I don't think the famous firefox grenade menu exists on the chrome side so I'm going to have to implement it from scratch.

# ¿ Nov 28, 2017 08:18

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Master_Odin posted:

Historically, the functionality was that Chrome (up to version 48 or so) allowed extensions to put actions/icons into Chrome's omnibar, which SALR used to have a forum's jump list for whatever. This icon would then only show up when you were on the site. However, for users that wanted something a bit more permanent, they could then install a secondary extension (linked to by Serfer) which would override the omnibar jump list and give you the grenade icon you know and love. However, since the omnibar jumplist is dead, the functionality of the two extensions should probably be merged (and we can then also get rid of some amount of the port messaging making the architecture simpler in the process).

So I think I'm going to contact Github to turn this fork into a standalone repo, and work on merging the two extensions into one (as well as merging Serfer's diff into the repo as I'm using some deprecated stuff right now), dragging along cis autodrag's fork (hopefully). After that's done, I'm going to request this thread is also closed and I'll start a new one since now that this thread is getting activity again, it's annoying to always see "1 unread post".

(Note: I wasn't aware of the changes to Chrome 48 until right now as I've never been a user of the jump lists).

There's nothing in my fork that isn't in surfer's diff so far so you can probably skip that step. If you'd rather we could make a feature branch on your repo for the work to make it cross compatible and to add the jump list.

# ¿ Nov 28, 2017 19:30

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

iospace posted:

Question, would it be possible to have the pop-up window like the old Firefox extension did or did that get killed with web extensions?

Web extensions support pop-ups, so it's feasible, but we should probably just pick one behavior for each feature with diverging implementations. I hate quick reply so I'm not gonna weight my own opinion at all as to which version is better.

# ¿ Nov 28, 2017 20:28

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Someone in yospos just said they xenforo 2 officially released today so if lowtax is true to his word we may be switching forums platforms soon. I think a wait and see approach is probably best at this point because the chrome extension is gonna be totally broken by that move also.

# ¿ Nov 29, 2017 20:37

Adbot: ADBOT LOVES YOU

# ¿ May 22, 2024 10:07

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Serfer posted:

It's probably quick, cis autodrag is gonna do it

Given you've literally done all the work, maybe you should submit it and claim all the glory. I've been completely sidetracked on work projects.

# ¿ Dec 1, 2017 06:06

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Chrome Extension - New browser, same great taste!