SALR Chrome Extension - New browser, same great taste!

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Chrome Extension - New browser, same great taste!

Serfer: Mar 10, 2003; The piss tape is real

Love the eternal one unread post in this thread on this definitely not dead forum.

# ¿ Oct 20, 2017 04:59

Adbot: ADBOT LOVES YOU

# ¿ May 22, 2024 06:39

Serfer: Mar 10, 2003; The piss tape is real

ulmont posted:

It's all over the forum. Has to do with threads Zen Death Robot had posted in before his posts were deleted recently.

Yeah, it happened to several pages on the D&D Trump thread. Nonexistent pages for days.

# ¿ Oct 25, 2017 16:57

Serfer: Mar 10, 2003; The piss tape is real

I dunno if anyone cares, since this is the chrome thread, but I did a dirty port to firefox, most poo poo works just like chrome, follow the directions here to install temporarily if you want to play with it

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Temporary_Installation_in_Firefox

https://drive.google.com/uc?id=1WmnmBiA5EaAXOI5ljY5mqf0KEwByiUR4&export=download

Colors don't seem to work in the user control panel, and I've done zero testing, although I am posting this from the quick reply window...

Serfer fucked around with this message at 10:14 on Nov 23, 2017

# ¿ Nov 23, 2017 08:01

Serfer: Mar 10, 2003; The piss tape is real

Also fun fact, it works equally well in chrome, so ferg or whoever could update with the couple changes I made to have it work in both

# ¿ Nov 23, 2017 08:17

Serfer: Mar 10, 2003; The piss tape is real

tithin posted:

Unpacked extension loader doesn't work in firefox quantum

poo poo, wrong link, I fixed it, should be this https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Temporary_Installation_in_Firefox

# ¿ Nov 23, 2017 10:14

Serfer: Mar 10, 2003; The piss tape is real

Master_Odin posted:

It'd be me and in this repo: https://github.com/MasterOdin/salr-chrome

Cool, here's the diff:

code:

diff -r extension/js/background.js orig extension/js/background.js
38c38
< var port = chrome.runtime.connect();
---
> var port = chrome.extension.connect();
46c46
< chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {
---
> chrome.extension.onMessage.addListener(function(request, sender, sendResponse) {
diff -r extension/js/drag_drop.js orig extension/js/drag_drop.js
1c1
< var port = chrome.runtime.connect();
---
> var port = chrome.extension.connect();
diff -r extension/js/message-handler.js orig extension/js/message-handler.js
33,34c33,34
< if(chrome.runtime.onConnectExternal != undefined) {
<     chrome.runtime.onConnectExternal.addListener(function(port) {
---
> if(chrome.extension.onConnectExternal != undefined) {
>     chrome.extension.onConnectExternal.addListener(function(port) {
53c53
< chrome.runtime.onConnect.addListener(function(port) {
---
> chrome.extension.onConnect.addListener(function(port) {
123c123
<                     var salr = chrome.runtime.connect("nlcklobeoigfjmcigmhbjkepmniladed");
---
>                     var salr = chrome.extension.connect("nlcklobeoigfjmcigmhbjkepmniladed");
diff -r extension/js/popup-handler.js orig extension/js/popup-handler.js
30c30
< var port = chrome.runtime.connect({"name":"popup"});
---
> var port = chrome.extension.connect({"name":"popup"});
diff -r extension/js/salr.js orig extension/js/salr.js
1080c1080
<     chrome.runtime.sendMessage(fancyId, {message:"installcheck"}, function(response) {
---
>     chrome.extension.sendMessage(fancyId, {message:"installcheck"}, function(response) {
diff -r extension/js/settings-handler.js orig extension/js/settings-handler.js
33c33
< var port = chrome.runtime.connect({"name":"settings"});
---
> var port = chrome.extension.connect({"name":"settings"});

iospace posted:

Nice to see. Unfortunately due to my use case I don't think I'll be able to adopt it just yet (I'm not one of those users who leaves their computer with everything running for as long as possible).

Well, this isn't really a permanent solution, more just to see if I could, and how well it would work

# ¿ Nov 23, 2017 18:37

Serfer: Mar 10, 2003; The piss tape is real

anilEhilated posted:

So, sorry if I'm asking something really obvious, but apart from this temp fix, is there any initiative towards making it work on Firefox again or is that project completely dead?

It just needs someone who's willing to take it on. If MasterOdin wants to take it on to make this cross platform, that's cool and great. It just needs a champion.

# ¿ Nov 24, 2017 20:52

Serfer: Mar 10, 2003; The piss tape is real

Master_Odin posted:

Are these changes going to be able to backport to the chrome version without breaking anything (and just improving cross-compatibility). If so, I have no issue adding you as a collaborator to the project cis autodrag and keeps things sort of unified between browsers.

So far, everything is cross compatible. I'm sure issues will crop up between the two implementations, but they look super close.

tithin posted:

Where is it and I'll try it tonight

Second post on this page. It's a parsing error, I haven't looked at it closely yet.

# ¿ Nov 28, 2017 03:09

Serfer: Mar 10, 2003; The piss tape is real

cis autodrag posted:

Clone is here: https://github.com/cisautodrag/salr-chrome

I'll add Serfer's changes tonight and then I'll look at the coloring and buttons.

I added this to manifest.json to get the settings page back, which allows you to enable custom thread highlighting, which enables the green coloring in the usercp and forum displays.

Also it lets you change your options.
Under

code:

"options_page":"settings.html",

I put

code:

  "options_ui": {"page": "settings.html"},

Which is also chrome compatible, btw, so the options_page could just be removed

Edit: I updated my extension.zip, which also has one other change, where I changed

code:

    jQuery('#nav-last-post').click(function() {
        var post = jQuery('div#thread > table.post').eq(findFirstUnreadPost());

        jQuery(window).scrollTop(post.offset().top);

code:

jQuery('#nav-last-post').first().attr('href', window.location.href.replace(/\?.*threadid/,'?threadid').replace(/\&.*$/,'&goto=newpost'));

So the lastread button works more like the old firefox version, where it reloads the page for new posts

The getthreadid function needs to be rewritten, since it should use that, but I just hacked it together to be whatever

Edit2: changed hotkey-manager.js switch(event.keyCode) to switch(event.which) to make it cross-compatible

Serfer fucked around with this message at 05:45 on Nov 28, 2017

# ¿ Nov 28, 2017 04:12

Serfer: Mar 10, 2003; The piss tape is real

cis autodrag posted:

You work fast! thanks. I've got everything in my local branch except the lastread button since it doesn't sound like it was broken, just different.

Heh, well, I just fixed the things that annoyed me. I get that the lastread button doesn't work the way I would like, and that's ok

# ¿ Nov 28, 2017 07:29

Serfer: Mar 10, 2003; The piss tape is real

tithin posted:

I've still got the temporary addon installed from the other night, assuming you've not updated it since then?

this is what my UCP looks like

related: the smilies button on the right of the in-page quick reply javascript window doesn't work.

Yeah, I updated my zip, if you want to re-download

# ¿ Nov 28, 2017 08:22

Serfer: Mar 10, 2003; The piss tape is real

cis autodrag posted:

that's basically it, yeah. Like I said, I have it in my local branch but there's a bunch of problems I need to fix over the next week or two before I'd have something worthy of testing. For example, I don't think the famous firefox grenade menu exists on the chrome side so I'm going to have to implement it from scratch.

There's this https://chrome.google.com/webstore/detail/something-awful-last-read/dodkgjokbnmiickhikhikpggfohagmfb?hl=en

# ¿ Nov 28, 2017 08:24

Serfer: Mar 10, 2003; The piss tape is real

cis autodrag posted:

Web extensions support pop-ups, so it's feasible, but we should probably just pick one behavior for each feature with diverging implementations. I hate quick reply so I'm not gonna weight my own opinion at all as to which version is better.

I like the external window way better, but I get that I'm a weirdo

# ¿ Nov 28, 2017 20:35

Serfer: Mar 10, 2003; The piss tape is real

cis autodrag posted:

Web extensions support pop-ups, so it's feasible, but we should probably just pick one behavior for each feature with diverging implementations. I hate quick reply so I'm not gonna weight my own opinion at all as to which version is better.

I like the external window way better, but I get that I'm a weirdo

# ¿ Nov 28, 2017 20:36

Serfer: Mar 10, 2003; The piss tape is real

iospace posted:

Though realistically, I think that should be the last thing implemented. I'd much rather have things like my always showing nav bar, proper "do I have unreads" highlighting, and custom user subtitles first.

Does the chrome extension not have user notes? I don't see it

I assume that's what you meant by custom user subtitles

# ¿ Nov 29, 2017 05:34

Serfer: Mar 10, 2003; The piss tape is real

Sup dudes

Here's the updates, including the menu bar extension:
https://drive.google.com/open?id=1WmnmBiA5EaAXOI5ljY5mqf0KEwByiUR4&export=download
https://drive.google.com/open?id=1Ws4a9V2hZuLQVL1ppM2Yk4hStvNmk9sE&export=download
Same as before, install using
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Temporary_Installation_in_Firefox

I may have hosed something up here, I think I need to search/replace the extension id, since I had to manually specify it...

Serfer fucked around with this message at 00:31 on Dec 1, 2017

# ¿ Dec 1, 2017 00:28

Serfer: Mar 10, 2003; The piss tape is real

axeil posted:

There's 2 links here, which one should we use?

Also it says the install is temporary until you restart Firefox. Does that mean if you shut down and restart your computer you have to reinstall and you lose all your settings/changes?

Both, one is SALR, the other is the SALR button.

I think I might need to fix the SALR extension though, I had to specify an extension id, and it uses it in a bunch of places that I probably need to change as well (like hitting the x on the quick reply popup doesn't make it go away)

Edit: as to the second part, I think settings are retained, but you have to reload it. This is just a temp job until it can get submitted to ffsfox

Serfer fucked around with this message at 02:09 on Dec 1, 2017

# ¿ Dec 1, 2017 02:04

Serfer: Mar 10, 2003; The piss tape is real

axeil posted:

Thanks! How long does it take to submit and get approved?

It's probably quick, cis autodrag is gonna do it

# ¿ Dec 1, 2017 03:50

Serfer: Mar 10, 2003; The piss tape is real

cis autodrag posted:

Given you've literally done all the work, maybe you should submit it and claim all the glory. I've been completely sidetracked on work projects.

Yeah, but I think I'm going to fix the resource loading problem I made in the bar version, and that'll probably be it.

Or I'll combine the two first, I dunno, I don't really have any interest in the ongoing work part.

# ¿ Dec 1, 2017 08:09

Adbot: ADBOT LOVES YOU

# ¿ May 22, 2024 06:39

Serfer: Mar 10, 2003; The piss tape is real

astral posted:

Nice work with the port! This is exactly what was needed to tide people over until XenForo 2.

Is there a most-updated repo for the Firefox changes, or just the zips Serfer has posted? I can help with getting it submitted / setting up an auto-update from the legacy Firefox version when it's ready.

e: can help with stuff like data translation too so people can keep their notes and relevant settings from their legacy firefox install

I see there's no longer any conversion capability built in, so it'll probably have to be an outside process to convert the notes from the sqlite file.

Side note, does anyone have a screenshot of what user notes looked like? They should be easy enough to add, I think.

Sorry if I haven't done much, it's a busy time, and while this is useful, I have it working "well enough" for myself. I took a look at integrating the button into the main extension and it looks easy enough, and if I can do that and add user notes, I'll see about submitting it, assuming I can transfer it to whoever wants to maintain it

# ¿ Dec 17, 2017 04:03

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Chrome Extension - New browser, same great taste!