|
What a doozy of a badwrong opinion. Code reviews are a great tool to improve code quality and team knowledge of the system.
|
#
¿
Jun 13, 2019 20:43
|
|
|
|
| # ¿ May 19, 2024 19:05 |
|
|
Queen Victorian posted:And none of this weirdness and badness was caught in a timely manner and corrected because this guy has a strange habit of only doing a single commit/push when his thing is complete. How old is this guy? He'll stop doing this when he loses a week's worth of work because he didn't want anyone to look at his precious half-finished opus when he drops his laptop into the street but something tells me he hasn't been around long enough to see that actually happen to someone. Good for you getting out. Place sounds incredibly toxic.
|
|
#
¿
Aug 20, 2019 14:40
|
|
|
Can you take me off this chain? I left that work unit 6 months ago but somehow I'm still in this group. Thanks in advance.
|
|
#
¿
Aug 10, 2020 15:06
|
|
|
I do the opposite and write inscrutable code that is heavily commented
|
|
#
¿
Jan 20, 2021 17:19
|
|
|
imo that's a crazy amount to ask of an interviewee. what that tells me is they don't have anyone on their interview panel who can see through bullshitters who say they have done those things.
|
|
#
¿
Jan 25, 2021 21:48
|
|
|
joebuddah posted:I'm hoping to get some insight from more Sr devs. They will never promote you. This is how you know.
|
|
#
¿
May 5, 2021 02:26
|
|
|
good jovi posted:How do people work linters into their team’s flow? Ideally (to me) everyone would just use a real editor that could reliably run on-save hooks, but apparently this is too much to ask... Simply marking a PR as failing unless the code matches linted output feels a little petty, but actually committing linted code and pushing from CI feels a little inflexible. We use formatters with configurations that can be read by our IDEs with format on save. There's a build command you can run locally that does the same thing as our build pipeline, to run all the tests and whatnot. If you forget to run the code format step the pipeline will run it and commit the changes for you. Worst case you just have to do a pull afterward.
|
|
#
¿
May 30, 2021 17:53
|
|
|
Careful with that -D - I caused a coworker to lose work by cleaning up stale branches on remote that they had committed but unpushed work in locally. We all learned a lesson that day.
|
|
#
¿
Aug 13, 2021 13:38
|
|
|
The early return logic could be clearer (maybe with good variable names?) but the root of the suggestion is good. Don't do more work than you need to when it is trivial to break out the loop or whatever. Shame there's no list.find or list.exists in whatever language you're using, that's exactly what you need.
|
|
#
¿
Apr 21, 2022 16:16
|
|
|
We had a process for docs like this at a previous job of mine that was actually very useful. The team was around a dozen people and we had 2 core applications that we maintained, together forming the company's money tree. Since every new feature went into one of these two codebases and everyone worked on them, having context for why changes were being made was super important. To that end, for big features (not literally every change), we'd get everyone in a room, engineers and product, and an engineer who was assigned to would walk through their approach to implementing the feature - what sections of the code will be updated and how, any new database support needed for the feature, etc. These meetings might sound awful but they were extremely useful for having everyone understand the work that was taking place and correcting any misunderstanding or miscommunications before engineering started actually implementing anything. There would almost always be something the engineer didn't account for, and it could come from the product side or the engineering side. It slowed us down somewhat, but we didn't make mistakes in our production environment (mistakes in prod for us cost us a boatload of money, so "testing in prod" was verboten). It also has the added benefit of being a great learning time for newer and less experienced engineers to see code architecture work done in real time and explaining different parts of the system in a practical setting.
|
|
#
¿
May 29, 2022 12:39
|
|
|
Xguard86 posted:PM should ask for some kind of outcome and leave it to the devs to figure out. If the PM thinks the engineering team's implementation won't fit their outcome they need to give more context or communicate the future better. This. If a PM is coming to you asking for a specific technical implementation, something is very wrong. Ask them what they actually want to accomplish and trust your devs to either do it or to explain why doing it is difficult or expensive.
|
|
#
¿
Jul 28, 2022 14:20
|
|
|
Trapick posted:I have no comment on the product, but don't reach out to DataDog/sign up for a trial/whatever unless you want to keep hearing from them multiple times a week. I get calls or emails twice a week because one time I was like "sure I'll look at a demo". Any time I get a sales call like that I tell them the number they dialed is my personal number and I don't take work calls on it. Never had a call back after telling them that.
|
|
#
¿
Nov 16, 2022 03:09
|
|
|
nullfunction posted:All of the responses are 200 OK with an error message in the JSON payload, right? I see you have heard the gospel of graphql
|
|
#
¿
Dec 9, 2022 03:25
|
|
|
A design with no regard for accessibility is not a complete design. If he's really a Professional Designer he should account for these things.
|
|
#
¿
Dec 19, 2022 17:00
|
|
|
prom candy posted:Yeah honestly op just take this exchange to whoever is in charge of firing dumb motherfuckers and let them do their thing. This. This guy has missed the fundamental point that software development is a collaborative exercise. He's insisting on being right when he should be trying to understand the perspective of somebody who hasn't read the ticket he picked up and is only seeing the code (e.g. himself, 6 months from now).
|
|
#
¿
Jan 6, 2023 16:56
|
|
|
I prefer the git CLI, but I'm also the weirdo doing a bunch of other poo poo on the command line. I chalk it up to preferencesmackfu posted:I don’t care how you use git, but I constantly run into people who: Send them this: the git fuckup CYOA
|
|
#
¿
Feb 21, 2023 16:07
|
|
|
I have no idea if it's any good these days, but I used to use Synergy to use one set of inputs across multiple computers.
|
|
#
¿
Apr 21, 2023 05:16
|
|
|
Pagination is an MVP feature in my mind, alongside whatever you use for observability. Exposing a "get literally everything" access mechanism is just asking for trouble.
|
|
#
¿
Jun 9, 2023 12:20
|
|
|
Bongo Bill posted:I would simply write good code instead of bad. This only works if there was such a thing. The truth is all code is bad.
|
|
#
¿
Jul 12, 2023 01:18
|
|
|
Judge Schnoopy posted:it's just so insane and hard to work with. But enough about Go
|
|
#
¿
Jul 16, 2023 19:19
|
|
|
epswing posted:
̸̷̶̶̭́F̸̸̸̷̴͔̅i̶̸̶̷̶͙̓x̵̸̶̷̸̞͌é̸̶̵̸̴̲d̷̸̸̶̴͙̽.̶̸̶̶̶͎̏
|
|
#
¿
Jul 19, 2023 22:26
|
|
|
Cup Runneth Over posted:Notepad++ "new 1," "new 2," "new 3," etc. unsaved files I also work this way. On my linux machine it's sublime text, but same idea.
|
|
#
¿
Sep 22, 2023 12:28
|
|
|
Am I the odd one out for enjoying PRs? I find they're one of the best places to spend time if your goal is increasing code quality. downout posted:One of our teams has a bunch of engineers that always ask “please approve this PR!” Culture is a hard thing to change. They misunderstand the point of a PR. The question the reviewer is answering is not "does this do the thing?" - the author asserted that it does the thing when they opened the PR. The question is "can this be made better?" which can almost always be answered with "yes." From there the conversation can be about the relative effort and value of any proposed changes, and by that collaboration you will nearly always walk away with an improved solution. And who knows, somebody might learn something
|
|
#
¿
Oct 7, 2023 21:02
|
|
|
We've been using Backstage TechDocs to collect documentation from GitHub, confluence, and Google docs. Over the years we had things maintained in disparate places and this gets them all in one place, which has been hugely beneficial. Some of our more complex code has a multi-directory docs folder with everything from system architecture diagrams to operations run books.
|
|
#
¿
Nov 12, 2023 18:38
|
|
|
Cugel the Clever posted:I'm immensely jealous of the "ran out of work for the day" crowd, though I don't entirely understand it... There's always something available, even if it's just refactoring, bug fixes, operational improvements, or self-driven learning. What if you need to write a 10 paragraph decision log for why your changes should be made and a comparative analysis of which data type to use for a database column before you can do any of that e; the decision log requires a review meeting and signoff from the ivory tower
|
|
#
¿
Jan 16, 2024 18:54
|
|
|
Mega Comrade posted:management are control freaks and the idea of trusting development... is just not something they feel comfortable doing.
|
|
#
¿
Feb 20, 2024 15:28
|
|
|
ChickenWing posted:oof ouch my MBAs will do anything to not pay down tech debt
|
|
#
¿
Apr 13, 2024 20:18
|
|
|
downout posted:Every time our executives open their mouth, they expose how ignorant they are about software engineering. Half of our stack is running on an end of life transport layer and nobody cares. Is that better or worse than what you're dealing with?
|
|
#
¿
Apr 18, 2024 00:48
|
|
|
|
| # ¿ May 19, 2024 19:05 |
|
|
Judge Schnoopy posted:To me it's an equation of time. I only have so many hours in the day and most of them are spent building the product. The product team is designed to spend all of their time focusing on customers. I can't be effective while focusing on customers and product isn't going to be effective focusing on how the solution is built. Vulture Culture posted:Most people don't quite grasp the gravity of the situation where product is bottlenecked so badly that engineering teams are asking, "What do I do next?" abraham linksys posted:ive only ever worked places where product managers are literally just Tom from office space. itd be cool to meet one who's good at their job someday
|
|
#
¿
May 1, 2024 21:36
|
|