Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Post
  • Reply
Nalin
Sep 29, 2007

Hair Elf
I've discovered that the "Enable toggling of individual user avatars" requires the "Enable user notes" option to be enabled. You should make the avatar toggle option a sub-option of user notes.

Under "Image Display Options", under the "Linked-Image Hover" section, the "Only show filename, not whole URL" option is not properly disabled (the checkbox can still be checked).

Finally, I've noticed that the "Configure SALR" link in the forum header is no longer opening my options page. It would also be nice if we had the ability to open up the SALR options via the grenade icon, too.

Adbot
ADBOT LOVES YOU

Nalin
Sep 29, 2007

Hair Elf

astral posted:

This should've been caused on extension update (the existing content scripts get broken) and should be resolved if you reload the affected page(s) (and not affect any newly-opened ones).

So, for me, this didn't work. Yes, I updated the extension, but reloading the page and opening new pages were all broken. I had to fully restart my browser in order to fix it. I'm not sure if this was a one-time thing or not.

Nalin
Sep 29, 2007

Hair Elf
It would be nice if you could bring back the arrow on the Quote / Reply buttons if you have quick reply enabled. Sometimes I would like to use the normal reply functionality and I'm not sure how to activate it.

Nalin
Sep 29, 2007

Hair Elf

Megillah Gorilla posted:

Like the link to Lotax's banned Twitter account any time the forums are down for maintenance?

If we change that then search will break again.

Nalin
Sep 29, 2007

Hair Elf
You know that "Convert webm/gfycat links to inline video" option? Can it be expanded to include imgur .gifv links? I've seen people somehow embed .gifv videos inside <img> tags on the forum and my Firefox doesn't show them. Is that happening for anyone else with Firefox?

Nalin
Sep 29, 2007

Hair Elf
I probably should have checked, but yeah, no browser will show it if it is inside <img> tags. Weird since I see it every now and then. I figured something like Chrome was just allowing it for whatever reason.

Nalin
Sep 29, 2007

Hair Elf
Why would that get it kicked off of AMO?

Nalin
Sep 29, 2007

Hair Elf

Sereri posted:

Lowtax is bad at css, but also salr adds the [1] button which causes the left container there to overflow onto a second line.
The right container stays the previous size which exposes the white background of the page.

SALR adds a white-space: nowrap CSS property that prevents that, though. Did something change? Maybe he has an older version of SALR or something else messing with the CSS?

Nalin
Sep 29, 2007

Hair Elf

astral posted:

Version 2.1.8.14 is now out for Firefox!

  • Improvements to quick quote pasted link tagging (never see the forums break a pasted Wikipedia URL on the parentheses again!)
  • Mod/Admin highlighting now detects mods and admins in threads! This means :siren:new admins will actually be tracked:siren:

Nice! But the quick reply window's live preview doesn't work when quoting your message. The quote tags don't parse.

Nalin
Sep 29, 2007

Hair Elf

Serfer posted:

Anyone else on firefox having issues loading twitter? For the past month or two, Firefox is extremely slow to load the twitter embeds after loading a thread. It doesn't happen in Chrome, so it must be something in Firefox causing it.

If you don't want to disable fission, you can just use the stylus / userscript I linked:

https://forums.somethingawful.com/showthread.php?action=showpost&postid=520247246

You can also wait for Firefox 97 where it is fixed. Firefox 97 goes into beta status on the 11th.

Nalin
Sep 29, 2007

Hair Elf
It looks like browsers automatically disconnect open ports to extensions after 5 minutes or so. SALR probably has to listen for a disconnection and re-open the port.

See:
https://github.com/GoogleChrome/developer.chrome.com/issues/504
https://bugs.chromium.org/p/chromium/issues/detail?id=1146434

EDIT:

https://github.com/MasterOdin/salr-redux/blob/master/extension/js/background.js

Like, shouldn't there be a port.onDisconnect.addListener call that recreates the port?

Nalin fucked around with this message at 08:58 on Mar 15, 2023

Nalin
Sep 29, 2007

Hair Elf
I'm pretty sure everything is related to the last post I made. Browsers are disconnecting the extension and the extension doesn't re-add itself.
EDIT: Specifically, service workers don't stay connected. You have to reconnect the service worker after it disconnects if you want it to stay persistent.

Nalin fucked around with this message at 18:34 on May 7, 2023

Nalin
Sep 29, 2007

Hair Elf

BlankSystemDaemon posted:

A datapoint I have is that even after shutting down Firefox, adding notes doesn't work - so I'm not sure it's a question of service workers expiring.

Leave the page open for a minute. Press F12 to open the dev tools. Click Edit Note > Delete and notice the error. Then refresh the page and do the same. No error. Leave the page alone for a bit. Try again. Error is back.

It is absolutely the service worker expiring.

Nalin
Sep 29, 2007

Hair Elf

ChickenOfTomorrow posted:

so how does one stop a service worker from expiring

You don't.

qsvui posted:

or is there a way to restart one?

Only via the extension code. One of the SALR devs would have to program a solution and release an extension update. I could try developing a solution, but I would never be able to deploy the changes. We would still need one of the SALR devs to package it up.

Nalin
Sep 29, 2007

Hair Elf

BlankSystemDaemon posted:

Looks like there's multiple people (including Astral) with write access to the github repo, and Master Odin is still active on the forums.

So it looks like if you file a PR, someone might be able to do the needful.

https://github.com/MasterOdin/salr-redux/pull/104

Well, it should maybe work. I had to test in Edge because I have some work open in a private window tab in Firefox which means I can't restart the browser to mess with extensions without losing my work. If somebody else wants to clone the code and test in Firefox that would be great, otherwise it might take me a while to get around to it.

EDIT: I was able to test in Firefox today and it worked. Master Odin said in the PR it would take them a week to get to it as they are currently ill.

Nalin fucked around with this message at 00:16 on May 24, 2023

Nalin
Sep 29, 2007

Hair Elf

hifi posted:

If I have the something awful link disabled in the nav menu links then keyboard shortcuts don't work anymore and there's a console error from salr.js

windows 10, firefox 118.0.1




If i toggle that one checkbox then the keyboard shortcuts work again

Ah. It is checking for an anchor tag with an href attribute that exactly matches a URL fragment. It should be searching for an href attribute that contains the URL fragment.

Basically, you have stuff like this:
code:
<li>- <a href="https://www.somethingawful.com/frontpage/">Something Awful</a></li>
<li>- <a href="/query.php">Search the Forums</a></li>
At some point the URL to the front page got changed to be an absolute URL and the script broke. I'll submit a PR to fix this one too. We are also still waiting for my previous bugfix to actually be pushed live.

Adbot
ADBOT LOVES YOU

Nalin
Sep 29, 2007

Hair Elf
https://developer.chrome.com/blog/deprecating-web-sql/

Nice. Removed in Chrome 119. But how did this ever work in Firefox? It claims Gecko never supported Web SQL.

Anyway, it looks like that whole feature needs to be re-written now.

  • 1
  • 2
  • 3
  • 4
  • 5
  • Post
  • Reply