|
The code looks good! You spelled receive incorrectly in your comment on line 57 of Receiver.java. If you could go ahead and fix that, i'll mark this as reviewed.
|
#
?
Aug 30, 2020 01:50
|
|
|
|
| # ? May 6, 2024 00:03 |
|
|
AnimeIsTrash posted:The code looks good! You spelled receive incorrectly in your comment on line 57 of Receiver.java. If you could go ahead and fix that, i'll mark this as reviewed. Thank you!
|
|
#
?
Aug 30, 2020 03:27
|
|
|
power botton posted:serious question other than developers are whiny children why doesn't everyone use pre-commit hooks to format a file in a consistent style. The only serious objection I'm aware of is that completely altering the formatting of a file disrupts git blame. But it's not a significant objection, it's the price you pay for failing to be consistent to begin with. It's a one-time thing. Just rip the band-aid off.
|
|
#
?
Aug 30, 2020 10:48
|
|
|
power botton posted:serious question other than developers are whiny children why doesn't everyone use pre-commit hooks to format a file in a consistent style. historically formatting tools have been absolute trash. afaik most languages still don't have a passable one (to some extent because most languages have no consensus formatting and every tool built winds up a fragile pile of options).
|
|
#
?
Aug 30, 2020 11:51
|
|
|
Merging this into Goldmine
|
|
#
?
Sep 23, 2020 19:55
|
|
|
Doom Mathematic posted:The only serious objection I'm aware of is that completely altering the formatting of a file disrupts git blame. But it's not a significant objection, it's the price you pay for failing to be consistent to begin with. It's a one-time thing. Just rip the band-aid off. thats what we did for our codebase; if it matters enough, we can always go back before the formatting. turns out it often rarely matters, and now most of our code is consistently formatted and less like a freshman group project in programming 1
|
|
#
?
Sep 24, 2020 14:58
|
|
|
a foolish consistency is the hobgoblin of little minds, adored by little statesmen and philosophers and divines
|
|
#
?
Sep 24, 2020 15:09
|
|
|
*rejects PR, pushes identical commit with myself as author*
|
|
#
?
Sep 24, 2020 19:33
|
|
|
I’m afraid our source evaluation algorithm has declared your code insufficiently beautiful. please make it more beautiful and try again
|
|
#
?
Sep 24, 2020 19:48
|
|
|
Carthag Tuek posted:*rejects PR, pushes identical commit with myself as author* actually you'll see looking through the PR history that this exact change was proposed six months ago and rejected with prejudice closing yours with prejudice
|
|
#
?
Sep 24, 2020 20:37
|
|
|
psiox posted:actually you'll see looking through the PR history that this exact change was proposed six months ago and rejected with prejudice I saw that my PR was closed. As per my last email, we discussed why this change was needed so i'm not sure why it was rejected and closed. *ccs managers*
|
|
#
?
Sep 26, 2020 17:54
|
|
|
server logs show that you submitted this pr using chrome when you know full well that the corporate standard browser is internet explorer. this is your second strike before your bitbucket access rights are revoked.
|
|
#
?
Sep 26, 2020 18:12
|
|
|
Archduke Frantz Fanon posted:fixed unit test i feel seen and i hate it
|
|
#
?
Sep 26, 2020 18:23
|
|
|
Carthag Tuek posted:*rejects PR, pushes identical commit with myself as author* this but I actually have no idea what I'm doing
|
|
#
?
Sep 26, 2020 18:32
|
|
|
hey this change looks good, but i need to hit my commit quota for the sprint so i'm going to add this to my latest branch *closes pr, manually copies changes into own branch, commit, force push master*
|
|
#
?
Sep 26, 2020 23:45
|
|
|
Ciaphas posted:i feel seen and i hate it
|
|
#
?
Sep 27, 2020 07:12
|
|
|
run ktlint
|
|
#
?
Oct 5, 2020 04:11
|
|
|
I know you added a missing return to this method but while you’re in there please remove the @ExperimentalCoroutinesApi and any experimental code, we shouldn’t be using experimental APIs in production
|
|
#
?
Oct 5, 2020 04:15
|
|
|
what the gently caress do you mean we built our entire network stack in experimental kotlin flows and channels how did this get accepted into the codebase in the first place? I go on holiday for two weeks and this happens yet while I’m here all I see are PRs for improvements or change requests from business? how does this happen??
|
|
#
?
Oct 5, 2020 04:17
|
|
|
oh as of Kotlin 1.4 they’re not experimental anymore and we’ve already migrated to 1.4? and it all works as expected? I didn’t have a chance to compile and test it yet. if that’s the case please remove useless annotations while you’re in there thanks
|
|
#
?
Oct 5, 2020 04:18
|
|
|
hey ive got a small pr to have you send some better formatted data to our apigitlab posted:432 changed files
|
|
#
?
Oct 5, 2020 04:33
|
|
|
this code doesn’t run on bi-endian machines like vax, please make it portable
|
|
#
?
Oct 5, 2020 05:05
|
|
|
Hi, just following up on my earlier email. Do you think that you'll be able to get to it by Friday? Thanks, BBGS
|
|
#
?
Oct 5, 2020 05:23
|
|
|
I’ll review your change after you review the 12 changes I sent you this week and you’ve ignored until now.
|
|
#
?
Oct 5, 2020 07:38
|
|
|
carry on then posted:commit quota that's a new one
|
|
#
?
Oct 5, 2020 18:41
|
|
|
Share Bear posted:that's a new one made that part up but i've definitely had people close my pr and copy my changes into one of theirs instead of just approving mine because it's "easier" (they are padding their contributions)
|
|
#
?
Oct 5, 2020 21:35
|
|
|
Ownedhttps://twitter.com/tim_nolet/status/1317061818574082050
|
|
#
?
Oct 16, 2020 18:31
|
|
|
lol imagine using a permissive license
|
|
#
?
Oct 16, 2020 18:35
|
|
|
i use cc-by-sa for my smallbeer projects the only kind I have tho so idgaf
|
|
#
?
Oct 16, 2020 18:39
|
|
|
I made this thing and would like it to be freely available for anyone to use for any reason. Wait you’re going to try to use it? That’s just rude.
|
|
#
?
Oct 16, 2020 18:41
|
|
|
next time choose a license that requires attribution PR rejected
|
|
#
?
Oct 16, 2020 19:14
|
|
|
Hey there, Just wanted to check in before the weekend. If possible, could you take a gander at my pr today? Regards, BBGS
|
|
#
?
Oct 16, 2020 19:35
|
|
|
it’s already weekend in my time zone. I’ll look at it on Monday (your Wednesday)
|
|
#
?
Oct 16, 2020 19:45
|
|
|
ok thx I'm just gonna push these extra irrelevant commits to the pr 🙏
|
|
#
?
Oct 16, 2020 20:17
|
|
|
confession: i made a placeholder commit in my local branch today so i can amend in whatever i want next week and make it seem like i already did that i know i could do it ground up next week with datetime fuckery or extra cmd args, but i also know ill be tired and its easier to amend so its a present for myself
|
|
#
?
Oct 17, 2020 00:22
|
|
|
Sorry its been a crazy week, still need to review that PR, will get to it later today hopefully
|
|
#
?
Oct 17, 2020 07:56
|
|
|
just tidying up the old prs, is this change still required or can I just close it
|
|
#
?
Oct 17, 2020 09:04
|
|
|
closing due to lack of response. please open a new pr if you still wanted this
|
|
#
?
Oct 17, 2020 10:51
|
|
|
your pr won’t merge cleanly anymore, please rebase. ping me once you rebase and I will wait a week to review it so that it doesn’t merge again.
|
|
#
?
Oct 17, 2020 14:51
|
|
|
|
| # ? May 6, 2024 00:03 |
|
|
hmm, it's still tagged CLA required even though you're sure you signed it. weird. well i'll ask around the internal slack and forget to get back to you
|
|
#
?
Oct 17, 2020 16:27
|
|