|
👀
|
#
?
Oct 18, 2020 00:31
|
|
|
|
| # ? May 6, 2024 07:52 |
|
|
Sorry, but I just heard from the PO that this project was cancelled last week. Can you extract the standalone core business value so it can be contribute to our value-stream on an ongoing basis? Let me know when you've productionalized it into a micro-service, I figure you'll have no trouble finishing it by the end of this sprint? Thanks!
|
|
#
?
Oct 18, 2020 01:59
|
|
|
The Management posted:your pr won’t merge cleanly anymore, please rebase. ping me once you rebase and I will wait a week to review it so that it doesn’t merge again.
|
|
#
?
Oct 18, 2020 02:04
|
|
|
why are you still doing this? I thought I was quite clear that we do not do pr any more. don’t bother replying, you’re fired. elon
|
|
#
?
Oct 18, 2020 08:54
|
|
|
PR review third. There isn't even a second thing, that's just how little we value PRs.
|
|
#
?
Oct 27, 2020 21:33
|
|
|
Carthag Tuek posted:confession: ah, but does this work even if you sign your commits
|
|
#
?
Oct 27, 2020 21:37
|
|
|
hey we just added codeclimate and have 30k issues to solve, can you resolve the ones in your branch? *Code climate detected 734 new issues on a diff of 60 lines changed*
|
|
#
?
Oct 27, 2020 21:40
|
|
|
So here is my 300 line script that doesn't do anything written in a language no one knows. Please review by sprint review in 30 minutes.
|
|
#
?
Dec 3, 2020 21:29
|
|
|
Hello again, I was just going through my emails today and I noticed that I never received a response from you about my earlier PR. It is entirely possible that you responded but I may have accidentally deleted it (curse you, email filters *shakes fist*) if so. If you have a chance, would you mind sending / re-sending a response? Or maybe just reviewing it would be easier. Whatever is easier for you. Thanks! BBGS
|
|
#
?
Dec 3, 2020 21:40
|
|
|
I noticed everyone +1’d my change with no comments or downvotes. can someone approve it? it’s been like 4 days.
|
|
#
?
Dec 3, 2020 22:14
|
|
|
*rather than ask some questions, it'll be easier for me to rewrite this pr and post it as a comment*
|
|
#
?
Feb 12, 2024 05:00
|
|
|
code looks good but looks like you've checked in a binary blob on your branch, it appears to be a PDF of your latest paystub? alt-tabs to Thunderbird, emails HR and /ccs manager: hey dave why does this chucklefuck get paid 30% more than me
|
|
#
?
Feb 12, 2024 15:43
|
|
|
Hi! I've only changed a couple things. I dont know why its flagging all these white space things. There's about 200 files here with diffs. Thanks!
|
|
#
?
Feb 12, 2024 20:32
|
|
|
Dijkstracula posted:code looks good but looks like you've checked in a binary blob on your branch, it appears to be a PDF of your latest paystub? lmao, had someone commit a picture of their house in a PR
|
|
#
?
Feb 12, 2024 20:43
|
|
|
Cheen posted:lmao, had someone commit a picture of their house in a PR a product manager once insisted I put all my graphics files in git, the developers did not enjoy that and eventually yelled at him enough that I got let off the hook
|
|
#
?
Feb 12, 2024 20:47
|
|
|
ADINSX posted:Sorry its been a crazy week, still need to review that PR, will get to it later today hopefully Still planning on getting to this it’s been a crazy couple of years
|
|
#
?
Feb 12, 2024 20:51
|
|
|
qirex posted:a product manager once insisted I put all my graphics files in git, the developers did not enjoy that and eventually yelled at him enough that I got let off the hook just save them as svg, viola, now you're allowed to version control them
|
|
#
?
Feb 12, 2024 21:02
|
|
|
this was back when putting a svg in your site meant the acrobat plug in would launch and there was like a 40% chance the browser would just crash I enjoy svgs today because we can recolor icons and stuff without me having to update 1000 files
|
|
#
?
Feb 12, 2024 21:19
|
|
|
I don’t even program UIs 
|
|
#
?
Feb 12, 2024 21:25
|
|
|
qirex posted:a product manager once insisted I put all my graphics files in git, the developers did not enjoy that and eventually yelled at him enough that I got let off the hook lol, a long time ago our team had some user testing videos we needed to transfer and there was no shared drive available so– I've never seen an it guy storm over so fast and dress someone down since  i want to say that was in clearcase. it was already a rickety mess without massive binary blobs
|
|
#
?
Feb 13, 2024 01:58
|
|
|
gentle ping. this change needs to get in by tomorrow to make the next release. it’s been in review for over 2 days. this is a p0 bug fix, ship blocker changes: 28 files changed 12 files added 1 files deleted +4417 lines -832 lines cc: my boss, your boss, director, pm, pm, pm, pm lead, qa lead
|
|
#
?
Feb 19, 2024 06:58
|
|
|
|
| # ? May 6, 2024 07:52 |
|
|
lgtm. btw I will be ooo for the week before and after next release
|
|
#
?
Feb 19, 2024 07:33
|
|
