|
I seem to be having trouble with the update. I lost all highlighting, the quick reply box, and the "open unread threads in new tabs" link (maybe other stuff, but those are the things I use the most, so that's what I've noticed). I tried unchecking the options, restarting Chrome, rechecking them, restarting again - no luck. I uninstalled SALR Redux, reinstalled it, and it seemed to be working - I had the red and blue buttons in the User CP, at any rate. I went back in and customized things, and now nothing works again. I clicked "dump settings", but I'm not sure what to do with the next screen, so I can't be of too much help yet.
|
# ? Jul 16, 2013 17:27 |
|
|
# ? May 10, 2024 10:28 |
|
It sounds like something about SALR is breaking. Two things to help me: 1. Get the settings
It most likely is some feature of jQuery that got changed/depreciated and is causing SALR to crash.
|
# ? Jul 16, 2013 17:39 |
|
1. Settings dump: http://pastebin.com/MPDbwut9 2. Error messages: code:
|
# ? Jul 16, 2013 17:50 |
|
oh, apparently I hit save as draft instead of publishing the bug-fix update yesterday. SALR should update with this fixed shortly. You'll know it's fixed if it's at 2.0.1.
|
# ? Jul 16, 2013 17:56 |
|
I was going to post about things not working, but I just updated to 2.0.1, and it's all good. I noticed a weird field in the dump settings page, though. I have a key ignoreBookmarkStar, which has no associated value with it. I'm not sure if it'll cause any problems, but thought you might want to know about it.
|
# ? Jul 16, 2013 20:34 |
|
Just wanted to pop in and say thanks. I have been lucky and haven't had any issues (ever) but I still appreciate that you're working on this. So thanks. e: actually for like a couple days quick reply simply went away, but then it came back. But that doesn't really count. Mystery.
|
# ? Jul 17, 2013 00:32 |
|
How do you get it to update? Is it like other Google things and it's a staggered rollout?
|
# ? Jul 17, 2013 01:11 |
|
Master_Odin posted:in that extension folder, if you go to /js/quick-reply.js, on line 403, the height of the box gets set: 450px seems to be the right size. If you change the CSS to auto-size it, is there a way in JS to pull that automatically generated height out as a variable & use that instead of hardcoding in specific sizes?
|
# ? Jul 17, 2013 01:19 |
|
I'm having some weirdness with 2.0.1. Second, pages 17 & 18 of this GBS thread are really screwed up, might have nothing to do with SALR and just be that thread since I haven't noticed it elsewhere. http://forums.somethingawful.com/showthread.php?noseen=0&threadid=3542013&perpage=40&pagenumber=17#pti1 It loads 3 posts then there is a gigantic white space then a gigantic black space. If you try to scroll down the page just jitters. All I can do is use the Home or End keys to move to the top or bottom. wormil fucked around with this message at 08:56 on Jul 17, 2013 |
# ? Jul 17, 2013 08:51 |
|
hooah posted:How do you get it to update? Is it like other Google things and it's a staggered rollout? wormil posted:Second, pages 17 & 18 of this GBS thread are really screwed up, might have nothing to do with SALR and just be that thread since I haven't noticed it elsewhere. ClassActionFursuit fucked around with this message at 11:25 on Jul 17, 2013 |
# ? Jul 17, 2013 09:56 |
|
I just noticed you added the option for thread sorting in just the Bookmarks page. Thank you so much!
|
# ? Jul 17, 2013 14:07 |
|
Coming in the next version of SALR: User Notes are now synced to your google account and available on whatever computer you're on. unpronounceable posted:I was going to post about things not working, but I just updated to 2.0.1, and it's all good. oldskool posted:450px seems to be the right size. If you change the CSS to auto-size it, is there a way in JS to pull that automatically generated height out as a variable & use that instead of hardcoding in specific sizes? quick-reply.css quick-reply.js Just copy and paste the contents of those files into the appropriate locations (as shown above) and let me know if it works. Everything should be adjusted automatically based off height: auto, such that your live preview box will be a bit bigger, the smilies/bbcode menu might be changed, etc. I'm not 100% sure how well this'll work, but we'll see as this does make everything work A LOT better on my smaller laptop. wormil posted:I'm having some weirdness with 2.0.1.
|
# ? Jul 17, 2013 17:33 |
|
I'll read them on my phone and see.
|
# ? Jul 17, 2013 18:14 |
|
Master_Odin posted:Coming in the next version of SALR: User Notes are now synced to your google account and available on whatever computer you're on. Really fantastic. Thanks for all your work.
|
# ? Jul 17, 2013 18:56 |
|
Master_Odin posted:450px is incredibly awful for me! But yeah, I rewrote things that it should dynamically resize things based a bit off what the browser feels like assigning to auto I guess. If you wouldn't mind testing two files for me, I'd appreciate it as this is mainly aimed at you (and the other user who had issues with this): Tried it on my work computer (where the original version worked fine): window opens fine, window closes fine. Window minimizes fine but does not want to un-minimize all the time; I can't figure out what the pattern is but sometimes it opens back up as expected, and then suddenly the up unminimize arrow just opens & closes the smiley window and the big quick reply box won't come up from the bottom. fake edit: and then sometimes it works but the X button toggles the smiley window instead.
|
# ? Jul 17, 2013 19:06 |
|
Is there a way to define what a "long quote" is for the purposes of collapsing them? It's currently collapsing posts with one image and one word.
|
# ? Jul 18, 2013 01:36 |
|
oldskool posted:Tried it on my work computer (where the original version worked fine): window opens fine, window closes fine. Window minimizes fine but does not want to un-minimize all the time; I can't figure out what the pattern is but sometimes it opens back up as expected, and then suddenly the up unminimize arrow just opens & closes the smiley window and the big quick reply box won't come up from the bottom. Does the same thing on my home PC. Seems to work fine until some random trigger causes the buttons to turn into the smiley button.
|
# ? Jul 18, 2013 02:13 |
|
E: never mind. The location of the button got changed.
ilkhan fucked around with this message at 19:39 on Jul 18, 2013 |
# ? Jul 18, 2013 19:36 |
|
My keyboard navigation isn't working.
|
# ? Jul 19, 2013 00:07 |
|
Aatrek posted:My keyboard navigation isn't working. It seems to work fine for me? Two things to help me: 1. Get the settings
|
# ? Jul 19, 2013 00:50 |
|
Here you go: http://pastebin.com/raw.php?i=VmMA3Cx8
|
# ? Jul 19, 2013 02:01 |
|
Master_Odin posted:Can you get it to happen sorta reliably? If so, if you could turn off "tap to click", and see if it continues to happen. I'm guessing that some of your presses are registering as a right click and as you pull downard, you hit the bottom button which refreshes the page. If that is the case, I'll add a setting that enables/disables that behavior as the user wants. If you rapidly two-finger tap over and over on the trackpad without actually clicking it will eventually start refreshing the page and will continue to do so with every subsequent tap if you slow down. Here's where it differs from when it happens organically though, if you stop tapping and let the page fully load then two-finger click or tap, it returns to behaving correctly. When it just happens without forcing it you can wait as long as you want, two-finger click or tap will always refresh the page until you either 1) use Option to toggle the gestures off, 2) you switch tabs, or 3) you focus on another application and back. I imagine due to Chrome's tab sandboxing that 2 & 3 are in essence the same thing. Another thing to note, you can watch the cursor when you're rapidly clicking to force the reload and it definitely isn't moving. e: Found an even easier way to force it and it's much more reliable. Load a page and rapidly two-finger tap while it's loading. As far as I can tell it does it every time. ClassActionFursuit fucked around with this message at 12:10 on Jul 19, 2013 |
# ? Jul 19, 2013 12:08 |
|
Youtube video links don't get pasted correctly. If I use quick reply it pastes it as a url, and if I use the video tag it doesn't work as well. Its only when I take the end of the url and use the video tag it embeds correctly. Can you auto-detect youtube links like the native forum does?
|
# ? Jul 23, 2013 17:59 |
|
oldskool posted:Tried it on my work computer (where the original version worked fine): window opens fine, window closes fine. Window minimizes fine but does not want to un-minimize all the time; I can't figure out what the pattern is but sometimes it opens back up as expected, and then suddenly the up unminimize arrow just opens & closes the smiley window and the big quick reply box won't come up from the bottom. hooah posted:Is there a way to define what a "long quote" is for the purposes of collapsing them? It's currently collapsing posts with one image and one word. Aatrek posted:My keyboard navigation isn't working. LastInLine posted:I've found a way to kind of force the same problem but you'll need tap to click turned on. kri kri posted:Youtube video links don't get pasted correctly. If I use quick reply it pastes it as a url, and if I use the video tag it doesn't work as well. Its only when I take the end of the url and use the video tag it embeds correctly. Master_Odin fucked around with this message at 18:42 on Jul 23, 2013 |
# ? Jul 23, 2013 18:39 |
|
Master_Odin posted:This should be fixed in the 2.0.2 release. The bottom button was being defined in a slightly odd fashion I guess that caused it to be displayed incorrectly until the page was fully loaded. This made it so by tapping the double click caused the buttons to appear, and for you to be hitting the bottom button. Changed the CSS around though so it's more inline with the code for the other buttons, and I can't seem to replicate this, but I never could do it reliably in the first place.
|
# ? Jul 23, 2013 19:22 |
|
LastInLine posted:Weird that you can't replicate it, now that I've found out that I can do it by two-finger tapping any time a page is loading I can force it 100% of the time. The reason I was seeing it mostly in the YOSPOS pics thread is because of GIFs taking forever to load.
|
# ? Jul 23, 2013 19:37 |
|
Master_Odin posted:Yeah, fixed this. I didn't realize an array of variables about the state of the quick-reply box gets "reset" when closing the window. Fixed this, as well changed the default behavior of the QR to open expanded if it's closed, regardless if you minimized it before closing it. You can get this by just updating quick-reply.js. Works great. Thanks so much, I know you put a ton of time into this bug just for apparently me & one other person and I appreciate it.
|
# ? Jul 23, 2013 20:04 |
|
oldskool posted:Works great. Thanks so much, I know you put a ton of time into this bug just for apparently me & one other person and I appreciate it. I'll release this live hopefully tomorrow for everyone else. Just waiting on more details about the hotkeys and youtube video at the moment to see if a couple more bug fixes are going to make it in. Master_Odin fucked around with this message at 00:31 on Jul 24, 2013 |
# ? Jul 23, 2013 22:18 |
|
I will try to explain the Youtube embedding thing a bit better. If I use quick reply and paste in a youtube url, and submit, it creates a [url] link. If I use quick reply and highlight the youtube url and select "video" it creates a broken [video] link. If I don't user quick reply and I paste in a youtube video it auto-embeds. Let me know if I did a terrible job explaining this.
|
# ? Jul 24, 2013 00:11 |
|
Master_Odin posted:Using your settings, and my keyboard navigation remains unaffected. Can you try step 2 (report the error message). If that doesn't work, can you tell me what particular keys don't work, as well as if you were doing anything special at the time (opened quick-reply box and closed it, then keyboard shortcuts didn't work, etc.) I'm not getting an error message - where would I see it? Any keys with navigation components don't do anything: 'r' doesn't bring up the reply window; 'e' doesn't bring up an Edit window; 'Esc' doesn't get me out of the Quick Reply, etc.
|
# ? Jul 24, 2013 02:14 |
|
kri kri posted:I will try to explain the Youtube embedding thing a bit better. (though this does point out that the live preview bbcode engine needs an update to handle more cases as it breaks pretty easily on something like a lone [url] tag) Aatrek posted:I'm not getting an error message - where would I see it? Any keys with navigation components don't do anything: 'r' doesn't bring up the reply window; 'e' doesn't bring up an Edit window; 'Esc' doesn't get me out of the Quick Reply, etc. e: this is because I moved some logic above where it was, above a variable that got defined that was used in the logic I moved. If you didn't get that, don't worry, it's simply that I'm an idiot sometimes basically. A fix will be released for this tomorrow. Master_Odin fucked around with this message at 03:36 on Jul 24, 2013 |
# ? Jul 24, 2013 03:29 |
|
Using quick reply doesn't auto-format the youtube link though. It just creates a url. I am talking about embedding the video into the forums. This http://www.youtube.com/watch?v=23fdQ6hQdoA vs https://www.youtube.com/watch?v=23fdQ6hQdoA It works perfectly fine if I don't use quick reply.
|
# ? Jul 24, 2013 04:29 |
|
Emoticons in fi.somethingawful.com/safs get turned to links in read posts when the option to do so to images is on.
|
# ? Jul 24, 2013 20:17 |
|
kri kri posted:Using quick reply doesn't auto-format the youtube link though. Flagrama posted:Emoticons in fi.somethingawful.com/safs get turned to links in read posts when the option to do so to images is on. Anyway, uploaded 2.0.2 to the web store now: Changelog posted:### v2.0.2 (7/25/2013) Master_Odin fucked around with this message at 14:00 on Jul 31, 2013 |
# ? Jul 25, 2013 16:40 |
|
Sweet, I can Esc out of quick reply again. Thanks, Master_Odin! E: What counts as a "long" quote? SALR keeps tldr:ing quotes with 30 words. An option to increase the amount of words until it does would be sweet. Stare-Out fucked around with this message at 21:14 on Jul 25, 2013 |
# ? Jul 25, 2013 21:04 |
|
Stare-Out posted:Sweet, I can Esc out of quick reply again. Thanks, Master_Odin! Master_Odin posted:
|
# ? Jul 26, 2013 00:39 |
|
Huh, missed that. I didn't realize it wasn't based on word count.
|
# ? Jul 26, 2013 00:56 |
|
How would I go about reporting that threads I reply to seem to become unbookmarked at random? EDIT: EDIT 2: I just noticed it seems to untoggle "Bookmark Thread" when editing quick replies. Even though it's set to bookmark quick-replied threads. dont be mean to me fucked around with this message at 02:18 on Jul 28, 2013 |
# ? Jul 28, 2013 02:10 |
|
Sir Unimaginative posted:How would I go about reporting that threads I reply to seem to become unbookmarked at random? (For reference, the actual post page does the same thing by default)
|
# ? Jul 28, 2013 02:30 |
|
|
# ? May 10, 2024 10:28 |
|
Master_Odin posted:Unless for some reason that after you use the quick reply, it unbookmarks threads which would make no sense whatsoever. This is precisely what was happening. And the quick edit had "Bookmark thread" unchecked, even though it was checked in settings, and did in fact unbookmark the thread unless I manually re-checked it.
|
# ? Jul 28, 2013 02:49 |