Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Locked thread
withak
Jan 15, 2003


Fun Shoe
Yeah the quick edit window sends the state of that checkbox every time. If it is unchecked then the thread gets unbookmarked.

Adbot
ADBOT LOVES YOU

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Sir Unimaginative posted:

This is precisely what was happening.

And the quick edit had "Bookmark thread" unchecked, even though it was checked in settings, and did in fact unbookmark the thread unless I manually re-checked it.
Oh, I get it now. Weird that edit works so differently from reply. Got a fix for it that I'll upload shortly and it's uploaded to the web store. You should get 2.0.3 shortly that fixes this issue as well as add a question mark help thing to that particular option just so people understand.

Master_Odin fucked around with this message at 03:24 on Jul 28, 2013

gradenko_2000
Oct 5, 2010

HELL SERPENT
Lipstick Apathy
I'm getting this weird thing where the "user has edited this post" line keeps getting a red block next to each character:


Pastebin of my settings:
http://pastebin.com/vEeAAbfG

Flagrama
Jun 19, 2010

Lipstick Apathy

Master_Odin posted:

SomethingAwful keeps its smilies in three different directories. This is strange to me, but it's fixed nevertheless. Hopefully they don't introduce a fourth directory in the future. e: test :cheeky: :)

http://forums.somethingawful.com/showthread.php?threadid=3391052&pagenumber=221&perpage=40#post416182042

You're still missing one then.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Of course there's another one. Thanks for pointing this out, and it's now fixed.

gradenko_2000 posted:

I'm getting this weird thing where the "user has edited this post" line keeps getting a red block next to each character:


Pastebin of my settings:
http://pastebin.com/vEeAAbfG
I can't seem to replicate this (even looking at the same post). SALR doesn't touch that line (or it shouldn't) and you don't have any of the image settings on so it not that messing with it. I'm assuming you only have SALR installed that messes with the formatting of SA?

hooah
Feb 6, 2006
WTF?
I occasionally get threads that finish loading and then display somewhere after the last-read post (i.e. in the middle of unread posts). What's the recommended combination of re-anchoring options between SALR and the forums options?

crestfallen
Aug 2, 2009

Hi.
The forums one only.

hooah
Feb 6, 2006
WTF?

crestfallen posted:

The forums one only.

Ha, just looked through the SALR ones and there are no re-anchoring options. That's what I get for not checking things out first. So my issue is just with the forums themselves, then?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Yup, I removed the SALR setting as the forum had a setting that could handle it now. No need for redundant settings and the like (like why there's only one Quote/Edit protection setting instead of two!).

Anyway, I'll be pushing 2.0.4 out tomorrow morning when I'm back on my work computer that fixes the smiley bug with ImagesToLink. And then be gone for two weeks. Hopefully there are no bugs. Then back to work on the imgur thing not working because gotta get that back!

kri kri
Jul 18, 2007

Any word on when usernote syncing will make it in?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

kri kri posted:

Any word on when usernote syncing will make it in?
In a potential two weeks? My initial testing failed and I don't have the time to troubleshoot it further than "it should work and the API is really unhelpful! :argh:" stage, so once I get back, I'll work on it again and test it and what have you. Unfortunately, to test this feature I kind of need two computers and I'm packing one up for moving in 20 minutes so it has to wait! v:shobon:v

The basic framework for the feature is done, just need to look at the sync() feature of chrome a bit more to find the exact details it needs to properly work. Which is unfortunately sort of hard when if the feature "fails", it acts like LocalStorage (ie. the current method of how things are done sorta) so I have no idea if it's failing the sync or not on my dev computer unfortunately. It's...annoying.

Master_Odin fucked around with this message at 04:39 on Aug 1, 2013

gradenko_2000
Oct 5, 2010

HELL SERPENT
Lipstick Apathy

Master_Odin posted:

I can't seem to replicate this (even looking at the same post). SALR doesn't touch that line (or it shouldn't) and you don't have any of the image settings on so it not that messing with it. I'm assuming you only have SALR installed that messes with the formatting of SA?

Yes, it's just SALR that's doing this: Deactivating it completely returns it to normal.

To be honest, I don't really know what triggered it - I've been using SALR for months now without a hitch, and then I decided to turn off Quick Reply and use the standard forums post interface, and that cropped up despite being completely unrelated.

EDIT Aug 5: For whatever reason, it's fixed now.

gradenko_2000 fucked around with this message at 11:02 on Aug 5, 2013

ClassActionFursuit
Mar 15, 2006

I don't think this is SALR-related but I thought I'd ask: Whenever I make a post then return to the thread listing (usually by using the Up gesture so that it reloads the forum) the forums show one new post in the thread I just posted in--mine. Refreshing the page makes the unread posts read zero again.

Has there been a change on the forums causing this or is this SALR? It doesn't seem to happen in Awful.apk but maybe that doesn't mean anything.

Edit: And now I just made this post and it didn't do it. I swear it's happening constantly in everything else I'm posting in. :(

Nondescript Van
May 2, 2007

Gats N Party Hats :toot:
This may be dumb and already asked but I didn't see the answer: Does SALR have a nightmode?

ClassActionFursuit
Mar 15, 2006

Nondescript Van posted:

This may be dumb and already asked but I didn't see the answer: Does SALR have a nightmode?
Only for YOSPOS. :v:

e: Jesus Christ, Swype...

ClassActionFursuit fucked around with this message at 10:07 on Aug 9, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Nondescript Van posted:

This may be dumb and already asked but I didn't see the answer: Does SALR have a nightmode?
No?

Lastinline, I'll look into it once I'm on a real computer again. I'm guessing the reload bug is gone?

ClassActionFursuit
Mar 15, 2006

Nope, it's happened every time I've posted today.

e: gently caress! Except this time. I don't know why but it isn't happening in this thread. The 3 Android threads in IYG it happens every time.

e2: Just tried YOSPOS and it didn't do it there either. Tried in IYG and it did it there though.

I have restarted Chrome recently so I don't think it has to do with just the tab/instance.

e3: I don't think this is SALR's problem, it's a forum issue. I just disabled the extension and used the breadcrumb to go back to IYG after making a post and the thread showed one unread post. :(

ClassActionFursuit fucked around with this message at 14:04 on Aug 9, 2013

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

I'm guessing the reload bug is gone?
Oh you were asking about the old reload bug. :doh: Yes, that you fixed. :)

Shitty Treat
Feb 21, 2012

Stoopid?

gradenko_2000 posted:

I'm getting this weird thing where the "user has edited this post" line keeps getting a red block next to each character:


Pastebin of my settings:
http://pastebin.com/vEeAAbfG

Im getting this also

My settings http://pastebin.com/PA6r7zuC

Have tried disabling all other addons except salr and it still persists

It even puts 3 little squares on posts that havent been edited.

Shitty Treat
Feb 21, 2012

Stoopid?

lovely Treat posted:

Im getting this also

My settings http://pastebin.com/PA6r7zuC

Have tried disabling all other addons except salr and it still persists

It even puts 3 little squares on posts that havent been edited.

Found out what was causing this

quote:

Enable highlighting of your username

Disabled that and it no longer happens.

ClassActionFursuit
Mar 15, 2006

lovely Treat posted:

Found out what was causing this


Disabled that and it no longer happens.
That's weird because I have three little squares on my edits but nowhere else:



e: vvv Huh, other people's edits only get one square. Cute.

ClassActionFursuit fucked around with this message at 17:54 on Aug 16, 2013

wormil
Sep 12, 2002

Hulk will smoke you!
If you have Bookmark threads I post/reply in by default checked "yes" under forum options and Parse URLs checked in SALR, it unchecks/doesn't parse URLs. Setting the former to "no" fixes things.

Edit: Also Convert Youtube links to inline player does nothing but highlight the links in pink.

wormil fucked around with this message at 17:11 on Aug 16, 2013

kri kri
Jul 18, 2007

Any word on when user notes syncing will make it? I need it for football (soccer) season!

Mak0rz
Aug 2, 2008

😎🐗🚬

Are feature requests/queries allowed? I was thinking it would be neat to add functionality to colored bookmark stars. The option to arrange threads by star color might be pretty useful.

I was also thinking of replacing the "Ignore bookmarks with a:" drop-down list with a series of checkboxes, but I see you've already taken care of that recently. Keep up the good work, Odin :tipshat:

Aatrek
Jul 19, 2004

by Fistgrrl
FYI, the current version of SALR kills the "Edit" button for mods (meaning I can't edit thread titles or tags). I've confirmed that I'm not the only mod affected.

I just get an un-clickable button that just give me this on mouseover:
code:
javascript:void(0);


100 HOGS AGREE
Oct 13, 2007
Grimey Drawer
The SALR dev's true intentions suddenly come to light.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

100 HOGS AGREE posted:

The SALR dev's true intentions suddenly come to light.
Yeah, make the mods life as hard as possible.

Sorry that these last stuff haven't been worked on. Between vacation, moving, and then starting grad school, I'm a bit swamped for time. I'll try and get some work in this weekend to fix some legacy stuff and get myself a bit more geared towards adding setting syncing.

Aatrek posted:

FYI, the current version of SALR kills the "Edit" button for mods (meaning I can't edit thread titles or tags). I've confirmed that I'm not the only mod affected.

I just get an un-clickable button that just give me this on mouseover:
code:
javascript:void(0);



This is an interesting bug. Are you using the Quick Reply window or not? This is for every post in a thread, or just the first one? Does it happen if you try and edit your own post?

Can you open the Chrome Developer Console (Menu -> Tools -> Javascript Console) and tell me if anything appears when you hit that button? It might be that the code is failing to return a value from the editpost page that it calls for some reason, and thus causes the quick edit box to fail. Not 100% sure and I'll see what I can do to narrow this down.

Note: You see that mouseover because SALR replaces the default behavior (the link to somethingawful.com/editpost.php? or whatever) so that you don't leave the page and the trigger from SALR fires properly. Something about it is either a) crashing or b) you may not even be hitting the trigger. Not 100% sure what case is happening.

The last thing I'd ask for is that can you post a link that you get when editing other people's posts with SALR Quick Reply off. As well as get the HTML that surrounds a broken edit button. The only change I did recently was changing how the trigger was registered, and that was just making it the same wording as the reply button, which seems to work fine I'm guessing?

e: Wait, where the hell is this edit button? Is this at the bottom of the page? Yeah, it might be breaking SALR because it might have some unique sort of context that SALR really shouldn't be touching. IE. Since it's not attached to a specific post, SALR doesn't properly associate it with an ID, and so when it calls the editpost.php page, it presumably crashes. Yeah, I definitely need the HTML around that to see if I can make it so that SALR ignores that particular button from using Quick Reply. I had no idea that even existed, which may explain why my change to the edit button logic broke that perhaps. :blush:

Master_Odin fucked around with this message at 01:50 on Sep 6, 2013

Aatrek
Jul 19, 2004

by Fistgrrl
These buttons are at the top of each thread (next to where everybody else sees just "Post" and "Reply"); they're the mod-only thread control buttons - nothing to do with individual posts.

They all work fine, save for "Edit" - nothing at all happens when I click on the button, it's like clicking on an image.

Additionally - and I just kind of figured this out - the QR window is pretty flakey, in that it only works in threads open in forums I don't mod (that is, all non-TVIV threads).



Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Can you get me the HTML code for both buttons where they don't work? I'm guessing that since you're a mod, you're obviously getting HTML code on them that I don't see. I'm also guessing on that at least for the edit button, we want to bypass the Quick Edit window and go straight to the "full" editor.

To get the HTML:
1. Right click on page and hit "View Source"
2. Search and find "http://fi.somethingawful.com/images/sa-edit.gif"
3. Copy and paste all the surrounding html around it
Basically, you should copy and paste something like:
code:
<li><a href="editpost.php?action=editpost&amp;postid=417867250"><img src="http://fi.somethingawful.com/images/sa-edit.gif" alt="Edit" title=""></a></li>
Try and do this for both buttons that don't work. The reply button is "http://fi.somethingawful.com/images/forum-reply.gif" If you can get that for me, I'll see what the differences are and hopefully come up with a better working QR box for it.

Aatrek
Jul 19, 2004

by Fistgrrl
There should be no QR box for that, it needs to take me to its edit page.

I'm out-of-town until next weekend, I'll PM you the code when I get home.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Aatrek posted:

There should be no QR box for that, it needs to take me to its edit page.

I'm out-of-town until next weekend, I'll PM you the code when I get home.
Yeah, I know. That's the point. Right now, SALR now gets all edit buttons, and replaces it with a trigger to launch the quick-reply box. It then follows this flow:
1. Grab html for the post that contains the edit button
2. get the id of the post out of that html
3. look up editpost.php?id=# where # is the post id, and then return that to the quick edit box

Now, that edit button is outside a post because it has to do with the topic. This means that on step 1, it crashes because it can't find that html it needs. I need to make a better (more restrictive) filter on which edit button behaviors to override.

Now, I'm sorta guessing perhaps a similar thing might be happening when you hit reply for forums where it fails. The filter tries to grab information that isn't there because you're a mod for those forums, thus causing a crash on QR and you just see the QR box being finnicky.


Note: I really just need the HTML. The above way to find the proper one is just to make my life easier. If you're unsure, just copy and paste the entire page source and send it to in PM (posting the code in pastebin.com or something). I need it for the pages where the QR doesn't work, or the edit button doesn't work. The reply button just doesn't work in forums (such as TVIV) where you're mod right? Does the quote button still work?

ClassActionFursuit
Mar 15, 2006

I have a button on the far left under the user avatars that mark a thread as read up to the post. My wife does not. I don't see an option for this in the SALR settings. Is this an SALR thing? I assume it is because it's ugly in YOSPOS and if it were a standard forum thing it would be an R or something there.

unpronounceable
Apr 4, 2010

You mean we still have another game to go through?!
Fallen Rib

LastInLine posted:

I have a button on the far left under the user avatars that mark a thread as read up to the post. My wife does not. I don't see an option for this in the SALR settings. Is this an SALR thing? I assume it is because it's ugly in YOSPOS and if it were a standard forum thing it would be an R or something there.

User Control Panel -> Edit Options -> Show an icon next to each post indicating if it has been seen or not

ClassActionFursuit
Mar 15, 2006

unpronounceable posted:

User Control Panel -> Edit Options -> Show an icon next to each post indicating if it has been seen or not
Thanks, didn't even think of it maybe being a forums feature. :doh:

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

wormil posted:

If you have Bookmark threads I post/reply in by default checked "yes" under forum options and Parse URLs checked in SALR, it unchecks/doesn't parse URLs. Setting the former to "no" fixes things.
Weird. I'll look into thsi.

quote:

Edit: Also Convert Youtube links to inline player does nothing but highlight the links in pink.
Uh, looks and works fine for me?


LastInLine posted:

That's weird because I have three little squares on my edits but nowhere else:

e: vvv Huh, other people's edits only get one square. Cute.
You get three squares because a square gets added for every new <span> that gets added to that line. Inserting the name colored adds two new <span> elements, hence why you get three squares.

I still haven't been able to replicate the repeating squares though. If someone gets this, if you could right click on that line, and hit "Inspect Element", and then screenshot the line highlighted and about 5 lines above/below it, maybe that'll help me trouble shoot this.

kri kri posted:

Any word on when user notes syncing will make it? I need it for football (soccer) season!
When I stop being busy with class work? This semester has been unfortunately quite busy so far. :(

Mak0rz posted:

Are feature requests/queries allowed? I was thinking it would be neat to add functionality to colored bookmark stars. The option to arrange threads by star color might be pretty useful.
Something to consider for hte future!



Small update for 2.0.5:

Changelog posted:

### v2.0.5 (9/25/2013)

* (Mod) Fixed topic edit button not working
* Fixed hotkey-manager from printing out any non-hotkey keycode when it's active.
* Improved remembering the status of the "alt" key for mouse gestures better. It should remember the state properly across tabs.
Only really bullet three is important for users and seeing how annoying it's been for me, I'm sure some other user will appreciate it.

What it means is that if you hit alt to turn off mouse gestures in one tab, then move to a different tab that was already open, the mouse gestures will still be disabled. Woo!

Master_Odin fucked around with this message at 06:31 on Sep 26, 2013

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Alright, so I've got User Note sync working and I'm going to roll it out soon as a test before I add it to topic notes (as the code should be largely the same, but want to catch things before I have to look at multiple places).

So, the way it works is that it syncs the setting to your chrome account and then the extension grabs it. You may see some slight delay in the user notes showing up, but that's an unfortunate side effect of how I'm forced to grab the data from chrome. If you have different notes saved on users on different computers, the notes will be combined with a "/" between them. I'm just now looking at a better way to allow for picking colors for the note (a hex type thing like in the settings as right now it's a bit of a pain to do it). Expect it Monday I guess?

I'm thinking that only syncing user/topic notes is best as the rest of the details might want to be changed based on platform (I wouldn't use Mouse Gestures on my laptop for example, but will on my desktop), as since SALR is largely not coded to utilize it so getting all the async hooks in would be potentially a pain.



test on vvv:
I'm not exactly sure what you're trying to say, lASTinLINE brought up something that's completely untrue with regards to android phones with respect to iphones, i was simply responding to it, it's not like i brought it up out of the blue:

http://forums.somethingawful.com/showthread.php?threadid=3520575&pagenumber=418&perpage=40#post420237764

I'd like to see a comparison with the iphone 5s though, supposedly it has larger pixels as well, but still doesn't have OIS.

Master_Odin fucked around with this message at 20:35 on Oct 7, 2013

ClassActionFursuit
Mar 15, 2006

Case insensitivity being checked didn't work for me on this post.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

LastInLine posted:

Case insensitivity being checked didn't work for me on this post.
Fixed.

New version:

Changelog posted:

### v2.0.6 (10/7/2013)

* User Note Sync added (User Notes are now synced between computers using chrome sync)
* Increased speed of friend highlighting
* Modified how Case Insensitive handles usernames.

Let me know if the new user notes stuff blows up. I post an update to restore old functionality pretty easily and re-use the local user notes.

Master_Odin fucked around with this message at 02:32 on Oct 8, 2013

Rohaq
Aug 11, 2006
Err, SALR seems to have stopped working for me. It unloaded itself, so I reloaded it, but it's not applying to anything on the forum pages.

EDIT:- And of course, as soon as I posted, it started working again. Bizarre.

Adbot
ADBOT LOVES YOU

kri kri
Jul 18, 2007

Do I need to do anything to start user notes syncing or should it just happen?

  • Locked thread