Blinkz0rz posted:

The floating page navigator just disappeared today even though the box in settings is still checked. Can anyone else replicate?

Here's a pic:

C-BOX posted:

It also disappeared for me yesterday, although I had assumed it was something to do with my netbook.

JingleBells posted:

It's vanished here too - the latest update has added some fancy CSS property which moves it below the visible part of your browser - I've sent a pull request to Master Odin with a fix.

TheBandOffice posted:

Nav is back and no longer flickering. Thanks!

madpanda posted:

Still only seeing navigator at the thread/forum browsing level, as soon as I go to a thread its replaced by the default page navigator that doesn't even have the +/- last 3. It's visible for a second while the thread is loading and is then replaced.

<snip>

Pleads posted:

What's the actual setting supposed to be on:

Image Resizing
-Restrict Size of Images

Because it does not appear to be working for me. I get linked images converted to images and turned into table-breaking behemoths (and then of course quoted 18 times on a page)

Master_Odin posted:

It restricts it to a max of 800px width. I can allow a setting to change this number to be whatever you want technically pretty easily if that's what you're asking for (and just have it default at 800px).

LastInLine posted:

That would be awesome since for a Mavericks-specific reason I'm having issues with oversized images.

Schizophrenic Orb posted:

This is a forums bug, but it can be easily fixed with SALR probably.

When someone posts an image from imgur, if the image url ends with certain letters (I believe s, l, and m at least, there might be others), the forums remove the last letter, breaking the image url. It creates a timg (which points to the correct url) and the timg is also a link to the image (with a now incorrect url). When SALR automatically expands timg'd images, it points to the broken url instead of the correct timg url.

An example is here.

Is it possible to make it so SALR notices the discrepancy between the timg and the url, and display the correct, non-broken image?

syscall girl posted:

They haven't worked for me in a long time. I can see the old ones I made but I can't alter them or make new ones.

Megaspel posted:

Do user notes work for anyone else? If so, how can I clean my SALR data, in hopes that it'll fix user notes?

Flagrama posted:

They are working fine for me.

Chrome: Version 32.0.1700.72 beta-m
SALR: 2.0.10.1

Changelog posted:

### v2.1.0 (1/14/2013)

+ Reintroduced broken indicator for threads posted in. (This colors the post count of threads posted in yellow. This only applies to new posts in on-going threads and not just being the OP of a thread (as there's no way to test that))
+ Allowed users to specify maximum dimensions when restricting image size
* Fixed right "Top" button not being on any page, not just when page navigator was visible.
* Fix imgur links to larger sizes of imgur images posted on the forums being broken
+ Add setting to remove report button on own posts

LastInLine posted:

I've been trying out the resize images option just to see if it would solve my problem (it does) but I've found that it doesn't always work. Mainly in the YOSPOS pics thread where there are a lot of oversized pictures I find that there will be some oversized pictures long after the thread has finished loading. Going back (which happens any time I have to scroll the screen over to see the entire the image then back to full left) and then returning to the page finds the image resized properly.

It seems to be fairly inconsistent as to whether the images are resized or not but always returning to the page results in all images resized.

Perhaps the image size check is being run and completed before all images on an image-heavy thread are fully loaded so they get skipped?

I'm willing to give any debugging data that might help.

Master_Odin posted:

Thread link?

And it's very possible what you said is the cause of it. I mainly tested the feature against pages with a couple pictures so I'm not sure what happens when you throw a bunch of pictures up against it.

LastInLine posted:

Here you go.

One image I know it happened on was the one of Sonic on page 361.

Changelog posted:

### v2.1.0 (3/11/2014)
+ Allow for use of localStorage (instead of Chrome.storage.sync) for User Notes
+ Reintroduced indicator for threads posted in
+ Allowed users to specify maximum dimensions when restricting image size
+ Add setting to remove report button on own posts
+ Add image tooltip popup for filename (credit to nskillen)
* Fixed right "Top" button not being on any page, not just when page navigator was visible.
* Fix imgur links to larger sizes of imgur images posted on the forums being broken
* Force image settings to only start acting once entire window is loaded, instead of potentially only some of the window

Master_Odin posted:

2.1.0 release. Several new features. Ability to go local with user notes (how it was previously done) for people that have issues with it. You can check what user notes are on sync and what are local by going to the bottom of the settings dump. Currently going from sync to local (or vice versa) completely overrides all notes for local (and sync resp.).

Teddybear posted:

The highlighting will only work on threads you post in going forward, right? Or at least, that's how it's lookin' now.

ewe2 posted:

Quick reply seems to have been disabled despite enabling it in SALR, don't quite understand how. Unchecking/rechecking it doesn't work either.

Master_Odin posted:

2.1.0 release. Several new features. Ability to go local with user notes (how it was previously done) for people that have issues with it. You can check what user notes are on sync and what are local by going to the bottom of the settings dump. Currently going from sync to local (or vice versa) completely overrides all notes for local (and sync resp.).

ewe2 posted:

syscall girl posted:

Thank you. I switched to local and I can make new notes now. Also shows my old ones. I dunno what's borked with my sync but thanks.

Master_Odin posted:

So couple questions:
1) have you used user notes in the past or did you just turn on the option?
2) This error remains as you navigate around the forums?

Basically, the issue is that "userNotesLocal" is set to a value of null, but for whatever reason, that isn't tripping the default values you should get. This means you try and pull a value from null and get an error and whatever comes next doesn't work (like Quick Reply). Need to fix whatever is wrong with your user notes before would be able to get Quick Reply to work. Posted a new build to chrome store that will at least print a couple more things into console for me to see. Once you see you have v2.1.0.1, post what it says in console for me please.

Yeah, I have no idea why sync wasn't working but I guess this is best of both worlds.

hooah posted:

Since the update, pages with pictures aren't re-anchoring properly after the pictures load.

ewe2 posted:

1) Yes, I just toggled the option in case i wanted it. Basically to avoid any use of chrome sync because it's broken in current chrome builds.

2) Yes, the issue was across the forums.

The good news is that you seem to have fixed it, quick reply is going again. Thanks for the speedy response! Here's the console output:

code:

null salr.js:1597
used default notes salr.js:1611
Object
50339: Object
101547: Object
115838: Object
143511: Object
156041: Object
163390: Object
3882420: Object
__proto__: Object  salr.js:1616
what salr.js:1672

Also, the the thread notes bar at lower left is working and pops up a notes dialogue, so that's working too.

quote:

{"50339":{"text":"SALR Developer","color":"#9933FF"},"101547":{"text":"SALR Developer","color":"#9933FF"},"115838":{"text":"SALR Developer","color":"#9933FF"},"143511":{"text":"SALR Developer","color":"#9933FF"},"156041":{"text":"SALR Developer","color":"#9933FF"},"163390":{"text":"SALR Developer","color":"#9933FF"},"3882420":{"text":"SALR Developer","color":"#9933FF"}} salr.js:1597
used saved notes salr.js:1614
Object
salr.js:1616
Error in event handler for (unknown): Cannot read property 'href' of undefined
Stack trace: TypeError: Cannot read property 'href' of undefined
at HTMLTableElement.<anonymous> (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1625:77)
at Function.x.extend.each (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/jquery/jquery.js:4:5347)
at x.fn.x.each (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/jquery/jquery.js:4:1999)
at SALR.displayUserNotes (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1624:26)
at SALR.displayUserNotesLocal (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1588:10)
at SALR.displayUserNotesHandler (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1535:14)
at SALR.pageInit (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:129:22)
at new SALR (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:37:10)
at chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/background.js:42:23
at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) showthread.php?noseen=0&threadid=3611893&perpage=40&pagenumber=36:1

Master_Odin posted:

Do you have a good example of this? It presumably relates to how I fixed an earlier issue where not all images would be affected by certain SALR settings if the page had a ton of images, but I never noticed it not being re-anchored properly.