|
PFlats posted:Maybe add some sort of settings popover button on the far right side of the extra keyboard row? Kinda like how the Formatting Options works in-thread right now. Hadn't thought of that one before, I'll try that out. TheMightyHandful posted:The clickable area to go to the next page seems to be to the outside of the location of the button: I need to press to the right of the next page button on my 4s The one in the toolbar at the bottom? Weird, I'll take a look.
|
#
?
Mar 21, 2014 12:04
|
|
|
|
| # ? Jun 6, 2024 14:03 |
|
|
This update is great. The new menus make everything feel way more cohesive.
|
|
#
?
Mar 21, 2014 12:51
|
|
|
Sometimes the Send PM option doesn't appear until you view someone's profile. Happened to me with poster I Feast On Dogshit on the bottom of the last page. e:happens with PUGGERNAUT too. baram. fucked around with this message at 15:58 on Mar 21, 2014 |
|
#
?
Mar 21, 2014 15:54
|
|
|
Baram posted:Sometimes the Send PM option doesn't appear until you view someone's profile. Happened to me with poster I Feast On Dogshit on the bottom of the last page. I don't have PMs so it could be that
|
|
#
?
Mar 21, 2014 15:59
|
|
|
I Feast On Dogshit posted:I don't have PMs so it could be that This is what I was thinking but making it appear allowed it to proceed to the compose screen so I wasn't sure. e: sending a PM that way it shows the Sending spinner then just goes back to the menu. < just tested and this is how it works for Platinum users too. Can you add a confirmation when they send since I don't see a way to view sent PMs? baram. fucked around with this message at 16:11 on Mar 21, 2014 |
|
#
?
Mar 21, 2014 16:00
|
|
|
I Feast On Dogshit posted:I don't have PMs so it could be that Same here
|
|
#
?
Mar 21, 2014 16:09
|
|
|
TheMightyHandful posted:The clickable area to go to the next page seems to be to the outside of the location of the button: I need to press to the right of the next page button on my 4s Yeah, I think moving it farther from the page selector would be good anyway. It makes for a fiddly target, and it could be both bigger and more distinct if it moved over into some of that unused whiteboard. Related, the new page selector is much better, thank you pokey!
|
|
#
?
Mar 21, 2014 16:49
|
|
|
Baram posted:This is what I was thinking but making it appear allowed it to proceed to the compose screen so I wasn't sure. Maybe I hosed up "can receive a PM" detection when scraping profiles. I'll take a look. For the record, "Send PM" should only appears an option when the person can actually receive PMs. And Awful could do a better job (i.e. make any attempt whatsoever) telling you about an error when sending.
|
|
#
?
Mar 21, 2014 18:05
|
|
|
Please make it so that style sheet options aren't saved in ram, like before. It's annoying to have to keep setting it 
|
|
#
?
Mar 21, 2014 21:18
|
|
|
Opening a thread with 0 unread posts, going back a page, and then going back to the thread list will make it display a positive number of unread posts.
|
|
#
?
Mar 21, 2014 22:14
|
|
|
Here's the Full Resoultion Originals of the new Fyad thread tags ( and  ) so that you can make them into squares or whatever for your app.  
|
|
#
?
Mar 22, 2014 00:22
|
|
|
LUBE UP YOUR BUTT posted:Please make it so that style sheet options aren't saved in ram, like before. It's annoying to have to keep setting it I swear they're saved somewhere more persistent than RAM. Whatever is causing this issue, it's on the list I assure you  Caithness posted:Opening a thread with 0 unread posts, going back a page, and then going back to the thread list will make it display a positive number of unread posts. D'oh! I'll throw that on the list too.
|
|
#
?
Mar 22, 2014 02:52
|
|
|
Minor bug: entering a thread with a 2-line title in portrait orientation, shifting to landscape, and then back to portrait does not re-establish text wrapping, so the title stays on one line with an ellipsis as long as one stays in that thread. Happens in reply view, too.
|
|
#
?
Mar 23, 2014 05:00
|
|
|
The UFC March thread crashes the app for me everything I open it. I think it's something to do with the first page? Because I marked as unread by mistake as when I went back into it on page 1 it just constantly crashes to springboard http://forums.somethingawful.com/showthread.php?threadid=3612469 I imagine it might be something on the actual page of the thread than the app, because I've never had that problem with any other thread
|
|
#
?
Mar 23, 2014 12:40
|
|
|
I Feast On Dogshit posted:http://forums.somethingawful.com/showthread.php?threadid=3612469 What version of the app/iOS are you on? I just tried it in the latest dev build and it opens fine for me..
|
|
#
?
Mar 23, 2014 15:37
|
|
|
Froist posted:What version of the app/iOS are you on? I just tried it in the latest dev build and it opens fine for me.. Latest version of the app and ios7.1. iPhone 5.
|
|
#
?
Mar 23, 2014 15:48
|
|
|
Banzai 3 posted:Minor bug: entering a thread with a 2-line title in portrait orientation, shifting to landscape, and then back to portrait does not re-establish text wrapping, so the title stays on one line with an ellipsis as long as one stays in that thread. Happens in reply view, too. An oldie but a goodie! I'll take another stab at this, it's been awhile. I Feast On Dogshit posted:The UFC March thread crashes the app for me everything I open it. Just reproduced this, and the crash log is absolutely nonsensical, so this'll take a bit of pondering on my end.
|
|
#
?
Mar 23, 2014 17:16
|
|
|
A couple minor visual issues with the popover in the iPad view: I think the arrow is backwards  And when it fades out it has a weird appearance  Both of these persist after closing and reopening the app, and on both the normal and YOSPOS stylesheets. Also, it seems to have produced a crash on launch bug on this device now. I can post the crash report if you want it, but I'm not sure what triggered it or how to get around it short of reinstalling the app.
|
|
#
?
Mar 23, 2014 18:35
|
|
|
carry on then posted:A couple minor visual issues with the popover in the iPad view Surprised that arrow hadn't come up already. But the crash is new to me. I'll take a crash report for sure.
|
|
#
?
Mar 23, 2014 20:26
|
|
|
Subjunctive posted:When I was editing this post, the — dashes in the quoted section didn't render, just had two spaces in a row. Figured this one out. Check out the primo JSON response when quoting that post. The important bit: wtf posted:the metric that actually matters to program performance \u0097 the number of simultaneously usable registers \u0097 still more than doubles Yeah, I don't think that's the right way to escape an em dash. Good try though, thanks Forums! edit: confused length of dash pokeyman fucked around with this message at 05:43 on Mar 26, 2014 |
|
#
?
Mar 26, 2014 04:52
|
|
|
pokeyman posted:Figured this one out. Check out the primo JSON response when quoting that post. The important bit: JSON and Unicode, together again. We've gotta stop meeting like this.
|
|
#
?
Mar 26, 2014 05:10
|
|
|
Subjunctive posted:JSON and Unicode, together again. We've gotta stop meeting like this. Yeah I thought you might like that.
|
|
#
?
Mar 26, 2014 05:44
|
|
|
Just ran into a very strange bug. I had the app open to one of the pages in the Dark Souls 2 thread, then I thought I tapped the arrow to go back to the Games forum. But instead it acted like I tapped the Post a Reply button. The real problem, though, was I could not get out of the screen. Tapping Cancel did nothing, no other gestures did anything. It did let me make a post (confirmed by checking from a different computer), but then it just cleared the text from the Post a Reply screen and I was still stuck there. Force-quitting the app and powering off/on the iPhone didn't help, I had to delete and reinstall the app for it to start working again. As tempted as I am to blame  for this, figured I should see if you guys know what happened first? This is on an iPhone 5 with the latest Awful version.
|
|
#
?
Mar 26, 2014 17:42
|
|
|
Mason Dixon posted:Just ran into a very strange bug. I had the app open to one of the pages in the Dark Souls 2 thread, then I thought I tapped the arrow to go back to the Games forum. But instead it acted like I tapped the Post a Reply button. The real problem, though, was I could not get out of the screen. Tapping Cancel did nothing, no other gestures did anything. It did let me make a post (confirmed by checking from a different computer), but then it just cleared the text from the Post a Reply screen and I was still stuck there. Force-quitting the app and powering off/on the iPhone didn't help, I had to delete and reinstall the app for it to start working again. As tempted as I am to blame That is indeed a very strange bug. Was it an empty reply that appeared, or was there a quoted post in there? I think I can make the cancel button work at any rate.
|
|
#
?
Mar 27, 2014 21:33
|
|
|
pokeyman posted:That is indeed a very strange bug. Was it an empty reply that appeared, or was there a quoted post in there? It was an empty reply, nothing quoted.
|
|
#
?
Mar 28, 2014 19:18
|
|
|
I had that happen today too, for what it's worth. Reinstalling it worked for me too though.
|
|
#
?
Mar 29, 2014 01:32
|
|
|
Mason Dixon posted:It was an empty reply, nothing quoted. Good to know. It's on the list!
|
|
#
?
Mar 29, 2014 02:55
|
|
|
I decided I wanted to learn ObjectiveC, so I hacked up a little thing in Awful today. I added another button to the KeyboardBar labelled "[/..]" that inserts the closing tag for the most recently opened bbcode thing. I have some more to do on it (*), but I though I'd ask if it was something you'd be interested in. If so, I'll submit a pull request when I have it finished up, and you can have some fodder for the coding horrors thread. (*) handle [foo=whatever] form, disable when there's nothing open, label the button with the text that'll be inserted, maybe figure out how to add some tests.
|
|
#
?
Mar 29, 2014 22:01
|
|
|
That sounds awesome.
|
|
#
?
Mar 29, 2014 22:37
|
|
|
Subjunctive posted:I decided I wanted to learn ObjectiveC, so I hacked up a little thing in Awful today. I added another button to the KeyboardBar labelled "[/..]" that inserts the closing tag for the most recently opened bbcode thing. I have some more to do on it (*), but I though I'd ask if it was something you'd be interested in. If so, I'll submit a pull request when I have it finished up, and you can have some fodder for the coding horrors thread. Sounds awesome! I'm in. Another item for your list: do the right thing within an open [code] tag, whatever that is. e.g. assuming you've typed up to the caret: code:
|
|
#
?
Mar 29, 2014 23:46
|
|
|
pokeyman posted:Sounds awesome! I'm in. Thanks, that's great!  Edit: I think the right thing is probably to be maximally consistent, and close the [b] there. When I get the label changing to match the text it'll be clearer, but I think that case is rare enough that it's not worth making for more magic. How do you like to do unit tests? Subjunctive fucked around with this message at 00:06 on Mar 30, 2014 |
|
#
?
Mar 30, 2014 00:03
|
|
|
Subjunctive posted:Thanks, that's great! My point, poorly made, with the example was that I suspected the Forums wouldn't consider the opening [b] as actual BBcode because it was in the [code] block, and so the correct closing tag to insert would be [/code]. Though I'm not sure I care about such an edge case. I think the label text should probably stay static so that the buttons don't move around as it grows and shrinks. Conveniently, that's less effort too! There are some unit tests already, for scraping HTML, if you'd like an example. I haven't bothered with or gotten around to testing anything else. (Some of that is laziness, most of it is the questionable value.) I'd love some tests for inserting a closing BBcode tag but they're certainly not required.
|
|
#
?
Mar 31, 2014 00:47
|
|
|
OK, I'll write up something on a testing method in AwfulKeyboardBar, and I can poke at it from the debugger if it changes. You're right about the [code] case, of course. I can detect that easily enough. I also have to fix a dumb bug where it'll match the previous [tag] even if there's already a [/tag] in place. Happily that's similar logic to the open-[code] test. Keeping the buttons in place makes sense. I was thinking of right-aligning it in landscape, and if in a [list] adding a button for [*], but I'm not sure it's worth the extra work. I probably will try to make it disable when there's nothing open, if only because I want to learn more about the event handling model. I sent a pull request, but obviously there's more to do. Feel free to bounce it sight unseen, though if you see problems or have style nits (100 cols? line-wrap indentation? variable names? whitespace?) I'm more than happy for the feedback. It's literally the only ObjC I've ever written, so I am prepared to start over entirely. I come from a programming culture where there are rules about local variable declaration order, so you won't hurt my feelings.  Edit: at some point I also broke handling of [outer][inner][/inner], in that it'll insert another [/inner] instead of the proper [/outer]. I should probably set that pull request on fire. Subjunctive fucked around with this message at 01:28 on Mar 31, 2014 |
|
#
?
Mar 31, 2014 01:18
|
|
|
Subjunctive posted:I should probably set that pull request on fire. Emptyquote if you've ever felt like this.
|
|
#
?
Mar 31, 2014 06:47
|
|
|
New pull request up. Correctly handles:code:
|
|
#
?
Mar 31, 2014 08:12
|
|
|
Subjunctive posted:New pull request up. Looks good! You're probably right about just whitelisting BBcode tag names. That list never seems to change, and it'd avoid false positives like [sic]. Oh and regarding cosmetic code concerns, Awful's kind of all over the place there. I reformat files as I wander by to suit whatever style I'm into that day, but I'm nowhere near committed enough to enforce it on anyone else. Do what feels right, and if you notice something changed then I guess someone preferred it some other way  For the next steps (enabling/disabling the button and updating the label) you'll want to look into the UITextViewTextDidChangeNotification.
|
|
#
?
Mar 31, 2014 23:56
|
|
|
pokeyman posted:For the next steps (enabling/disabling the button and updating the label) you'll want to look into the UITextViewTextDidChangeNotification. I think we agreed to not update the label (though it'd be easy enough to just call getCurrentlyOpenTag), but I'll look at updating the enabled/disabled state tonight.
|
|
#
?
Apr 1, 2014 00:15
|
|
|
q != e
Subjunctive fucked around with this message at 00:19 on Apr 1, 2014 |
|
#
?
Apr 1, 2014 00:15
|
|
|
Subjunctive posted:I think we agreed to not update the label (though it'd be easy enough to just call getCurrentlyOpenTag), but I'll look at updating the enabled/disabled state tonight. Oh ok, wasn't sure where we came out on that. Works for me. This commit has a bit more concrete feedback on style. The big one you'll see in a lot of Objective-C is lining up the colons in a selector when sending a message (e.g. here), the other stuff is not largely agreed upon and just my personal taste. edit: and BOOL is always either YES/NO, never TRUE/FALSE, that one's pretty well established. BOOL is actually pretty weird and has a sordid history but was recently fixed, so there is hope for us all.
|
|
#
?
Apr 1, 2014 00:21
|
|
|
|
| # ? Jun 6, 2024 14:03 |
|
|
I got a pretty heavy bug. I was hopping on to check out the DnD pictures thread and it was taking quite a bit to load (university's wifi is poo poo) so I hit the home button on my ipad to jump out and play a game. Some time later I got home and relaunched the app. I have the black screen with the blue header and I can see the little loading wheel spin for a few seconds. Then it disappears and I'm stuck. No menu bar, no button for the menu bar, nothing. I closed the app and rebooted my ipad, twice, and got the same result. I had to redownload the app to resolve it. I realize this isn't necessarily the best information. I had the most recent version of the app.
|
|
#
?
Apr 1, 2014 05:25
|
|
