Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Locked thread
Sogol
Apr 11, 2013

Galileo's Finger
I love this app and never use my desktop to post. Thank you.

I noticed that when you sort by "Only their posts and then hit "Last" that it does not sort by user selected, but instead gives the entire thread.

Adbot
ADBOT LOVES YOU

ziasquinn
Jan 1, 2006

Fallen Rib
Duplicate threads keep showing up in my bookmarks. They're the same thread.

Same for GBS 1.4 in my forum index. I got two of 'em.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

the yeti posted:

May have missed this being discussed but is it intentional that the "..." And username buttons seem to be disabled in the period between a page of posts initially being displayed and loading finishing up? ( "finished" = the spinner on the status bar by the LTE icon going away)

Not intentional. I'll take a look, I have an idea of what might be going on.

Sogol posted:

I noticed that when you sort by "Only their posts and then hit "Last" that it does not sort by user selected, but instead gives the entire thread.

Good catch, I'll take a look.

Your Dead Gay Son posted:

Duplicate threads keep showing up in my bookmarks. They're the same thread.

Same for GBS 1.4 in my forum index. I got two of 'em.

That sucks. I really don't do a great job uniquing threads. Forums usually work better but not today I guess. I'll take a look.

zeekner
Jul 14, 2007

pokeyman posted:



That sucks. I really don't do a great job uniquing threads. Forums usually work better but not today I guess. I'll take a look.

Is this just a coredata thing? It shouldn't be hard to make the forum/thread ID unique in a standard db.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Uncomfortable Gaze posted:

Is this just a coredata thing? It shouldn't be hard to make the forum/thread ID unique in a standard db.

You can do it with Core Data too but you can't just tell it to put a unique constraint on the SQLite column. It's a bigger issue with users, because there are contexts where you know a user's name but not their ID. Thread and forum duplication is probably just a bug on my part.

I kinda want to move off Core Data but that's a big project for another day.

edit: I also stay far away from any Core Data validation (which is usually how you'd implement uniquing) in Awful.app because I just didn't want to deal with it for something that's ultimately just a cache.

pokeyman fucked around with this message at 00:36 on Jun 6, 2014

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

It's fun to go to the iOS team and say "hey, I have a question about Core Data performance", as long as you get away before they catch you.

Is the cache something that we could just use leveldb or something simple?

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Subjunctive posted:

It's fun to go to the iOS team and say "hey, I have a question about Core Data performance", as long as you get away before they catch you.

Is the cache something that we could just use leveldb or something simple?

You know, it's not much of a performance hog in Awful (except between versions when the model changes, and when the database gets big because we don't currently prune it). It just seems like overkill for what we're doing. We might be better off with NSCoding, plists, an NSMapTable or two, and some handy notifications.

The other way to go could be to embrace Core Data completely and write an NSIncrementalStore for the Forums. Then when we want page five of a thread, we just execute a fetch request for the Post entity, predicate where thread=whatever, and set the fetch offset and limit to 160 and 40. The incremental store subclass makes the network calls on our behalf, and it manages a local cache that the rest of the app never even knows about. I'm actually considering trying it out just to see how it works.

zergstain
Dec 15, 2005

This may have been reported 10 times already, but whenever I touch a link to a post, it goes to the top of the page, so I have no idea which post is actually being referenced. I'm pretty sure this bug is new to this version, maybe the one before.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

zergstain posted:

This may have been reported 10 times already, but whenever I touch a link to a post, it goes to the top of the page, so I have no idea which post is actually being referenced. I'm pretty sure this bug is new to this version, maybe the one before.

Nope, this version, you were right the first time :)

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

How would you invalidate the cache for post editing or user-was-banned stuff? Do the forums send back useful cache control headers?

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Subjunctive posted:

How would you invalidate the cache for post editing or user-was-banned stuff? Do the forums send back useful cache control headers?

I don't really understand your question. But I think I was unclear about how Core Data is used as a cache.

New data is downloaded from the Forums, turned into managed objects, and saved in the context. Interested parties can watch a managed object or the context itself to see what changed.

Awful assumes that it could launch at any time with the Core Data store suddenly gone. So if you're still logged in but the store is gone, the "forums" screen will re-download the list of forums, and the "posts" screen will re-download that page of posts. An "editing post" screen remembers the ID of the post it was editing and will recreate a managed object for it on launch.

The problem is this cache never shrinks. If you read a page of a thread, those posts sit on your phone until the end of time (or you log out).

It'd make much more sense to do one of two things:

1. Look for any objects that haven't been modified in some amount of time (a week, a month) and delete them.
2. Delete everything when Awful quits except for those managed objects currently in use or otherwise deemed important (e.g. we'd probably never prune any cached Forum managed objects).

If that doesn't answer your question, by all means ask me again :)

edit: While we're talking about caching, once we're pruning I'd love to cache images in posts. Then we have a nearly complete offline cache, which is particularly handy for restoring state before the network connection comes alive.

pokeyman fucked around with this message at 22:27 on Jun 6, 2014

Froist
Jun 6, 2004

Subjunctive posted:

How would you invalidate the cache for post editing or user-was-banned stuff? Do the forums send back useful cache control headers?

pokeyman posted:

I don't really understand your question. But I think I was unclear about how Core Data is used as a cache.

[snip]

If that doesn't answer your question, by all means ask me again :)

I think he's asking what happens if you've previously seen a post (so Awful's cached it in CoreData), then the poster goes back and edits it or a mod probations/bans them for it - I don't think Awful would ever know to throw the cached version away?

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Froist posted:

I think he's asking what happens if you've previously seen a post (so Awful's cached it in CoreData), then the poster goes back and edits it or a mod probations/bans them for it - I don't think Awful would ever know to throw the cached version away?

Ah, that makes some more sense.

Whenever something is scraped, all relevant cached data is updated. Scraping a page of posts re-grabs each of those posts' content. You can see this in effect after editing a post: you're taken to the post, which is rendered immediately from the cache, then when the scraping is done the edited post blinks in with the changes.

This is also why the bookmarks table view updates so strangely: every attribute on those threads is being re-set on every refresh. Usually to the exact same value it held previously, but it counts as a change. I've long been meaning to do some smarter change detection there but I have yet to sit down and figure it out.

zergstain
Dec 15, 2005

Anybody know what this completely empty "Apps In Developmental States" forum that only shows up in Awful.app under QCS is? I might ask in QCS, but I can't find any trace of it when viewing the forums in Safari.

Drastic Actions
Apr 7, 2009

FUCK YOU!
GET PUMPED!
Nap Ghost

zergstain posted:

Anybody know what this completely empty "Apps In Developmental States" forum that only shows up in Awful.app under QCS is? I might ask in QCS, but I can't find any trace of it when viewing the forums in Safari.

Apps In Developmental States is for forum app developers, so we can test making new posts and threads without having to use actual visible forums. I think the permissions to actually see it are on a per-user level, so you can't actually see the (high quality) threads in it. Really, you should not see it listed at all. For me, I only allow access to it when I have a debug build, so maybe something like that happened here? I don't know how they turn it on or off :shrug:.

Diabolik900
Mar 28, 2007

A lot of times (but not always) I'll see Idiot King Huddle listed, which I don't think anyone who works on the app even has access to. My understanding of how Awful.app generates it's list of forums is that it just scrapes them from the dropdown on the bottom of this page. From what I've heard, the permissions system for hidden forums is really wonky, so my best guess is that occasionally that dropdown will just show forums that you can't access, so Awful grabs them.

zergstain
Dec 15, 2005

Drastic Actions posted:

Apps In Developmental States is for forum app developers, so we can test making new posts and threads without having to use actual visible forums. I think the permissions to actually see it are on a per-user level, so you can't actually see the (high quality) threads in it. Really, you should not see it listed at all. For me, I only allow access to it when I have a debug build, so maybe something like that happened here? I don't know how they turn it on or off :shrug:.

As in something the SA admins set up? That was nice of them.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Diabolik900 posted:

A lot of times (but not always) I'll see Idiot King Huddle listed, which I don't think anyone who works on the app even has access to. My understanding of how Awful.app generates it's list of forums is that it just scrapes them from the dropdown on the bottom of this page. From what I've heard, the permissions system for hidden forums is really wonky, so my best guess is that occasionally that dropdown will just show forums that you can't access, so Awful grabs them.

This is exactly right.

zergstain posted:

As in something the SA admins set up? That was nice of them.

I miss :choco:

Filboid Studge
Oct 1, 2010
And while they debated the matter among themselves, Conradin made himself another piece of toast.

Does page 1 of the alt-country thread in NMD crash Awful for everyone?

I have no-one on my ignore list.

Filboid Studge fucked around with this message at 19:30 on Jun 9, 2014

Sogol
Apr 11, 2013

Galileo's Finger

Filboid Studge posted:

Does page 1 of the alt-country thread in NMD crash Awful for everyone?

I have no-one on my ignore list.

What did no-one do to get put on your list?

I am occasionally getting crashes when going from bookmarked threads and frozen, non-scrolling, threads. This could be memory on my end. I have not figured out any patterns to it yet.

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

Filboid Studge posted:

Does page 1 of the alt-country thread in NMD crash Awful for everyone?

I have no-one on my ignore list.

If you mean the "More Than Johnny Cash" one, then it's fine for me (5s, 7.1.1).

Sogol
Apr 11, 2013

Galileo's Finger
I got a bunch of duplicate bookmarks today. Two of several threads suddenly showed up. Deleting one of them left the other still there, which was good.

Edit- I also had some blank bookmarks killed by null at the bottom of the list.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Sogol posted:

I got a bunch of duplicate bookmarks today. Two of several threads suddenly showed up. Deleting one of them left the other still there, which was good.

Edit- I also had some blank bookmarks killed by null at the bottom of the list.

Sounds like we got a leak somewhere! You might want to double-check in a browser that your bookmarked threads are still there, just in case Awful is really acting up.

Logging out and back in might work as a temporary fix while I figure out what's up.

Sogol
Apr 11, 2013

Galileo's Finger

pokeyman posted:

Sounds like we got a leak somewhere! You might want to double-check in a browser that your bookmarked threads are still there, just in case Awful is really acting up.

Logging out and back in might work as a temporary fix while I figure out what's up.

All good in a browser. I think I only lost one thread when I deleted a null thread.

ziasquinn
Jan 1, 2006

Fallen Rib
The new [/..] Tag is great but doesn't work for embedded youtube because it assumes the closing tag is [/video type] and not [/video]

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

Your Dead Gay Son posted:

The new [/..] Tag is great but doesn't work for embedded youtube because it assumes the closing tag is [/video type] and not [/video]

I can't believe I didn't test that. I'll try to fix that tonight, sorry.

ziasquinn
Jan 1, 2006

Fallen Rib
Lol no problemo, I just post a lot of trash youtubes in gbs and noticed it.

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

Just pushed a fix for the autoclose issue. I need to tidy up the fact that we consider [video type (sans closing ]) to be autocloseable, but it's not as big a deal.

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

Making progress on the unload-images thing. No special thanks to this ancient WebKit bug. :argh:

It would also be super-neato if the forums served up width/height info for <img> tags, but let's not be greedy.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Subjunctive posted:

It would also be super-neato if the forums served up width/height info for <img> tags, but let's not be greedy.

So bloody annoying. Makes jumping to a specific post basically impossible. (Though that annoyance is shared with the Forums proper.)

Subjunctive
Sep 12, 2006

✨sparkle and shine✨

pokeyman posted:

So bloody annoying. Makes jumping to a specific post basically impossible. (Though that annoyance is shared with the Forums proper.)

What if jump-to-post did what we do with showing most-recent-unread and had "previous posts" to press and reveal more?

Actually, how does "previous posts" avoid shuffling the current post down as things load above it? That's the behavior we want, right?

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Subjunctive posted:

What if jump-to-post did what we do with showing most-recent-unread and had "previous posts" to press and reveal more?

Actually, how does "previous posts" avoid shuffling the current post down as things load above it? That's the behavior we want, right?

I've considered doing exactly that. I don't remember if I ran into a reason to stop or if I just got distracted. It sure sounds reasonable.

"Previous posts" works by inserting the posts into the DOM then scrolling down by the change in document height. A hypothetical similar implementation for "jump to post" could use the same infrastructure.

Pseudoscorpion
Jul 26, 2011


I don't know if this is possible, but I would love it if Awful would prompt you when you try to delete a bookmark. I keep accidentially deleting some of my bookmarks when I left-swipe back to the bookmarks menu and then try to right-swipe back to the thread I was reading (which also doesn't do anything by itself - I find it weird that left-swipe does what you'd expect and right-swipe doesn't)

The Dave
Sep 9, 2003

Pushed a lot of YOSPOS changes while I can, will be interesting to see it on phone. Does list secondary text color not take though? Also, is there an error with the Quote icon color or am I messing something up?

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.

Pseudoscorpion posted:

I don't know if this is possible, but I would love it if Awful would prompt you when you try to delete a bookmark. I keep accidentially deleting some of my bookmarks when I left-swipe back to the bookmarks menu and then try to right-swipe back to the thread I was reading (which also doesn't do anything by itself - I find it weird that left-swipe does what you'd expect and right-swipe doesn't)

That's not a bad idea, it is pretty easy to delete bookmarks.

The swiping-from-right to go back to the thread is a good idea that's come up before. In my experience it's rare for an app to support that (can't think of any examples actually) but it would be nice to have.

The Dave posted:

Pushed a lot of YOSPOS changes while I can, will be interesting to see it on phone. Does list secondary text color not take though? Also, is there an error with the Quote icon color or am I messing something up?

It's not you it's me. Both issues fixed!

the yeti
Mar 29, 2008

memento disco



Trying to load the gif as quoted in this post in the internal browser seems to reliably crash awful, while following the 'X posted' link back to the original post and doing the same does not. Not sure what to make of that. Latest awful, iOS. iPhone 5.

Soricidus
Oct 21, 2010
freedom-hating statist shill

pokeyman posted:

The swiping-from-right to go back to the thread is a good idea that's come up before. In my experience it's rare for an app to support that (can't think of any examples actually)
Safari.

Diabolik900
Mar 28, 2007


That's a whole different interaction concept though. With Safari, you're browsing through your history, whereas with Awful you're moving up and down through different levels of a list. If you're going to compare it to a stock iOS app, Mail is a much more comparable app, and it doesn't have a "forward" swipe.

I don't disagree that it's a good idea, but I've never seen one that uses a forward swipe in quite the same way we're talking about.

pokeyman
Nov 26, 2006

That elephant ate my entire platoon.
^^^^
Exactly. (Down to the "good idea" part.)

the yeti posted:

Trying to load the gif as quoted in this post in the internal browser seems to reliably crash awful, while following the 'X posted' link back to the original post and doing the same does not. Not sure what to make of that. Latest awful, iOS. iPhone 5.

Works On My Machine but I'll check the crash logs. I also noticed how poorly jumping to a post actually works right now, so that's on the list too.

Adbot
ADBOT LOVES YOU

Thrifting Day!
Nov 25, 2006

Please rush out an update to make the little footballs viewable in the app

For anybody wondering what this means, open in safari.

  • Locked thread