Coding Horrors: You can gather all your technical debt into one easy framework!

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!

«‹›1503 »

Powerful Two-Hander: Mar 10, 2004; Mods please change my name to "Tooter Skeleton" TIA.

Subjunctive posted:

Or they need to put some RAM in the babby server.

My contribution to the incident was asking if they got the server out of a skip :v:

# ? Nov 22, 2014 12:05

Adbot: ADBOT LOVES YOU

# ? May 21, 2024 00:12

Zopotantor: Feb 24, 2013; ...und ist er drin dann lassen wir ihn niemals wieder raus...

baka kaba posted:

Don't be silly, it clearly gets tomorrow's date today, when today is tomorrow and tomorrow is today

Is your name Arnie?

# ? Nov 22, 2014 15:33

linusBorlaug: Aug 1, 2013

nuvan posted:

Internal company tool. Also not the only CFMX7 app that we have, though I've never supported any but this and one other.

It has some 800 .cfm files scattered around the codebase, with some 2000 <cfquery>s. Guess how many <cfqueryparam>s there are?

Go on, guess.

At least it's under source control.

I'm gonna guess zero. I just found a query yesterday with 70 values from the form scope and 10 from the url scope. Web facing. Zero queryparams.

# ? Nov 22, 2014 17:13

nuvan: Mar 29, 2008; And the gentle call of the feral 3am "Everything is going so well you can't help but panic."

linusBorlaug posted:

I'm gonna guess zero. I just found a query yesterday with 70 values from the form scope and 10 from the url scope. Web facing. Zero queryparams.

Correct, sir! Also, how do you still have a database?

I found it's actually a very zen-like experience to go through the codebase adding queryparams. As a result, I've set up a branch where, if I need to relax at work for a bit, I go through and fix up 2 or 3 files.

Of course, in order to keep the zen I'm not verifying the DB column types, just picking based on field name and my memory of the DB structure.

# ? Nov 22, 2014 18:37

baka kaba: Jul 19, 2003; PLEASE ASK ME, THE SELF-PROFESSED NO #1 PAUL CATTERMOLE FAN IN THE SOMETHING AWFUL S-CLUB 7 MEGATHREAD, TO NAME A SINGLE SONG BY HIS EXCELLENT NU-METAL SIDE PROJECT, SKUA, AND IF I CAN'T PLEASE TELL ME TO
EAT SHIT

Zopotantor posted:

Is your name Arnie?

I'm the frog

# ? Nov 22, 2014 20:01

linusBorlaug: Aug 1, 2013

nuvan posted:

Correct, sir! Also, how do you still have a database?

Firewalls and dumb luck.

I have spent so much time just going through and adding cfqueryparams down a list in unparamed queries. If sp_help didn't exist as a quick way to get all my data types, I probably wouldn't have a liver anymore.

# ? Nov 22, 2014 20:17

TopShelfer: Feb 25, 2007; Me and my deaf girlfriend went out to dinner. All of a sudden all I could hear was "UUUHHHH HHHHUR RRRAA AAAGGGL LLLLLL NGGGG UHHHHRR RRRR" It was awkward and just weird.

TopShelfer fucked around with this message at 03:47 on Nov 29, 2014

# ? Nov 24, 2014 17:26

Hiowf: Jun 28, 2013; We don't do .DOC in my cave.

I'm sure your employer (or even worse, customer) in the oilfield industry is thrilled with his source code (including obvious security holes) being leaked onto the internet. Sounds like you deserve each other.

# ? Nov 24, 2014 17:40

Maluco Marinero: Jan 18, 2001; Damn that's a
fine elephant.

Skuto posted:

I'm sure your employer (or even worse, customer) in the oilfield industry is thrilled with his source code (including obvious security holes) being leaked onto the internet. Sounds like you deserve each other.

Seriously wtf mate?

# ? Nov 24, 2014 18:04

astr0man: Feb 21, 2007; hollyeo deuroga

Also good job leaking it from your personal dropbox account instead of at least using an anonymous pastebin or something

# ? Nov 24, 2014 18:06

Necc0: Jun 30, 2005; by exmarx; Broken Cake

Dude... what are you doing :stonk:

# ? Nov 24, 2014 18:07

No Safe Word: Feb 26, 2005

The horror is coming from inside the thread?

# ? Nov 24, 2014 18:12

power botton: Nov 2, 2011

TopShelfer posted:

I have struck gold...

My company got stuck with trying to fix numerous bugs in this software. Please kill me. This is supposed to be a simple data entry form somehow someway built onto a wordpress theme. In total it is over 100,000 lines of code. Nearly all is unintelligible.
php:
<?
    public function fsrObject() {
        // Configure poo poo hole ..
        $this->__shit_happened = dirname( __FILE__ ) . '/_shit/level-1-' . date( 'Y-m-d' ) . '.txt';
        if ( $this->__shit_happened !== false ) $this->__shit_hole_active = true;

        global $current_user;
        get_currentuserinfo();
        $this->wp_user = $current_user;

    }
?>
Full files for your enjoyment:

https://dl.dropboxusercontent.com/u/6098817/fsr-db.php
https://dl.dropboxusercontent.com/u/6098817/fsr-functions.php
https://dl.dropboxusercontent.com/u/6098817/fsrObject.php
https://dl.dropboxusercontent.com/u/6098817/fsrPageMeta.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/section_die_penetration.form.php

Amazing

# ? Nov 24, 2014 18:22

Wheany: Mar 17, 2006; Spinya^{ha^{ha^haha}ha}ha_{ha_{ha_haha}ha}ha!; Doctor Rope

# ? Nov 24, 2014 18:29

Suspicious Dish: Sep 24, 2011; 2020 is the year of linux on the desktop, bro; Fun Shoe

Wheany posted:

That man has three hands.

# ? Nov 24, 2014 18:39

Suspicious Dish: Sep 24, 2011; 2020 is the year of linux on the desktop, bro; Fun Shoe

TopShelfer posted:

I have struck gold...

My company got stuck with trying to fix numerous bugs in this software. Please kill me. This is supposed to be a simple data entry form somehow someway built onto a wordpress theme. In total it is over 100,000 lines of code. Nearly all is unintelligible.

You are not a good person.

# ? Nov 24, 2014 18:39

qntm: Jun 17, 2009

TopShelfer posted:

Please kill me.

I think you've killed yourself

# ? Nov 24, 2014 19:06

Xenoveritas: May 9, 2010; Dinosaur Gum

Suspicious Dish posted:

That man has three hands.

Nah, he just has one of those drinking birds hitting the F5 key. A really, really fast one.

Also, can anyone spot what's wrong with this query when done using the Drupal database API?

SQL code:

SELECT * FROM l INNER JOIN r ON l.id = REPLACE(r.id, '-suffix', '')

That's right, it contains an empty string, which Drupal find-and-replaces with '^' in certain database drivers. (For example, it does in the Oracle driver, but not the MySQL driver. Guess what the module I'm working on was originally tested against and what the actual database is.) That took me a while to notice.

# ? Nov 24, 2014 19:07

QuarkJets: Sep 8, 2008

Suspicious Dish posted:

That man has three hands.

That's his dick smashing into the F5 key over and over

# ? Nov 24, 2014 19:09

fritz: Jul 26, 2003

Suspicious Dish posted:

That man has three hands.

Horrors of all kinds welcome in this thread.

# ? Nov 24, 2014 19:17

Lain Iwakura: Aug 5, 2004; The body exists only to verify one's own existence.; Taco Defender

TopShelfer posted:

I have struck gold...

My company got stuck with trying to fix numerous bugs in this software. Please kill me. This is supposed to be a simple data entry form somehow someway built onto a wordpress theme. In total it is over 100,000 lines of code. Nearly all is unintelligible.
php:
<?
    public function fsrObject() {
        // Configure poo poo hole ..
        $this->__shit_happened = dirname( __FILE__ ) . '/_shit/level-1-' . date( 'Y-m-d' ) . '.txt';
        if ( $this->__shit_happened !== false ) $this->__shit_hole_active = true;

        global $current_user;
        get_currentuserinfo();
        $this->wp_user = $current_user;

    }
?>
Full files for your enjoyment:

https://dl.dropboxusercontent.com/u/6098817/fsr-db.php
https://dl.dropboxusercontent.com/u/6098817/fsr-functions.php
https://dl.dropboxusercontent.com/u/6098817/fsrObject.php
https://dl.dropboxusercontent.com/u/6098817/fsrPageMeta.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/section_die_penetration.form.php

Why would you repost your company's source code like that?

I guess it's a good thing you took it down already.

# ? Nov 24, 2014 19:32

down with slavery: Dec 23, 2013; STOP QUOTING MY POSTS SO PEOPLE THAT AREN'T IDIOTS DON'T HAVE TO READ MY FUCKING TERRIBLE OPINIONS THANKS

TopShelfer posted:

I have struck gold...

Full files for your enjoyment:

https://dl.dropboxusercontent.com/u/6098817/fsr-db.php
https://dl.dropboxusercontent.com/u/6098817/fsr-functions.php
https://dl.dropboxusercontent.com/u/6098817/fsrObject.php
https://dl.dropboxusercontent.com/u/6098817/fsrPageMeta.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/section_die_penetration.form.php

I hope you were planning on finding a new job.

# ? Nov 24, 2014 19:40

ymgve: Jan 2, 2004; Offensive Clock

TopShelfer posted:

https://dl.dropboxusercontent.com/u/6098817/fsr-db.php
https://dl.dropboxusercontent.com/u/6098817/fsr-functions.php
https://dl.dropboxusercontent.com/u/6098817/fsrObject.php
https://dl.dropboxusercontent.com/u/6098817/fsrPageMeta.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/functions-fsr.php
https://dl.dropboxusercontent.com/u/6098817/section_die_penetration.form.php

NSA thanks you for making the job easier for them

# ? Nov 24, 2014 19:54

Voronoi Potato: Apr 4, 2010

Suspicious Dish posted:

That man has three hands.

That's not his hand. Why did he post so much code when a snippet would be fine?

# ? Nov 24, 2014 20:03

Fart Sandwiches: Apr 4, 2006; i never asked for this

Voronoi Potato posted:

That's not his hand. Why did he post so much code when a snippet would be fine?

Check his post history. Dude was probably high.

# ? Nov 24, 2014 20:14

qntm: Jun 17, 2009

To be fair, every line of that code was horrendous. SQL query with 31 INNER JOINs, class with over 1400 member variables, nested ternary operators with assignment expressions as arguments... And is it a horror for a switch statement to use decimal numbers as cases?

# ? Nov 24, 2014 20:27

Mogomra: Nov 5, 2005; simply having a wonderful time

I don't think anyone is questioning the horror in the code.

Why would anyone post that much, apparently unaltered, closed source code is beyond me, and the rest of this thread.

:thejoke:

# ? Nov 24, 2014 20:34

Westie: May 30, 2013; Baboon Simulator

qntm posted:

To be fair, every line of that code was horrendous. SQL query with 31 INNER JOINs, class with over 1400 member variables, nested ternary operators with assignment expressions as arguments... And is it a horror for a switch statement to use decimal numbers as cases?

I wish I wasn't as slow at reading this thread.

# ? Nov 24, 2014 20:52

Munkeymon: Aug 14, 2003; Motherfucker's got an
armor-piercing crowbar! Rigoddamndicu𝜆ous.

qntm posted:

To be fair, every line of that code was horrendous. SQL query with 31 INNER JOINs, class with over 1400 member variables, nested ternary operators with assignment expressions as arguments... And is it a horror for a switch statement to use decimal numbers as cases?

You mean like

php:

<?
case 2.54:
    die_horribly();
    break;
case 2.55:
    sunshine_and_rainbows();
    break;
?>

# ? Nov 24, 2014 21:26

down with slavery: Dec 23, 2013; STOP QUOTING MY POSTS SO PEOPLE THAT AREN'T IDIOTS DON'T HAVE TO READ MY FUCKING TERRIBLE OPINIONS THANKS

Am I the only person who just hates switch statements of all kinds?

# ? Nov 24, 2014 21:27

astr0man: Feb 21, 2007; hollyeo deuroga

down with slavery posted:

Am I the only person who just hates switch statements of all kinds?

Nope. https://www.python.org/dev/peps/pep-3103

# ? Nov 24, 2014 21:31

hobbesmaster: Jan 28, 2008

down with slavery posted:

Am I the only person who just hates switch statements of all kinds?

It should pretty much only be used with enums and is horribly abused in practice with everything else.

Then again a giant if/else or ternary chain can be just as bad or worse

# ? Nov 24, 2014 21:37

Munkeymon: Aug 14, 2003; Motherfucker's got an
armor-piercing crowbar! Rigoddamndicu𝜆ous.

hobbesmaster posted:

It should pretty much only be used with enums and is horribly abused in practice with everything else.

Then again a giant if/else or ternary chain can be just as bad or worse

Global dictionary of values -> handlers :unsmigghh:

# ? Nov 24, 2014 21:40

Soricidus: Oct 21, 2010; freedom-hating statist shill

hobbesmaster posted:

It should pretty much only be used with enums and is horribly abused in practice with everything else.

switch/case on enums is basically a bad language's substitute for pattern matching on algebraic data types.

# ? Nov 24, 2014 21:49

Wheany: Mar 17, 2006; Spinya^{ha^{ha^haha}ha}ha_{ha_{ha_haha}ha}ha!; Doctor Rope

Suspicious Dish posted:

That man has three hands.

Geeze, everyone's a critic

:munch:

# ? Nov 24, 2014 21:51

hobbesmaster: Jan 28, 2008

Soricidus posted:

switch/case on enums is basically a simpler language's substitute for pattern matching on algebraic data types.

switch/case can be used to implement a particularly feature not in the language, yes. goto's and longjmps are also used regularly in C code that needs exception handling.

# ? Nov 24, 2014 21:54

Scaramouche: Mar 26, 2001; SPACE FACE! SPACE FACE!

I gotta admit, I'm a coding horror. Something about switch/case just feels so right to me. Generally not for controlling program execution, but I do a lot of undifferentiated string parsing from multiple suspect sources (e.g. EDI files, csv files, multi-standard XML files) so if I want to store "red" then I'm SELECT CASE'ing through "crimson","redd","rouge","scarlet","blood" etc etc.

# ? Nov 24, 2014 22:09

Athas: Aug 6, 2007; fuck that joker

Mogomra posted:

I don't think anyone is questioning the horror in the code.

Why would anyone post that much, apparently unaltered, closed source code is beyond me, and the rest of this thread.

Is this source code really something a competitor would want to steal?

(I've never worked on/with closed source code, so I don't have much intuitive understanding as to why it's supposed to be sensitive. Most code is almost useless without its documentation or supporting environment anyway, and if it's not, you probably can't claim you wrote it without it being trivially obvious that you did not.)

# ? Nov 24, 2014 22:28

Bognar: Aug 4, 2011; I am the queen of France; Hot Rope Guy

It's not about stealing it, it's about breaking the NDA or other contract you inevitably signed with your employer saying you won't share proprietary code. Posting snippets like in this thread is excusable, posting 7 whole files is not.

There are plenty of other reasons an employer wouldn't want this code to get out. What happens when someone identifies the company? Now a Google search could tell us that the company has terrible, terrible coding practice and suddenly they have a hard time hiring developers or have to start paying more for them.

# ? Nov 24, 2014 22:36

Adbot: ADBOT LOVES YOU

# ? May 21, 2024 00:12

Westie: May 30, 2013; Baboon Simulator

Bognar posted:

or have to start paying more for them.

And that's a bad thing? :getin:

# ? Nov 24, 2014 22:43

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!

«‹›1503 »