Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Post
  • Reply
Hughlander
May 11, 2005

a foolish pianist posted:

We make sure never to push anything new on Friday, even.

Friday or after 4pm! Which has the common joke of, "We can only push after 4pm on Fridays right?" when product people inevitably want to push something out this moment.

Adbot
ADBOT LOVES YOU

Gounads
Mar 13, 2013

Where am I?
How did I get here?

a foolish pianist posted:

We make sure never to push anything new on Friday, even.

Most of our deployments happen during the week. Unfortunately this one required a few minutes of downtime, so weekend it was.

Steve French
Sep 8, 2003

For us, weekends are peak traffic. The good thing about that is that planned outages or maintenances are during work hours... The bad (for those of us on call) is that unplanned ones are usually at 5AM on Sundays.

Vulture Culture
Jul 14, 2003

I was never enjoying it. I only eat it for the nutrients.

My Rhythmic Crotch posted:

You ought to just ask that question straightaway rather than beating around the bush about it IMO. Much more straight forward.
Better off just asking the candidate if they're the right person for the job and letting them explain why. If they ask any questions, just give them a silent dumbfounded stare.

ToxicSlurpee
Nov 5, 2003

-=SEND HELP=-


Pillbug
Just put all the candidates in a room then put the interviewer in the middle and blindfold him. Spin him around a bunch then have him try to walk in a straight line. First candidate he blunders into and knocks over gets the job.

necrobobsledder
Mar 21, 2005
Lay down your soul to the gods rock 'n roll
Nap Ghost
Job interviews in some countries are done with all the candidates in a room together with the interview panel. That could get pretty awkward.

smackfu
Jun 7, 2004

Hughlander posted:

Friday or after 4pm! Which has the common joke of, "We can only push after 4pm on Fridays right?" when product people inevitably want to push something out this moment.

We are b2b so our customers work 9-5 weekdays in whatever time zone they are. So all our deployments are at night and usually on Friday night, so we have time to fix things if stuff goes wrong before Monday which is our biggest day.

Yay.

Space Kablooey
May 6, 2009


ToxicSlurpee posted:

Just put all the candidates in a room then put the interviewer in the middle and blindfold him. Spin him around a bunch then have him try to walk in a straight line. First candidate he blunders into and knocks over gets the job.

gather all the cvs in a pile and throw them upwards, whichever cv the hr person picks gets the job.

My Rhythmic Crotch
Jan 13, 2011

I unironically agree

CPColin
Sep 9, 2003

Big ol' smile.
The COO sent out an email earlier congratulating several people for getting promotions, along with a list of who got what. Just now, I heard a coworker congratulate one of the people who got promoted and she didn't know she got one, because she hadn't read the email yet. Whee!

Also, a few people were promoted to a job title I hadn't heard of, so I asked what it meant and the COO asked why I wanted to know. Whee again!

Gounads
Mar 13, 2013

Where am I?
How did I get here?
me: The new super cheap overseas developers we hired 2 months ago are producing approximately 10% more work but are taking up more than 10% of the previous team's time, it's a net negative so far. Here's the data. I suggest we higher a single top-tier developer and replace them.

ceo: Sure!

10 minutes later... CC'd on email to another cheap overseas developer asking about his availability.

me: wtf?

ceo: It's a cultural thing. Demand that they do 10x more work.

sigh

spiritual bypass
Feb 19, 2008

Grimey Drawer
Wanted: Top Tier Developer

Pollyanna
Mar 5, 2005

Milk's on them.


Wanted: Pie-in-CEO-face Thrower

Volmarias
Dec 31, 2002

EMAIL... THE INTERNET... SEARCH ENGINES...

rt4 posted:

Wanted: Top Tear Developer

PT6A
Jan 5, 2006

Public school teachers are callous dictators who won't lift a finger to stop children from peeing in my plane
I was having a discussion with a developer, who's apparently in charge of a team of programmers, who was opining to me that he doesn't really understand the purpose of unit testing and thinks it's often a waste of time.

Myself, I don't envy the people working for him.

Edison was a dick
Apr 3, 2010

direct current :roboluv: only

PT6A posted:

I was having a discussion with a developer, who's apparently in charge of a team of programmers, who was opining to me that he doesn't really understand the purpose of unit testing and thinks it's often a waste of time.

Myself, I don't envy the people working for him.

It's worse when it's the CEO who holds this opinion.

There is a point in there, that it's an effort trade-off on effort spent writing and updating tests when your program changes vs fixing bugs because behaviour changed unintentionally, and that requiring tests reduces development momentum, but I've seen first-hand what the logical extreme is, and once the program gets big enough that it can actually do anything useful, development stalls because without tests everything is always broken.

100 degrees Calcium
Jan 23, 2011



PT6A posted:

I was having a discussion with a developer, who's apparently in charge of a team of programmers, who was opining to me that he doesn't really understand the purpose of unit testing and thinks it's often a waste of time.

Myself, I don't envy the people working for him.

The senior developer on my team is precisely the same way, and it is aggravating. She complains about the amount of "useless code" it requires and I gotta either pretend the poo poo she's saying makes sense or get into a futile argument. And all this poo poo from someone who insists on having hours of meetings over weeks before any code is even written.

Messyass
Dec 23, 2003

Edison was a dick posted:

It's worse when it's the CEO who holds this opinion.

No, that's to be expected. I don't expect a CEO to really grasp why unit tests help, although in the long run she should be able to see the benefits.

If a developer doesn't understand why they are good, I'd question his professionalism.

Che Delilas
Nov 23, 2009
FREE TIBET WEED

Edison was a dick posted:

There is a point in there, that it's an effort trade-off on effort spent writing and updating tests when your program changes vs fixing bugs because behaviour changed unintentionally, and that requiring tests reduces development momentum, but I've seen first-hand what the logical extreme is, and once the program gets big enough that it can actually do anything useful, development stalls because without tests everything is always broken.

It's not just that everything is always broken. You can fix things that you know are broken. The real hell is all the poo poo that MIGHT be broken, and maybe you don't find out until a customer runs an end-of-month billing report and finds massive discrepancies. If you change something deep in the code base and it doesn't have excellent unit test coverage that defines its expected behavior, you can't have real confidence that you aren't going to break something, especially subtle things.

Messyass
Dec 23, 2003

For me it's quite simple: if you want to be truly agile you need some degree of continuous delivery, which means you need continuous integration, which means you need proper automated testing on all levels of the test pyramid.

The only other options are that you're a god programmer who never makes mistakes or you have an endless supply of human testers at your disposal.

ChickenWing
Jul 22, 2010

:v:

I only discovered the joys of unit testing recently (early in this thread, I think) and I cannot concieve of the kind of mind that thinks "nope those are a waste of time". They've saved me so much time from manually testing, and it's so easy to know when you've broken something if you have halfway decent tests. There's a couple teams working on my current project, and one offsite team is incredibly lax in this regard, and it shows. They've become something of a running joke in the office, because you can be sure that if something's hosed on the main branch, it's because they put it in.

Pollyanna
Mar 5, 2005

Milk's on them.


My project has foregone writing tests in lieu of shoving more and more features into the app and it's just getting harder and harder to support over time. They actually wanna go to market with this poo poo :smithicide:

I will die before my name is associated with a product that has SQL written inline in HTML.

Gounads
Mar 13, 2013

Where am I?
How did I get here?

Pollyanna posted:

My project has foregone writing tests in lieu of shoving more and more features into the app and it's just getting harder and harder to support over time. They actually wanna go to market with this poo poo :smithicide:

I will die before my name is associated with a product that has SQL written inline in HTML.

Wait. What?

Docjowles
Apr 9, 2009

Is this app like literally doing

code:
<form action="/lol.php?sql='DROP DATABASE shit_app;'" method="post">
? Because if so that is the most amazing thing I have ever heard :allears:

Pollyanna
Mar 5, 2005

Milk's on them.


As part of an ERB template, I mean. Not insecure, but still stupid.

It's bad, but not THAT bad. I think.

spiritual bypass
Feb 19, 2008

Grimey Drawer

Pollyanna posted:

My project has foregone writing tests in lieu of shoving more and more features into the app

You write the tests while you write the features :eng101:
Of course that's easier said than done in an already lovely codebase

Gounads
Mar 13, 2013

Where am I?
How did I get here?
Once you've gone the no-tests route it gets harder and harder to take time out and go back and do them.

On my current project we had to do that maybe a year and a half ago. Stopped development for a few weeks and just wrote tests. Been keeping up with them since that. Obviously it was a big cost at the time and slowed us down temporarily. But since then it's saved a lot more time than we spent, and we've had higher quality releases going out.

But I'm just preaching to the choir...

PT6A
Jan 5, 2006

Public school teachers are callous dictators who won't lift a finger to stop children from peeing in my plane
I don't write tests as often as I should because I'm a lazy rear end in a top hat, but boy howdy are they useful and I should write comprehensive unit tests more often.

The fact that someone would both not write proper unit tests and not think they're at all a good idea, or equally, that they do write unit tests and still think they're useless -- that's a big error in judgement.

Pollyanna
Mar 5, 2005

Milk's on them.


Our app just needs an overhaul. It relies on weird Rails form-and-partial-driven stuff for the UI. It would benefit immensely from a front-end framework to handle application state and fancy pants features that are horribly fragile when you try and do it via jQuery on initialization.

I can't even elucidate very well exactly what is wrong with it. It's just overall crap and it won't be getting better anytime soon. Improving it would require herculean effort and I just don't have the capacity to put that in, the problems just extend everywhere. :(

Xarn
Jun 26, 2015

PT6A posted:

I don't write tests as often as I should because I'm a lazy rear end in a top hat, but boy howdy are they useful and I should write comprehensive unit tests more often.

The fact that someone would both not write proper unit tests and not think they're at all a good idea, or equally, that they do write unit tests and still think they're useless -- that's a big error in judgement.

During my last job, I found out that whether I will or won't write tests, very strongly depends on how much bullshit I have to jump through before the tests are up and running.

We had a policy that anything shipping must have tests, and the time for making these was included in estimates. However, "development tools" didn't have to be tested and I was making one of those at the time. I actually had tests ready, but then found out, that tests had to be in different project. But to test from different project, tested functions had to be exported as a library... which would mean adding yet another project, to be compiled as a library and leaving the original project as a single file, that calls into the library, loving around with our build system (at the time, there was noone who knew WTF was really going on, later I ended up spending 2 months to unfuck our build system into something that was at least kinda sane, if you didn't look too hard) So there are no tests for anything written for that "development tool" and good luck if something breaks.


At another time, I wrote unit tests for ~200 lines of homework code, because it was less work than copy pasting input and checking output once.

smackfu
Jun 7, 2004

Gounads posted:

Once you've gone the no-tests route it gets harder and harder to take time out and go back and do them.

On my current project we had to do that maybe a year and a half ago. Stopped development for a few weeks and just wrote tests. Been keeping up with them since that. Obviously it was a big cost at the time and slowed us down temporarily. But since then it's saved a lot more time than we spent, and we've had higher quality releases going out.

But I'm just preaching to the choir...

It also depends on how testable your code is. If it's an old code base using stuff like queries in business methods and static methods, you need to do a lot of refactoring just to get tests working.

Gounads
Mar 13, 2013

Where am I?
How did I get here?
I think I need to add a new task to my interviews.

Here's a github repo with 3 branches, A, B, C
Fork it, make a change to Branch B
Merge in Branch C (and I'd set up a simple merge conflict beforehand)
Create a pull request to branch A

The amount of time I spend training people to do things like this is absurd.

spiritual bypass
Feb 19, 2008

Grimey Drawer
Added an environment configuration file, an autoloader, and one automated test to an old-style (aka bad) PHP application that our company depends on. May we have many refactorings and tests to come :unsmith:

Munkeymon
Aug 14, 2003

Motherfucker's got an
armor-piercing crowbar! Rigoddamndicu𝜆ous.



Gounads posted:

I think I need to add a new task to my interviews.

Here's a github repo with 3 branches, A, B, C
Fork it, make a change to Branch B
Merge in Branch C (and I'd set up a simple merge conflict beforehand)
Create a pull request to branch A

The amount of time I spend training people to do things like this is absurd.

git hasn't been around and in widespread use for that long that you can expect everyone to just know how to use it, so if your job listing doesn't have git under must-know, then that's not a very fair question unless part of the process is letting them figure it out themselves with access to google.

CPColin
Sep 9, 2003

Big ol' smile.
Guy asking a question on Experts Exchange: "Selecting a line, cutting, and pasting takes too long in Eclipse. Is there an easier way to move single lines around?"
Me: "Alt-Up and Alt-Down."
Guy: "Do you have to select the line first?"

Ugh why wouldn't you just try what I said first it would take a tenth of the time! This is beyond just terrible programmer, right? Though an unwillingness to try things out is definitely a hallmark of terrible programmers.

Edit: Meant to post that in the Terrible Programmer thread in YOSPOS.

CPColin fucked around with this message at 16:43 on Jul 8, 2016

Steve French
Sep 8, 2003

Munkeymon posted:

git hasn't been around and in widespread use for that long that you can expect everyone to just know how to use it, so if your job listing doesn't have git under must-know, then that's not a very fair question unless part of the process is letting them figure it out themselves with access to google.

Not just git, but specifically GitHub.

FlapYoJacks
Feb 12, 2009
libsepol uses <sys/cdefs.h> :suicide:

I sent a patch upstream to fix it, but Jesus Christ, why are they using internal c library headers?

Zemyla
Aug 6, 2008

I'll take her off your hands. Pleasure doing business with you!

ratbert90 posted:

libsepol uses <sys/cdefs.h> :suicide:

I sent a patch upstream to fix it, but Jesus Christ, why are they using internal c library headers?

Because it was the first Google result for the function/macro/type they wanted to use, maybe?

Cancelbot
Nov 22, 2006

Canceling spam since 1928

Breaking the monolith - Salami style!

As a proof of concept for MICROSERVICES, a team broke out an address lookup from our big blob of a backend system. This has a post code entry, address fields, and a button to do lookups. Finally it updates the address on a customer order when you click a button.

They managed to break out 4 loving services for this nonsense, not including the existing postcode lookup via 3rd party!

- Postcode entry + results list service (Full vertical slice - Including markup!)
- Address entry service (Another full slice!)
- Address updater service which spoke to a "legacy connector"
- View aggregation service (take service output and combine into single view through jQuery HTML smashing)

All talking through an in-client javascript message bus, except the updater which eventually updated the database when something was pushed to rabbitMQ. I can see the point of making it a single service that takes in data / spits out data but 4 services, including one dedicated to smashing together two service outputs seems ridiculous to me?

Adbot
ADBOT LOVES YOU

spiritual bypass
Feb 19, 2008

Grimey Drawer
As a "proof of concept" it sounds like they proved they could do it. But why did they say they were doing this?

  • 1
  • 2
  • 3
  • 4
  • 5
  • Post
  • Reply