Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Locked thread
Cold on a Cob
Feb 6, 2006

i've seen so much, i'm going blind
and i'm brain dead virtually

College Slice

OSI bean dip posted:

i only need an account to do online grocery orders

that said the rumour is that they're unsure how they got breached even though it seems to be based on previous breach data (ie: from Ashley Madison or whatever) being used to get access

i heard this was happening so i proactively changed my password and then a week or so later they emailed to tell me to change my password because they detected a breach

makes me wonder if they know which accounts were leaked or if they're just watching for pw changes and responding to that haha

Adbot
ADBOT LOVES YOU

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug
troy hunt could make some serious money by setting up a watchdog notification service for businesses to sign up to, for a small yearly fee

dude prolly doesn't need any more cash though, he's already got a massive house on the aus gold coast

Shaggar
Apr 26, 2006

Bhodi posted:

you're assuming CI is only used for spitting out artifacts, which is really limiting what a good setup can do. I have it so if a dev tags one of their branches the CI will pick it up and run it's tests for them, so they can repeatedly run different tests on feature branches in their own sandbox ahead of time to know before even creating the pull request into dev if it'll pass. it doesn't auto-test on every feature branch commit, only on main commits to the dev branch (which no one should ever commit anything directly to unless your group is tiny)

if a dev is running their own feature branch who cares if they break the build? they're the only ones working in it.

flakeloaf
Feb 26, 2003

Still better than android clock

OSI bean dip posted:

that said the rumour is that they're unsure how they got breached even though it seems to be based on previous breach data (ie: from Ashley Madison or whatever) being used to get access

i'd also heard that it was less "someone broke the ice on our gibson" and more "people bad at picking passwords are also bad at not reusing passwords"

Lain Iwakura
Aug 5, 2004

The body exists only to verify one's own existence.

Taco Defender

flakeloaf posted:

i'd also heard that it was less "someone broke the ice on our gibson" and more "people bad at picking passwords are also bad at not reusing passwords"

they also have garbage password requirements

Cold on a Cob
Feb 6, 2006

i've seen so much, i'm going blind
and i'm brain dead virtually

College Slice

flakeloaf posted:

i'd also heard that it was less "someone broke the ice on our gibson" and more "people bad at picking passwords are also bad at not reusing passwords"

not in my case, mine was randomly generated

however, this


OSI bean dip posted:

they also have garbage password requirements

is true. i usually use 12 characters upper/lower/number/symbol mixed but pc plus required 8 character max with no symbols

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug

Shaggar posted:

if a dev is running their own feature branch who cares if they break the build? they're the only ones working in it.
if you don't do it that way, you need the CI as a gatekeeper to prevent garbage making it's way directly into the dev branch and also for testing the feature->dev pull requests regardless

also good and related: make sure you don't just lint and do basic CI, better check for passwords as well because devs "whoops" them from their private code into dev all the loving time

Bhodi fucked around with this message at 18:45 on Feb 21, 2017

invision
Mar 2, 2009

I DIDN'T GET ENOUGH RAPE LAST TIME, MAY I HAVE SOME MORE?

Cold on a Cob posted:

not in my case, mine was randomly generated


Pretty sure that was just a mass email to everyone who has an account?

Shaggar
Apr 26, 2006

Bhodi posted:

if you don't do it that way, you need the CI as a gatekeeper to prevent garbage making it's way directly into the dev branch and also for testing the feature->dev pull requests regardless

iu guess I don't really see the problem w/ broken builds getting into the CI system since either
A) The non-compiling code is critical for moving forward in which case it has to be fixed and building the code before it was checked in is pointless
B) The non-compiling code is not critical for moving forward in which case we use the last compiled build

idk maybe none of my projects are hugely monolithic like that.

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug

Shaggar posted:

iu guess I don't really see the problem w/ broken builds getting into the CI system since either
A) The non-compiling code is critical for moving forward in which case it has to be fixed and building the code before it was checked in is pointless
B) The non-compiling code is not critical for moving forward in which case we use the last compiled build

idk maybe none of my projects are hugely monolithic like that.
its fine with small groups but balloons into a huge problem when you have people basing new feature branches off of HEAD that's pre-broken and when they test their poo poo for the first time and it's broken and they spend an hour tracking down the code only to find out it was actually a coworker all along

best case it becomes a joke, worst case egos get involved and the knives come out

mostly it's managed by a mutual understanding of what being in a particular branch means, if you work with ppl who know there may be broken builds, that's fine for your org. but we work on a sprint where a release branch is branched off dev on a specific day and time, not necessarily by the people committing code, and they need to know it's at least in a mostly-functional state so they can start doing integration/acceptance testing

Bhodi fucked around with this message at 18:55 on Feb 21, 2017

Cold on a Cob
Feb 6, 2006

i've seen so much, i'm going blind
and i'm brain dead virtually

College Slice

invision posted:

Pretty sure that was just a mass email to everyone who has an account?

yeah could be. they're not sending to everyone at the same time because i read about it awhile ago but they could be doing it in chunks

Wiggly Wayne DDS
Sep 11, 2010



they email the most likely to be breached first

Cold on a Cob
Feb 6, 2006

i've seen so much, i'm going blind
and i'm brain dead virtually

College Slice
oh yeah makes sense, i just read that they are now asking everyone to reset even if they already reset their passwords after the breach was known to have happened

Volmarias
Dec 31, 2002

EMAIL... THE INTERNET... SEARCH ENGINES...

Harik posted:

the command protocol I shot down was full of direct unauthenticated-to-priveleged fuckups because they trusted the ~~app~~ instead of assuming it was hostile.

:holymoley:

Shaggar posted:

iu guess I don't really see the problem w/ broken builds getting into the CI system since either
A) The non-compiling code is critical for moving forward in which case it has to be fixed and building the code before it was checked in is pointless
B) The non-compiling code is not critical for moving forward in which case we use the last compiled build

idk maybe none of my projects are hugely monolithic like that.

Jimmy the Junior Dev keeps "fixing" his assigned issues (lol) but in doing so he's breaking the build for the entire company because he's hard coding absolute paths to his local desktop or something dumb. Now, everyone's build is broken. Is it me? Is it the checked in code? Time to waste a bunch of time figuring this out. The build does get fixed, but everyone's time is wasted because of one single dumb gently caress. It's sort of manageable if your team is 3 people, but consider something with thousands of people all working in the same repository.

You can still use yesterday's artifacts for your deployment, of course, so it's not like you're broken in production (you hope), but you're still eating away everyone's time.

Having a build server gating your proposed commit is an unalloyed good and I'm not really sure how you would argue otherwise, but I guess PHP is just broken all the time anyway so YOLO.

rjmccall
Sep 7, 2007

no worries friend
Fun Shoe
when you have a team collaborating on a single repository, having some amount of gatekeeping to stop patches from even appearing in master if they don't build + pass tests is pretty nice

it's not fool-proof unless you're willing to make committing super painful, though. for example, the swift ci system will test a pr and then tag that commit if the build succeeds; once a commit is tagged, it can be merged. but we allow real merges there, i.e. if someone else merges their patch before you, you don't have to go back to ci for re-approval. so if there's a conflict, and it's not obvious enough to be detected by version control, you can break ci and someone will have to revert. but that's true anyway — we don't run every possible test as part of this "smoke-testing", and sometimes bugs are non-deterministic. still, even if it's not perfect, having that extra step of at least forcing a patch to pass tests on its own does a lot to keep the repository consistently clean, which is important when you have a large-ish team updating their checkouts on their own random-ish schedules

but yeah, don't trust random people on the internet to not submit malicious patches

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug
i do have to admit using the build servers themselves to generate bitcoins is a spark of genius, since in a lot of cases part of the build process is to pull poo poo all over from random places on the internet (hello, maven) so outgoing firewalls are often already open to the build slaves

the next step is obviously combing for :8080 jenkins and non-github stuff that's open facing so you can do the same thing with them. there are lots and lots of CI systems open to the internet out there

Shaggar
Apr 26, 2006

Volmarias posted:

:holymoley:


Jimmy the Junior Dev keeps "fixing" his assigned issues (lol) but in doing so he's breaking the build for the entire company because he's hard coding absolute paths to his local desktop or something dumb. Now, everyone's build is broken. Is it me? Is it the checked in code? Time to waste a bunch of time figuring this out. The build does get fixed, but everyone's time is wasted because of one single dumb gently caress. It's sort of manageable if your team is 3 people, but consider something with thousands of people all working in the same repository.

You can still use yesterday's artifacts for your deployment, of course, so it's not like you're broken in production (you hope), but you're still eating away everyone's time.

Having a build server gating your proposed commit is an unalloyed good and I'm not really sure how you would argue otherwise, but I guess PHP is just broken all the time anyway so YOLO.

If your builds are so large that minor changes in one branch break productivity for everyone your design is probably pretty heinous. also its infinitely more likely that the junior dev will horde his code because the CI keeps rejecting him and then he puts in a slew of changes that have hardcoded garbage to pass tests but that breaks everything in runtime. now you've been building your own stuff against his broken code for weeks cause you've trusted the CI server to gate things for you.

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug

Shaggar posted:

If your builds are so large that minor changes in one branch break productivity for everyone your design is probably pretty heinous. also its infinitely more likely that the junior dev will horde his code because the CI keeps rejecting him and then he puts in a slew of changes that have hardcoded garbage to pass tests but that breaks everything in runtime. now you've been building your own stuff against his broken code for weeks cause you've trusted the CI server to gate things for you.
reports are that this is exactly how the microsoft windows codebase is run

any junior dev that does an end-run around the testing system deliberately, well, that's not a dev thats around for very long. plus, you know, code review, right? collaboration?

Bhodi fucked around with this message at 19:21 on Feb 21, 2017

Shaggar
Apr 26, 2006
sure but one real great way to trigger an out of band code review is a check in that doesn't build. lots of jr devs aren't gonna ask for help cause they're just out of college and they dont understand that they didn't learn anything there. now you're creating a build environment that's hostile to them and they're gonna fall back on the bad habits their profs taught them. A jr dev dodging tests in order to get code to compile is to be expected of a jr dev because they don't understand why tests are important yet.

I like failing builds as a mechanism to detect struggling devs who aren't asking for help. Also I want code in the repo even if its not finished. The last thing I want is code sitting on a laptop that hasn't been checked in in days because its not "perfect".

The MUMPSorceress
Jan 6, 2012


^SHTPSTS

Gary’s Answer

Shaggar posted:

If your builds are so large that minor changes in one branch break productivity for everyone your design is probably pretty heinous. also its infinitely more likely that the junior dev will horde his code because the CI keeps rejecting him and then he puts in a slew of changes that have hardcoded garbage to pass tests but that breaks everything in runtime. now you've been building your own stuff against his broken code for weeks cause you've trusted the CI server to gate things for you.

our entire client codebase is a single repo. if you change the wrong poo poo you can absolutely stop the entire compile from happening. enterprise poo poo is like that oftentimes. stop thinking your 5-man-shop use cases are what everyone deals with.

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug

Shaggar posted:

sure but one real great way to trigger an out of band code review is a check in that doesn't build. lots of jr devs aren't gonna ask for help cause they're just out of college and they dont understand that they didn't learn anything there. now you're creating a build environment that's hostile to them and they're gonna fall back on the bad habits their profs taught them. A jr dev dodging tests in order to get code to compile is to be expected of a jr dev because they don't understand why tests are important yet.

I like failing builds as a mechanism to detect struggling devs who aren't asking for help. Also I want code in the repo even if its not finished. The last thing I want is code sitting on a laptop that hasn't been checked in in days because its not "perfect".
and that's part of why we have a mostly separate and stable dev and only-test-when-you-want feature branches and never deny / rollback direct commits, i can see using failing builds as a barometer but that's untenable in the long run or with larger groups; designing a substandard system because you're assuming people are going to otherwise cheat it is no way to go through life

Bhodi
Dec 9, 2007

Oh, it's just a cat.
Pillbug
e: nm, moved to politics security thread

Bhodi fucked around with this message at 19:50 on Feb 21, 2017

Shaggar
Apr 26, 2006

cis autodrag posted:

our entire client codebase is a single repo. if you change the wrong poo poo you can absolutely stop the entire compile from happening. enterprise poo poo is like that oftentimes. stop thinking your 5-man-shop use cases are what everyone deals with.

your bad design is not shop size specific

Shaggar
Apr 26, 2006

Bhodi posted:

and that's part of why we have a mostly separate and stable dev and only-test-when-you-want feature branches and never deny / rollback direct commits, i can see using failing builds as a barometer but that's untenable in the long run or with larger groups; designing a substandard system because you're assuming people are going to otherwise cheat it is no way to go through life

yeah I guess I never work on huge monolithic repos so its never a problem. god I cant imagine how painful those builds are even when they're working.

rjmccall
Sep 7, 2007

no worries friend
Fun Shoe

Shaggar posted:

sure but one real great way to trigger an out of band code review is a check in that doesn't build. lots of jr devs aren't gonna ask for help cause they're just out of college and they dont understand that they didn't learn anything there. now you're creating a build environment that's hostile to them and they're gonna fall back on the bad habits their profs taught them. A jr dev dodging tests in order to get code to compile is to be expected of a jr dev because they don't understand why tests are important yet.

I like failing builds as a mechanism to detect struggling devs who aren't asking for help. Also I want code in the repo even if its not finished. The last thing I want is code sitting on a laptop that hasn't been checked in in days because its not "perfect".

yeah, you definitely want to encourage code to get committed and tested regularly. the easiest way to do that is to allow ci to build+test from an arbitrary branch, but only make it a gatekeeper on the master / release branches. you can watch + comment on their work on their feature branches, and if they're not committing to them or seem to be flailing against ci, it's easy to step in

Shaggar
Apr 26, 2006
yeah I'm deffo not talking about letting these guys commit into release branches or anything and the ability to check in on what they're doing w/out hovering over their shoulder is super gr8.

Cocoa Crispies
Jul 20, 2001

Vehicular Manslaughter!

Pillbug

OSI bean dip posted:

i only need an account to do online grocery orders

that said the rumour is that they're unsure how they got breached even though it seems to be based on previous breach data (ie: from Ashley Madison or whatever) being used to get access

i hope that means "president's choice plus"

fins
May 31, 2011

Floss Finder
https://googleprojectzero.blogspot.com/2017/02/attacking-windows-nvidia-driver.html

NVIDIA driver bugs

quote:

Most of the vulnerabilities found (13 in total) in escape handlers were very basic mistakes, such as writing to user provided pointers blindly, disclosing uninitialised kernel memory to user mode, and incorrect bounds checking. There were also numerous issues that I noticed (e.g. OOB reads) that I didn’t report because they didn’t seem exploitable.
more in the article

hobbesmaster
Jan 28, 2008

"im trying to scan your device but everything is blocked, how do I fix that"

- an actual customer

Lain Iwakura
Aug 5, 2004

The body exists only to verify one's own existence.

Taco Defender
https://twitter.com/MalwareTechBlog/status/834007198556680192

:qq: I have lovely opinions and as a result I got blocked :qq:

Chris Knight
Jun 5, 2002

me @ ur posts


Fun Shoe
lol

in addition to the pcplus email, I got two fake Apple ID login phishing emails. fun times for all!

anthonypants
May 6, 2007

by Nyc_Tattoo
Dinosaur Gum

Javid posted:

I was really excited to be getting a phone with a fingerprint reader until I actually got it and found out it forces you to put in a code every so often regardless, thus defeating the time-saving purpose of having a fingerprint reader in a spot you'd normally grab the thing. Way to almost implement a good idea!

Lain Iwakura
Aug 5, 2004

The body exists only to verify one's own existence.

Taco Defender

:tif:

Thanks Ants
May 21, 2004

#essereFerrari


if your phone usually only required a fingerprint to unlock past the first boot/period of non-use, but if it were possible to 'hey siri' it into a state of requiring a pin/password again, would that legally count as obstruction?

Lutha Mahtin
Oct 10, 2010

Your brokebrain sin is absolved...go and shitpost no more!

Thanks Ants posted:

if your phone usually only required a fingerprint to unlock past the first boot/period of non-use, but if it were possible to 'hey siri' it into a state of requiring a pin/password again, would that legally count as obstruction?

as an american, i hope that this administration at least gives us a supreme court case with the title Trump v. WeedGoku666

apseudonym
Feb 25, 2011


This made me very sad, thanks thread!

Chris Knight
Jun 5, 2002

me @ ur posts


Fun Shoe
ayyy

https://twitter.com/jeremiahg/status/834085560117440512

Absurd Alhazred
Mar 27, 2010

by Athanatos

OSI bean dip posted:

i only need an account to do online grocery orders

that said the rumour is that they're unsure how they got breached even though it seems to be based on previous breach data (ie: from Ashley Madison or whatever) being used to get access

That looks suspiciously like a phishing scam.

Volmarias
Dec 31, 2002

EMAIL... THE INTERNET... SEARCH ENGINES...

:rip:

Adbot
ADBOT LOVES YOU

Chalks
Sep 30, 2009

Volmarias posted:

:holymoley:


Jimmy the Junior Dev keeps "fixing" his assigned issues (lol) but in doing so he's breaking the build for the entire company because he's hard coding absolute paths to his local desktop or something dumb. Now, everyone's build is broken. Is it me? Is it the checked in code? Time to waste a bunch of time figuring this out. The build does get fixed, but everyone's time is wasted because of one single dumb gently caress. It's sort of manageable if your team is 3 people, but consider something with thousands of people all working in the same repository.

You can still use yesterday's artifacts for your deployment, of course, so it's not like you're broken in production (you hope), but you're still eating away everyone's time.

Having a build server gating your proposed commit is an unalloyed good and I'm not really sure how you would argue otherwise, but I guess PHP is just broken all the time anyway so YOLO.

Our implementation is to have CI on develop and release branches. Jimmy does his development on his own branch, peer code review on push to develop and senior code review on pushing a bunch of changes to release and you only swap things to the development production environment when you're happy it's working on staging.

Everyone will be working on their own branch so you'll only encounter this sort of issue if the code review misses it and someone happens to branch from dev after the point the dodgy commit is made but before anyone notices dev staging servers are all hosed up.

I mean it does happen, development servers are buggy 24/7 anyway, but it's pretty rare for some obvious "nothing works at all" fuckup to interfere with the productivity of other developers.

  • Locked thread