|
CPColin posted:java.util.Collections.reverse(list) no I refuse to explain how that method works This is the correct answer though, right? What was required?
|
# ? Jul 18, 2017 21:17 |
|
|
# ? May 25, 2024 15:16 |
|
leper khan posted:Though for string reversal explicitly I can make a pretty good guess.
|
# ? Jul 18, 2017 21:24 |
|
TheBlackVegetable posted:This is the correct answer though, right? What was required? Demonstrating an understanding of how simple data structures, pointers/ references, and recursion works.
|
# ? Jul 18, 2017 21:54 |
|
Yeah, if you gave that answer, they'd probably ask you to pretend that function doesn't exist and do it by hand.
|
# ? Jul 18, 2017 21:56 |
Yeah, seems like a simple question to get you to talk through some different strategies for repeating processes, recursion vs. iteration. Or just a way to avoid bothering with a 4-hour interview for someone who can't think of an algorithm to reverse a loving list, jesus.
|
|
# ? Jul 18, 2017 23:11 |
|
Volmarias posted:Demonstrating an understanding of how simple data structures, pointers/ references, and recursion works. Yeah, I was joking a bit, and I have seen people struggle with Fizz-Buzz (because they immediately over- engineered it), I just wish interviews could come up with slightly more useful ways of demonstrating that stuff than things that will hardly arise during the development of their legacy CRUD app.
|
# ? Jul 19, 2017 00:00 |
|
TheBlackVegetable posted:Yeah, I was joking a bit, and I have seen people struggle with Fizz-Buzz (because they immediately over- engineered it), I just wish interviews could come up with slightly more useful ways of demonstrating that stuff than things that will hardly arise during the development of their legacy CRUD app. Did somebody say over-engineered fizzbuzz?
|
# ? Jul 19, 2017 02:28 |
|
|
# ? Jul 19, 2017 02:49 |
|
Holy poo poo they have a domain now.
|
# ? Jul 19, 2017 02:58 |
|
I see that and raise you this
|
# ? Jul 19, 2017 03:36 |
CPColin posted:Yeah, if you gave that answer, they'd probably ask you to pretend that function doesn't exist and do it by hand. a foolish pianist posted:Yeah, seems like a simple question to get you to talk through some different strategies for repeating processes, recursion vs. iteration. Yes on both counts. We don't care that you can regurgitate library methods, we want to see you reason your way through a simple problem and be able to discuss it. this continues to be among my favourite things on the internet
|
|
# ? Jul 19, 2017 13:39 |
|
Oh my god some of the pull requests https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition/pull/271 https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition/pull/234 also the fact that they take PRs
|
# ? Jul 19, 2017 14:01 |
|
The worst thing about working in this industry is that I see the value in the over engineering here.
|
# ? Jul 19, 2017 14:37 |
|
Munkeymon posted:Oh my god some of the pull requests The second one is my company at the moment (we're switching from maven to gradle and several people have said, why bother removing maven?)
|
# ? Jul 19, 2017 14:51 |
|
Munkeymon posted:Oh my god some of the pull requests https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition/issues/297
|
# ? Jul 19, 2017 19:17 |
|
Another gem in the ESLinting mines.code:
Just because you can do something doesn't mean you should. E: lol the blame shows this as being from one of the contracting teams tech leads. Gildiss fucked around with this message at 20:30 on Jul 19, 2017 |
# ? Jul 19, 2017 20:04 |
|
Gildiss posted:Another gem in the ESLinting mines. I had to expand that to see what was even going on on mobile. That said, this feels like a minor horror. A slight refactor and you're on your way. Unless the incorrect parenthesis for the toUpper call was intentional, in which case, yikes.
|
# ? Jul 19, 2017 20:42 |
|
Munkeymon posted:Oh my god some of the pull requests I thought this whole repo was a parody
|
# ? Jul 19, 2017 20:49 |
|
Good code is stable maintainable code. Maintainable code is code that is obvious, and not clever. Clever is a novelty and will cost me hours of debugging later when theres a loving problem with it.
|
# ? Jul 19, 2017 20:52 |
|
Rubellavator posted:I thought this whole repo was a parody It is.
|
# ? Jul 19, 2017 21:00 |
|
I spent a good chunk of today writing unit tests for Spring configuration classes to improve our code coverage numbers. AMA.
|
# ? Jul 20, 2017 00:21 |
|
New client, two weeks in and I submitted a PR. Feedback received after a 3 day wait: "yeah, we don't do feature branches. If you think it is good enough, you just push to develop and we'll review it there." Today I did a refresh of develop and merged it / rebased it with my local working branch. A bunch of merge conflicts later, the build was broken and complaining about dependencies. One git blame later the dev told me: "it works on my machine." "Did you upload your changes to nexus?" "... I did now!" But nooo, who needs feature branches and PR's? They just slow down our advanced development processes. Now that I am scrutinizing everything in my role as QA dev, it comes out there is lots of sloppy coding. Looking forward to my summer holidays and we'll see what happens after that.
|
# ? Jul 20, 2017 16:35 |
|
Keetron posted:But nooo, who needs feature branches and PR's? They just slow down our advanced development processes. This is the reasoning the designer of the Ceylon language uses when people call him out for committing broken, half-implemented changes straight to master. He whines that, if he had to do stuff in branches and do pull requests, it would slow him down. Meanwhile, everybody catches all these problems after he's committed that would have been spotted immediately, had he used a PR.
|
# ? Jul 20, 2017 16:39 |
|
I'm sure it feels like it slows you down, but you can't sprint a marathon.
|
# ? Jul 20, 2017 17:18 |
|
Keetron posted:New client, two weeks in and I submitted a PR. This is the workflow of someone who isn't used to having coworkers and/or used atomic locking.
|
# ? Jul 20, 2017 17:23 |
|
Volmarias posted:
I don't usually work with others on projects, and feature branches still save me from myself.
|
# ? Jul 20, 2017 17:26 |
|
I had to have an hour long convo about how PRs and their documentation help bring clarity and stability to what would otherwise be chaos "but they slow me down" ugh yea, sure for a moment but its a loving investment into the future you numbskull. think about how much they will slow you down in the future and how disruptive the bugs will be that result from your poo poo
|
# ? Jul 20, 2017 17:28 |
|
leper khan posted:I don't usually work with others on projects, and feature branches still save me from myself. Very true, I do it with my hobby projects too where its just me drunk coding Really, really, really helps drunk me
|
# ? Jul 20, 2017 17:29 |
|
KoRMaK posted:"but they slow me down" So does version control, dev environments, testing, release tagging, security, compiler warnings, passwords, locking your car door, wiping your rear end, and bathing.
|
# ? Jul 20, 2017 20:08 |
|
lifg posted:So does version control, dev environments, testing, release tagging, security, compiler warnings, passwords, locking your car door, wiping your rear end, and bathing. Ask me about my revolutionary 10-step plan to speed up your whole life!
|
# ? Jul 20, 2017 21:33 |
|
[mashes random keys on keyboard as quickly as his fingers will move] BUT LOOK HOW MUCH MORE PRODUCTIVE I AM
|
# ? Jul 20, 2017 22:15 |
|
smackfu posted:I spent a good chunk of today writing unit tests for Spring configuration classes to improve our code coverage numbers. AMA. Have you politely explained that code coverage is meaningless yet?
|
# ? Jul 20, 2017 22:21 |
|
Code coverage based around heuristics like functional complexity and known problem patterns similar to how FindBugs works is not useless. Basing around lines of code, however, is. Also, I hope you enjoyed the land of bytecode injection and annotations-as-configuration. You also probably got the most out of code coverage by injecting values along the entire property resolution order of package resources and command line params than by exercising your configuration values themselves. necrobobsledder fucked around with this message at 23:04 on Jul 20, 2017 |
# ? Jul 20, 2017 23:01 |
|
New Yorp New Yorp posted:Have you politely explained that code coverage is meaningless yet? At a previous position, I just told my manager we'd get him whatever numbers he needed. I then created a class with 10k loc and 100% coverage that did nothing and wasn't connected to anything. His bosses loved the code coverage numbers our team consistently delivered.
|
# ? Jul 20, 2017 23:11 |
|
baquerd posted:At a previous position, I just told my manager we'd get him whatever numbers he needed. I then created a class with 10k loc and 100% coverage that did nothing and wasn't connected to anything. His bosses loved the code coverage numbers our team consistently delivered. There was one tool I tested for doing C++ code coverage where if you instrumented a templated function, the code coverage would count for every instantiation of the template - e.g. for code:
So you could effectively make the code coverage whatever you wanted just through a bunch of macros.
|
# ? Jul 20, 2017 23:35 |
|
New Yorp New Yorp posted:Have you politely explained that code coverage is meaningless yet? Is it really? It's a bad thing if management mandates an arbitrarily amount--especially if they mandate 100%--but there are good reasons to run coverage metrics. If a file has 0% coverage, then the code in there is a risk or it's completely dead code. Either case is worth addressing to some extent.
|
# ? Jul 21, 2017 00:00 |
|
Enforcing 100% coverage can theoretically encourage people to hammer badly-structured spaghetti code into a more sensible, testable shapes. On the other hand, people who cheerfully write very difficult-to-cover code are exactly the people who also cheerfully write individual unit tests eight times as long as the unit under test, so, the problem of "how to make bad coders produce good code" remains a mystery.
|
# ? Jul 21, 2017 00:19 |
|
Code coverage as a tool for finding code that you forgot to test is useful. Code coverage as a tool for forcing other people to do things is not.
|
# ? Jul 21, 2017 00:38 |
|
Goodhart's Law
|
# ? Jul 21, 2017 01:39 |
|
|
# ? May 25, 2024 15:16 |
|
Oh my god open offices are the worst why does anyone willingly do this?
|
# ? Jul 21, 2017 03:44 |