Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Post
  • Reply
Skandranon
Sep 6, 2008
fucking stupid, dont listen to me

CPColin posted:

Good thing we're on 2015 because ???

VS 2015 should still give you a ref count at the top of every function/class by default.

Adbot
ADBOT LOVES YOU

CPColin
Sep 9, 2003

Big ol' smile.
Well that's what I get for turning off that feature because I didn't like the spacing, I guess! Still would rather see the "unused code" warnings show up without having to fart around with the Code Analysis settings.

Edit: poo poo, that's ugly. And it fades in? Turning it back off.

CPColin fucked around with this message at 21:51 on Sep 22, 2017

Cancelbot
Nov 22, 2006

Canceling spam since 1928

Vulture Culture posted:

Has anyone moved SRE/infrastructure teams to a 1-week sprint cadence? How did it work for you?

Me me! But only in the past month. We've also tried to get each ticket to 1 day and forcing ticket-splitting after 2 days as Infra stuff tends to inexplicably balloon as people pull at ever more tangled threads. I come from being a senior dev to being the "2nd" in our brand new SRE team so I've pulled a lot of practice from our team into this infra world.

So far it's working great, it makes things easier to measure and I think it'll eventually grind down "infra-creep" or at least make it easier to pick up and drop work without it being a catastrophe.

Vulture Culture
Jul 14, 2003

I was never enjoying it. I only eat it for the nutrients.

Cancelbot posted:

Me me! But only in the past month. We've also tried to get each ticket to 1 day and forcing ticket-splitting after 2 days as Infra stuff tends to inexplicably balloon as people pull at ever more tangled threads. I come from being a senior dev to being the "2nd" in our brand new SRE team so I've pulled a lot of practice from our team into this infra world.

So far it's working great, it makes things easier to measure and I think it'll eventually grind down "infra-creep" or at least make it easier to pick up and drop work without it being a catastrophe.
That's great! I've been apprehensive about 1-week sprints on the dev side of the house because it's hard to deliver vertical product increments in that timeframe. On the other hand, SRE priorities change so rapidly here that I've been thinking timeboxing everything, jamming a single "big rock" project at the beginning of the sprint, and filling out the end with smaller pebbles of work will help a lot with the stop-start cycles that end up nuking a bunch of our project productivity.

chutwig
May 28, 2001

BURLAP SATCHEL OF CRACKERJACKS

Vulture Culture posted:

That's great! I've been apprehensive about 1-week sprints on the dev side of the house because it's hard to deliver vertical product increments in that timeframe. On the other hand, SRE priorities change so rapidly here that I've been thinking timeboxing everything, jamming a single "big rock" project at the beginning of the sprint, and filling out the end with smaller pebbles of work will help a lot with the stop-start cycles that end up nuking a bunch of our project productivity.

The challenge I constantly faced (and still face) in sprintifying SRE work is you have to be extremely vigilant about separating planned sprint work from KTLO, to the extent that KTLO stuff should be in its own project and probably shouldn't be managed in an agile way. More often than not, KTLO tasks will spawn planned work, so the projects will be closely intertwined, but should remain separate for the sake of not blowing out your burndown charts with 150 points of unplanned crap that went in after the sprint started.

To that end, having a concept of daytime on-call can help with that. Whoever's up in your on-call rotation also acts as the first responder for user requests/questions and minor triages. In exchange, they get exempted from sprint work, and if nothing's burning down they're free to do whatever they want to fill their time with.

geeves
Sep 16, 2004

Well, some good news to those who use React, Flow, Jest, ImmutableJS. Facebook went MIT license for them.

Vulture Culture
Jul 14, 2003

I was never enjoying it. I only eat it for the nutrients.

chutwig posted:

The challenge I constantly faced (and still face) in sprintifying SRE work is you have to be extremely vigilant about separating planned sprint work from KTLO, to the extent that KTLO stuff should be in its own project and probably shouldn't be managed in an agile way. More often than not, KTLO tasks will spawn planned work, so the projects will be closely intertwined, but should remain separate for the sake of not blowing out your burndown charts with 150 points of unplanned crap that went in after the sprint started.

To that end, having a concept of daytime on-call can help with that. Whoever's up in your on-call rotation also acts as the first responder for user requests/questions and minor triages. In exchange, they get exempted from sprint work, and if nothing's burning down they're free to do whatever they want to fill their time with.
That's roughly the plan. I've used the first-line responder in two previous roles and it's worked well. I think Tom Limoncelli advocated for something similar way back in The Practice of System and Network Administration.

The Fool
Oct 16, 2003


geeves posted:

Well, some good news to those who use React, Flow, Jest, ImmutableJS. Facebook went MIT license for them.

I wonder if that's directly related to the Wordpress post.

brosmike
Jun 26, 2009

chutwig posted:

having a concept of daytime on-call can help with that. Whoever's up in your on-call rotation also acts as the first responder for user requests/questions and minor triages. In exchange, they get exempted from sprint work, and if nothing's burning down they're free to do whatever they want to fill their time with.

I've done this on a few teams (my current team has 2 people at a time on-call, for a different sets of the ancient services we maintain). It works well, assuming your team isn't terrible and values shared ownership. It's not a magic bullet to never interrupt sprint work, but even when a newer dev is on call it works better than I'd expected it to in the first time a team I was on experimented with it. Some books call this position "batman" .

Plorkyeran
Mar 22, 2007

To Escape The Shackles Of The Old Forums, We Must Reject The Tribal Negativity He Endorsed

The Fool posted:

I wonder if that's directly related to the Wordpress post.

The wordpress post itself was a response to FB announcing they were going to stick with the current license, so either they coincidentally pulled a 180 two weeks later or they didn't want to lose WP.

Doh004
Apr 22, 2007

Mmmmm Donuts...

Plorkyeran posted:

The wordpress post itself was a response to FB announcing they were going to stick with the current license, so either they coincidentally pulled a 180 two weeks later or they didn't want to lose WP.

Losing support from the platform that drives an incredible percentage of websites out there seems like a bad thing.

Bruegels Fuckbooks
Sep 14, 2004

Now, listen - I know the two of you are very different from each other in a lot of ways, but you have to understand that as far as Grandpa's concerned, you're both pieces of shit! Yeah. I can prove it mathematically.

CPColin posted:

Well that's what I get for turning off that feature because I didn't like the spacing, I guess! Still would rather see the "unused code" warnings show up without having to fart around with the Code Analysis settings.

Edit: poo poo, that's ugly. And it fades in? Turning it back off.

AFAIK C#/C++ will warn for unused code out of the box using debug builds, but won't check release builds for unused code.

GutBomb
Jun 15, 2005

Dude?

brosmike posted:

I've done this on a few teams (my current team has 2 people at a time on-call, for a different sets of the ancient services we maintain). It works well, assuming your team isn't terrible and values shared ownership. It's not a magic bullet to never interrupt sprint work, but even when a newer dev is on call it works better than I'd expected it to in the first time a team I was on experimented with it. Some books call this position "batman" .

I was kind of this guy full time at one of my previous jobs and I loved it. My regular day to day duties were to maintain the web servers and the dev/staging servers for the team but there was not enough work there to even fill 10% of a 40 hour week every week so I became the guy who helped people out with whatever poo poo they were stuck on and the guy who took care of unexpected poo poo White the rest of the team did sprint work. I'd love this kind of job again but I think it was a bunch of unique situations all happening at once that got me there (I was initially hired as a contractor to set up their web analytics and they liked me so brought me on without really anything to do for a while and it evolved into that) I spent seven years there and near the end the company was acquired and poo poo changed to the point where the work was the same but the company culture shifted and it became a real drag to work there.

geeves
Sep 16, 2004

Plorkyeran posted:

The wordpress post itself was a response to FB announcing they were going to stick with the current license, so either they coincidentally pulled a 180 two weeks later or they didn't want to lose WP.

Pretty much. I don't disagree with FB's legal thought process - who wants to fight off potentially hundreds of suits? However, I think when they put some common sense in, they're going to fight patent trolls and frivolous lawsuits regardless of whatever type of license they distribute open source.

necrobobsledder
Mar 21, 2005
Lay down your soul to the gods rock 'n roll
Nap Ghost

brosmike posted:

It's not a magic bullet to never interrupt sprint work, but even when a newer dev is on call it works better than I'd expected it to in the first time a team I was on experimented with it. Some books call this position "batman" .
At my last job we made Batman AND Superman roles because our team was constantly bombarded with interruptions from everyone everywhere, so we had to divide it between external team requests and internal team requests to let the few that were not fighting fires try to get actual engineering work done. But as expected people got confused over even that simple binary discriminator and it fell apart quickly when everyone else culturally valued "run around and scream" as the process for having ops do things for them. Having mid to senior level engineers that are competent ops engineers do application support constantly is not going to work for more than a week.

Volmarias
Dec 31, 2002

EMAIL... THE INTERNET... SEARCH ENGINES...

necrobobsledder posted:

At my last job we made Batman AND Superman roles

What the hell are these roles supposed to be?

necrobobsledder
Mar 21, 2005
Lay down your soul to the gods rock 'n roll
Nap Ghost
Operations / SRE / devops / engineering efficiency teams are considerably different from software development teams because a lot of the work tends to be transactional rather than project-oriented. However, this doesn't mean that everyone needs to run around frantically responding to fires and angry coworkers needing something immediately. We can't deflect users to a helpdesk or NOC constantly necessarily either because more complicated software systems just can't be resolved with "have you tried turning it off and on again?" variations of troubleshooting. So some teams have the concept of a dedicated interrupt handler to allow others to focus on their project work more. Some places name these people after superheroes because they're supposed to save the day and everyone knows that there's only one Batman and there's only one Superman. The critics of these conventions in my experience normally seem to debate over the semantics of Batman and Superman rather than whether the system even works, so I like the convention so far.

Vulture Culture
Jul 14, 2003

I was never enjoying it. I only eat it for the nutrients.

necrobobsledder posted:

At my last job we made Batman AND Superman roles ... But as expected people got confused over even that simple binary discriminator
I don't know how to tell you this, but

Mniot
May 22, 2003
Not the one you know
Superman is the best at solving a crisis but he will only use ssh and vi and insists on logging in as root.

Batman installs a lot of status monitors and other tooling and automation.

Neither one is willing to kill any process or server, so the AWS bill is crazy-high.

My Rhythmic Crotch
Jan 13, 2011

I heard JJ Abrams is going to direct the screenplay adaptation of Batman vs Superman: Dawn of Devops

fantastic in plastic
Jun 15, 2007

The Socialist Workers Party's newspaper proved to be a tough sell to downtown businessmen.

Mniot posted:

Superman is the best at solving a crisis but he will only use ssh and vi and insists on logging in as root.

Batman installs a lot of status monitors and other tooling and automation.

Neither one is willing to kill any process or server, so the AWS bill is crazy-high.

You are just an ordinary man in a cape. That's why you couldn't fight injustice, that's why you can't mark this ticket as resolved.

toiletbrush
May 17, 2010

CPColin posted:

Why in the poo poo does Visual Studio not flag unused code by default? I'm trying to figure out what the hell this class does and apparently half of its private members are completely unreferenced. Say what you will about Eclipse, but at least it warns you pretty quickly when stuff isn't used!
Are you not using Resharper? Pretty much any version of that will flag unreferenced code in an unobtrusive way.

A friend of mine who's just gotten an *awesome* sounding additional role in his job has just heard from a colleague who has a similar thing that it basically means nothing at all, because their manager is all about efficiency and dedicating work time to this secondary R&D style role just isn't efficient. It sounded awfully familiar as I've been on projects before where managers were encouraged to maximise efficiency and it was the worst - if products were delivered on or ahead of time or without a horrific crunch then clearly the rope could be tightened a bit here or there, and as soon as the strain was too great and things went tits up of course it wasn't the fault of the cutbacks, the devs just needed to be more prepared to pull out all the stops.

Pollyanna
Mar 5, 2005

Milk's on them.


So I'm getting reprimanded for relying on Moment.isValid(), a library function, to determine whether a date is valid. A prior solution had been to parse the date in Moment, then break the parsed date down into day/month/year and compare user input with that, but I figured that an equivalent and easier/shorter approach would be to just use the library's validation method, which we're already doing. Leverage what you've already got, right? Isn't that a major tenet of programming well? Instead, I'm being told off for not doing exactly what the director (my former team lead) wants.

Am I wrong in being really pissed off about this? It's a really minor issue but it feels like the guy's just looking for a reason to nitpick my work and I don't feel trusted to implement any solutions. I'm sick and loving tired of this rear end in a top hat breathing down my neck and questioning everything I do just to be a douchebag. Maybe I'm overreacting, but I can't stand working with this guy. Thank god I'm leaving.

CPColin
Sep 9, 2003

Big ol' smile.
I don't know if my coworkers are using Resharper because nobody helped me configure Visual Studio when I set it up!

Pollyanna
Mar 5, 2005

Milk's on them.


Oh yeah, and I found out that our office head completely lied to the guy they let go about there not being any more work for him. Turns our there's a when roadmap for the project he headed and he's leaving behind an engineer who's not as familiar with the codebase yet is still on that same project. This place is real fuckin fishy.

geeves
Sep 16, 2004

Pollyanna posted:

So I'm getting reprimanded for relying on Moment.isValid(), a library function, to determine whether a date is valid. A prior solution had been to parse the date in Moment, then break the parsed date down into day/month/year and compare user input with that, but I figured that an equivalent and easier/shorter approach would be to just use the library's validation method, which we're already doing. Leverage what you've already got, right? Isn't that a major tenet of programming well? Instead, I'm being told off for not doing exactly what the director (my former team lead) wants.

Am I wrong in being really pissed off about this? It's a really minor issue but it feels like the guy's just looking for a reason to nitpick my work and I don't feel trusted to implement any solutions. I'm sick and loving tired of this rear end in a top hat breathing down my neck and questioning everything I do just to be a douchebag. Maybe I'm overreacting, but I can't stand working with this guy. Thank god I'm leaving.

No, you're not. It just confirms that you work for / with total shitheads.

On a side note, once JS Joda has locale support, I cannot wait to purge Moment from our codebase.

Munkeymon
Aug 14, 2003

Motherfucker's got an
armor-piercing crowbar! Rigoddamndicu𝜆ous.



CPColin posted:

I don't know if my coworkers are using Resharper because nobody helped me configure Visual Studio when I set it up!

If there's tons of dead code laying around, I'm guessing they don't though I haven't used it since '15 came out and I don't really miss it being a second code formatter with its own separate settings. Maybe they've fixed that?

I am thinking about trying out Rider

ChickenWing
Jul 22, 2010

:v:

Pollyanna posted:

So I'm getting reprimanded for relying on Moment.isValid(), a library function, to determine whether a date is valid. A prior solution had been to parse the date in Moment, then break the parsed date down into day/month/year and compare user input with that, but I figured that an equivalent and easier/shorter approach would be to just use the library's validation method, which we're already doing. Leverage what you've already got, right? Isn't that a major tenet of programming well? Instead, I'm being told off for not doing exactly what the director (my former team lead) wants.

Am I wrong in being really pissed off about this? It's a really minor issue but it feels like the guy's just looking for a reason to nitpick my work and I don't feel trusted to implement any solutions. I'm sick and loving tired of this rear end in a top hat breathing down my neck and questioning everything I do just to be a douchebag. Maybe I'm overreacting, but I can't stand working with this guy. Thank god I'm leaving.

hey pollyanna







get a new job

Pollyanna
Mar 5, 2005

Milk's on them.


ChickenWing posted:

hey pollyanna







get a new job

I'm on it man :yotj:

KoRMaK
Jul 31, 2012



Pollyanna posted:

So I'm getting reprimanded for relying on Moment.isValid(), a library function, to determine whether a date is valid. A prior solution had been to parse the date in Moment, then break the parsed date down into day/month/year and compare user input with that, but I figured that an equivalent and easier/shorter approach would be to just use the library's validation method, which we're already doing. Leverage what you've already got, right? Isn't that a major tenet of programming well? Instead, I'm being told off for not doing exactly what the director (my former team lead) wants.

Am I wrong in being really pissed off about this? It's a really minor issue but it feels like the guy's just looking for a reason to nitpick my work and I don't feel trusted to implement any solutions. I'm sick and loving tired of this rear end in a top hat breathing down my neck and questioning everything I do just to be a douchebag. Maybe I'm overreacting, but I can't stand working with this guy. Thank god I'm leaving.

Why don't they want you using isvalid?

ChickenWing
Jul 22, 2010

:v:

oh also I finished v1 of the project I was working on and it's not breaking and nobody seems to hate it :3:

it's hilarious because it's literally 5 groovy classes and a whole bunch of autogenerated code, and everyone using it is super impressed by "how much work I got done in two weeks"

so that's cool I guess :sun:

Pollyanna
Mar 5, 2005

Milk's on them.


KoRMaK posted:

Why don't they want you using isvalid?

It's not the solution he wants. That's it, that's all of it.

Rocko Bonaparte
Mar 12, 2002

Every day is Friday!

Pollyanna posted:

It's not the solution he wants. That's it, that's all of it.

It is multidimensionally wrong:
1. The technicalities of it for starters.
2. The fact your director has chosen to obsess over that rather than anything else.

Maybe dailywtf is hiring lol.

KoRMaK
Jul 31, 2012



Pollyanna posted:

It's not the solution he wants. That's it, that's all of it.

If there isn't any real justification being provided then yea gently caress it get out that dudes dumb

Pixelboy
Sep 13, 2005

Now, I know what you're thinking...

My Rhythmic Crotch posted:

I heard JJ Abrams is going to direct the screenplay adaptation of Batman vs Superman: Dawn of Devops

Just as long as they keep Affleck the hell away from it, I'm ok with it.

pigdog
Apr 23, 2004

by Smythe

Pollyanna posted:

So I'm getting reprimanded for relying on Moment.isValid(), a library function, to determine whether a date is valid. A prior solution had been to parse the date in Moment, then break the parsed date down into day/month/year and compare user input with that, but I figured that an equivalent and easier/shorter approach would be to just use the library's validation method, which we're already doing. Leverage what you've already got, right? Isn't that a major tenet of programming well? Instead, I'm being told off for not doing exactly what the director (my former team lead) wants.

Am I wrong in being really pissed off about this? It's a really minor issue but it feels like the guy's just looking for a reason to nitpick my work and I don't feel trusted to implement any solutions. I'm sick and loving tired of this rear end in a top hat breathing down my neck and questioning everything I do just to be a douchebag. Maybe I'm overreacting, but I can't stand working with this guy. Thank god I'm leaving.
Hopefully their preferred solution is packaged in a method in some common code at least? If so, then there could be a little bit of benefit of doing the same thing consistently everywhere in code.

At the same time, it's important to be free to say how you feel, and have an atmosphere of trust in the team. If you can't stand working with the guy, then you shouldn't.

Pollyanna
Mar 5, 2005

Milk's on them.


Nope, this is the only place it happens and there's nothing else built besides what I made.

I think the worst part is how all PRs have to go through him and he takes 3~4 hours to respond to updated PRs, yet expects us lower rung engineers to immediately review his poo poo.

KoRMaK
Jul 31, 2012



Pollyanna posted:

I think the worst part is how all PRs have to go through him and he takes 3~4 hours to respond to updated PRs, yet expects us lower rung engineers to immediately review his poo poo.

Well, yea it might suck for you but it's a pretty fair organizational response time. When I was a dev I was able to get to more poo poo more immediately, but now that I'm bumped up it takes me a minute to do stuff. And I know my devs aint got more poo poo to do than me so If I'm giving PR notes I'm gonna hit you up in an hour if you haven't already responded.

The rest of his stuff sounds like garbage tho. I just don't want you conflating an honest and generally fair organizational thing with the rest of it.

Pollyanna
Mar 5, 2005

Milk's on them.


Well yeah, that I can understand. But in my current situation I have literally nothing else to do while waiting on his response, so I get bored. I think it's a symptom of me wanting to get the hell out ASAP, which is my own problem.

He's now claiming that my solution does the opposite of what it actually does, so I don't think he's even investigated or tried to understand my solution. He clearly doesn't trust me to implement anything and I'm just going to chafe further under him.

Adbot
ADBOT LOVES YOU

CPColin
Sep 9, 2003

Big ol' smile.
One time at my last job, we developers were having a meeting where we concluded that it would be best if projects were complete before PR's were submitted, because we were all getting annoyed at having the rug pulled out from us halfway through a review when four more commits would come in. My boss, noted repeat offender, said he was submitting them early so we could get a head-start on the review while the last few issues were being resolved. We told him the head-starts were being offset by the rug-pulling and he got mad and said he would start expecting us to stay late to finish reviews so stuff wouldn't miss the sprint deadline.

Thankfully, he backed off, once he realized how absurd his request was! To say nothing of how if his team needed to rely on head-starts in their PR's to get stuff in before the end of the sprint, maybe his team was over-committing!

  • 1
  • 2
  • 3
  • 4
  • 5
  • Post
  • Reply