Working in Development: Leaving sounds like a great decision.

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Working in Development: Leaving sounds like a great decision.

«‹›434 »

Nybble: Jun 28, 2008; praise chuck, raise heck

RESTful is pleasant and calming

# ? Dec 8, 2022 17:00

Adbot: ADBOT LOVES YOU

# ? May 10, 2024 12:41

ThePopeOfFun: Feb 15, 2010

Xarn posted:

I meant it literally means crap.

CrAPPs

# ? Dec 8, 2022 17:07

ultrafilter: Aug 23, 2007; It's okay if you have any questions.

Xarn posted:

I meant it literally means crap.

It's this.

# ? Dec 8, 2022 17:35

Mega Comrade: Apr 22, 2004; Listen buddy, we all got problems!

Xarn posted:

I meant it literally means crap.

Oh haha I thought it was some awful term for a minority I'd never heard of or something. I'm honestly not sure there is another term in use though, not that I really understand why you care.

Nybble posted:

RESTful is pleasant and calming

CRUD and RESTful aren't the same thing though.

Mega Comrade fucked around with this message at 19:17 on Dec 8, 2022

# ? Dec 8, 2022 19:12

CPColin: Sep 9, 2003; Big ol' smile.

CRUSTful

# ? Dec 8, 2022 19:16

Macichne Leainig: Jul 26, 2012; by VG

I prefer my requests without the crust

# ? Dec 8, 2022 19:21

bigperm: Jul 10, 2001; some obscure reference

We could say Curd. Is Curd better? Curd.

# ? Dec 8, 2022 19:25

prom candy: Dec 16, 2005; Only I may dance

CPColin posted:

CRUSTful

this is deeply unpleasant and should maybe be the new thread title

# ? Dec 8, 2022 19:36

Fellatio del Toro: Mar 21, 2009

bigperm posted:

We could say Curd. Is Curd better? Curd.

sorry this api is CURDled and we recommend you migrate to the new version

# ? Dec 8, 2022 20:02

downout: Jul 6, 2009

DRUC

# ? Dec 8, 2022 20:25

The NPC: Nov 21, 2010

We call them getties.

GET an object:

code:

curl -X GET http://example.com/api/object

GET new values for the object:

code:

curl -X GET http://example.com/api/object?id=1&updateProperty=accountBalance&propertyNewValue=10000

ForGET your password?

code:

curl -X GET http://example.com/api/user?username=The%20NPC&newPassword=hunter2

# ? Dec 9, 2022 00:18

Fellatio del Toro: Mar 21, 2009

never stop POSTing

# ? Dec 9, 2022 00:43

nullfunction: Jan 24, 2005; Nap Ghost

All of the responses are 200 OK with an error message in the JSON payload, right?

# ? Dec 9, 2022 01:22

Pedestrian Xing: Jul 19, 2007

nullfunction posted:

All of the responses are 200 OK with an error message in the JSON payload, right?

I see you've worked with major financial institutions as well.

# ? Dec 9, 2022 02:05

redleader: Aug 18, 2005; Engage according to operational parameters

nullfunction posted:

All of the responses are 200 OK with an error message in the JSON payload, right?

this is honestly the most minor crime i've encountered with external apis

# ? Dec 9, 2022 02:12

champagne posting: Apr 5, 2006; YOU ARE A BRAIN
IN A BUNKER

nullfunction posted:

All of the responses are 200 OK with an error message in the JSON payload, right?

better than using 412 precondition failed for every input error and never specify what is wrong or how it may be remedied

I�m looking at you, Apache Pulsar

# ? Dec 9, 2022 02:55

Clanpot Shake: Aug 10, 2006; shake shake!

nullfunction posted:

All of the responses are 200 OK with an error message in the JSON payload, right?

I see you have heard the gospel of graphql

# ? Dec 9, 2022 03:25

Che Delilas: Nov 23, 2009; FREE TIBET WEED

500 Internal Server Error Due To Bad Request

# ? Dec 9, 2022 03:45

prom candy: Dec 16, 2005; Only I may dance

champagne posting posted:

better than using 412 precondition failed for every input error and never specify what is wrong or how it may be remedied

I�m looking at you, Apache Pulsar

LinkedIn does 400s if you send any of their stupid parameters wrong and no of course they don't tell you which one.

# ? Dec 9, 2022 06:22

CPColin: Sep 9, 2003; Big ol' smile.

Stupid parameters need the most validation!

# ? Dec 9, 2022 07:19

champagne posting: Apr 5, 2006; YOU ARE A BRAIN
IN A BUNKER

prom candy posted:

LinkedIn does 400s if you send any of their stupid parameters wrong and no of course they don't tell you which one.

Welp I forgot to mention pulsar will also send you back 412 when it is having issues.

Like say if you�re creating a namespace, a construct which contains subscriptions and other things, you can by default for my provider only create 1024. The 1025th namespace attempted created will return 412

Also you are allowed to increase the limit leading to further questions like �why� and �what is wrong with this thing god damnit�

# ? Dec 9, 2022 08:11

Volmarias: Dec 31, 2002; EMAIL... THE INTERNET... SEARCH ENGINES...

Che Delilas posted:

500 Internal Server Error Due To Bad User

# ? Dec 9, 2022 08:11

CPColin: Sep 9, 2003; Big ol' smile.

Ah yes, an external server error

# ? Dec 9, 2022 08:28

Carbon dioxide: Oct 9, 2012

What's the HTTP code for "oops your request made our server explode"?

# ? Dec 9, 2022 08:33

Mega Comrade: Apr 22, 2004; Listen buddy, we all got problems!

At my current place, one guy did most of the external facing APIs, and when he left and they got dumped on me, I've noticed most of it threw 420 errors.

Mega Comrade fucked around with this message at 10:33 on Dec 9, 2022

# ? Dec 9, 2022 09:51

AgentF: May 11, 2009

420 Server Up In Smoke

# ? Dec 9, 2022 10:18

Judge Schnoopy: Nov 2, 2005; dont even TRY it, pal

301 Redirected (back to you (as a successful response (here's your json)))

# ? Dec 9, 2022 14:39

The Dark Souls of Posters: Nov 4, 2011; Just Post, Kupo

What about cloud flare giving you a 502 even though it got a normal 200 response within the timeout parameter causing the request to get retried despite success

# ? Dec 9, 2022 15:12

Bruegels Fuckbooks: Sep 14, 2004; Now, listen - I know the two of you are very different from each other in a lot of ways, but you have to understand that as far as Grandpa's concerned, you're both pieces of shit! Yeah. I can prove it mathematically.

Mega Comrade posted:

At my current place, one guy did most of the external facing APIs, and when he left and they got dumped on me, I've noticed most of it threw 420 errors.

twitter unofficially added the 420 status code https://developer.twitter.com/ja/docs/basics/response-codes

420 is a status code meaning "enhance your calm." means that your app is being rate limited for making too many requests. hilarious.

# ? Dec 9, 2022 16:31

prom candy: Dec 16, 2005; Only I may dance

CPColin posted:

Stupid parameters need the most validation!

lol

# ? Dec 9, 2022 17:51

Cup Runneth Over: Aug 8, 2009; She said life's
Too short to worry
Life's too long to wait
It's too short
Not to love everybody
Life's too long to hate

Che Delilas posted:

500 Internal Server Error Due To Bad Request

An API unironically returning this because I had a ^ character in my password :rolleyes:

That was a fun one to debug

# ? Dec 9, 2022 23:07

raminasi: Jan 25, 2005; a last drink with no ice

ultrafilter posted:

Is there a different term for CRUD apps that sounds less derogatory?

Most CRUD apps are Line Of Business Apps, or LOBAs, which might get you want you want. (Of course, LOBA is the short form - the full name is "Boring Line Of Business App," so...)

# ? Dec 12, 2022 19:13

smackfu: Jun 7, 2004

Really what business apps aren�t CRUD apps anyways?

# ? Dec 12, 2022 19:21

raminasi: Jan 25, 2005; a last drink with no ice

Ok I'm having real trouble figuring out constructive communication in response to some stuff that a guy on my team does. I just had an quintessential exchange. Here was the existing code (please forgive any syntactic errors, they were just introduced by my obfuscation):

JavaScript code:

if (thingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue } };
}

He opened a PR with this addition:

JavaScript code:

if (thingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue } };
}
if (otherThingThatMightBeTrue) {
    config.API = { importantStuff: { otherImportantKey: otherImportantValue } };
}

My comment on the PR, because I don't know JavaScript very well and thought I legitimately might not understand something: "Will that merge the properties of importantStuff or will the second one overwrite the first one" (which would be incorrect), to which he replied that they'd be merged, with no other explanation.

Now either he's right and I still don't understand, or he's wrong, so I get him on Slack, and it turns out that yes, there would be an incorrect overwrite. So he "fixes" it:

JavaScript code:

if (thingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue } };
}
if (thingThatMightBeTrue && otherThingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue, otherImportantKey: otherImportantValue } };
}

I ask the obvious question: "What will this do if otherThingThatMightBeTrue is true but thingThatMightBeTrue is false?" and he sees the problem and fixes it. But it felt like a lot of hand-holding for someone with 4-5 years of experience. And maybe my expectations are misaligned, and maybe they aren't, but either way I want to find a way to generalize the thought process I went through for him in a way that's more useful than "when you're writing code, you should think about what it would do, and not write code that will do the wrong thing," but that's all I can think of here. Does anyone have any ideas?

# ? Dec 12, 2022 23:23

Harriet Carker: Jun 2, 2009

At a first glance, the best comment you could post is �where are the unit tests?�

This back and forth would be easily solved if this was a named, tested function.

# ? Dec 13, 2022 00:34

Love Stole the Day: Nov 4, 2012; Please give me free quality professional advice so I can be a baby about it and insult you

Harriet Carker posted:

At a first glance, the best comment you could post is �where are the unit tests?�

This back and forth would be easily solved if this was a named, tested function.

This is the best way to say it imo. Argue about the unit test cases it needs to cover. Best case scenario, the person's team had already discussed it or wrote about the important test cases in the Jira ticket or whatever.

# ? Dec 13, 2022 00:41

smackfu: Jun 7, 2004

Also like, some people spend 4-5 years improving and other people just don�t.

Usually the people in the first group leave your company after a couple of years of course.

# ? Dec 13, 2022 00:56

Judge Schnoopy: Nov 2, 2005; dont even TRY it, pal

Harriet Carker posted:

At a first glance, the best comment you could post is “where are the unit tests?”

This back and forth would be easily solved if this was a named, tested function.

I used to code like the offending coworker, for me it was all about moving as fast as possible to "show skill" at software development.

I solved it by writing unit tests as well. It forces me to slow down and consider edge cases instead of smashing the commit button

# ? Dec 13, 2022 01:06

Volmarias: Dec 31, 2002; EMAIL... THE INTERNET... SEARCH ENGINES...

raminasi posted:

Ok I'm having real trouble figuring out constructive communication in response to some stuff that a guy on my team does. I just had an quintessential exchange. Here was the existing code (please forgive any syntactic errors, they were just introduced by my obfuscation):
JavaScript code:
if (thingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue } };
}
He opened a PR with this addition:
JavaScript code:
if (thingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue } };
}
if (otherThingThatMightBeTrue) {
    config.API = { importantStuff: { otherImportantKey: otherImportantValue } };
}
My comment on the PR, because I don't know JavaScript very well and thought I legitimately might not understand something: "Will that merge the properties of importantStuff or will the second one overwrite the first one" (which would be incorrect), to which he replied that they'd be merged, with no other explanation.

Now either he's right and I still don't understand, or he's wrong, so I get him on Slack, and it turns out that yes, there would be an incorrect overwrite. So he "fixes" it:
JavaScript code:
if (thingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue } };
}
if (thingThatMightBeTrue && otherThingThatMightBeTrue) {
    config.API = { importantStuff: { importantKey: importantValue, otherImportantKey: otherImportantValue } };
}
I ask the obvious question: "What will this do if otherThingThatMightBeTrue is true but thingThatMightBeTrue is false?" and he sees the problem and fixes it. But it felt like a lot of hand-holding for someone with 4-5 years of experience. And maybe my expectations are misaligned, and maybe they aren't, but either way I want to find a way to generalize the thought process I went through for him in a way that's more useful than "when you're writing code, you should think about what it would do, and not write code that will do the wrong thing," but that's all I can think of here. Does anyone have any ideas?

Murder them and build your codebase upon his corpse

# ? Dec 13, 2022 01:08

Adbot: ADBOT LOVES YOU

# ? May 10, 2024 12:41

Rocko Bonaparte: Mar 12, 2002; Every day is Friday!

Yeah looks like they just want to close the ticket and you're in the way.

# ? Dec 13, 2022 05:15

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Working in Development: Leaving sounds like a great decision.

«‹›434 »