• Alright, so they're not doing validation on Thing X, so I need to add that.
  
• Oh, they don't even pull in the client for that, alright, let me add that in...
  
• Oh, the entire group doesn't pull in these clients, let me add that in...
  
• Oh, we don't pull in the auth reference from the CLI, let me add that in....and that means I need to update all the tests. Alright, whatever, that's on my list anyway since I'm modifying behavior.
  
• Okay so I finally updated the classes to use the appropriate validation logic, let's go look at their tests.
  
• Alright they have testing split between run through the cli framework test runner and run directly against their state machine, that's fine. The direct state machine tests are simpler, so those only took a couple hours, let's look at the runner...
  
• Fix their patching setup to use the fixtures I made and...oh wow why are you patching local functions.
  
• Wow that's a lot of local function patching, let me go look at some of those tests.
  
• Oh holy poo poo.
  

if "".__eq__(value_to_check) or (value_to_check.isspace()):

def test_a_thing():
    thing_one = patch('path_to_thing_to_patch').start()
    thing_two = patch('path_to_other_thing_to_patch').start()

    args = ['entrypoint', 'arg1', 'arg2', 'arg3', 'arg4']

    thing_one.blah.return_value = True
    thing_two.bleep.return_value = False

    output = runner_execute(args=args)

    assert output == True

def test_a_thing():
    # yes this part is all *entirely identical except for minor args deviations*
    thing_one = patch('path_to_thing_to_patch').start()
    thing_two = patch('path_to_other_thing_to_patch').start()

    args = ['entrypoint', 'arg1', 'arg2', 'arg3', 'arg4', 'arg5']

    thing_one.blah.return_value = True
    thing_two.bleep.return_value = False

    output = runner_execute(args=args)

    assert output == True
    # bonus fact: people kept forgetting to tear down their patches.

Falcon2001 fucked around with this message at 03:33 on Aug 26, 2023

number_goes_up = (n for n in itertools.accumulate(itertools.cycle([1, 2, 3])))
number_goes_up.__next__()
1
number_goes_up.__next__()
3
number_goes_up.__next__()
6
number_goes_up.__next__()
7
...

The March Hare fucked around with this message at 04:05 on Aug 31, 2023

The March Hare fucked around with this message at 17:47 on Aug 31, 2023

Oysters Autobio fucked around with this message at 18:48 on Aug 31, 2023

ComradePyro fucked around with this message at 19:36 on Aug 31, 2023

@app.route("/login", methods=["GET", "POST"])
def login():
    form = LoginForm()
    if form.validate_on_submit():
        user = AppUser.query.filter_by(email=form.email.data).first()
        # Check user exists and password matches hashed password.
        if user and bcrypt.check_password_hash(user.password, form.password.data):
            login_user(user, remember=form.remember.data)
            return redirect(url_for("home"))
        else:
            flash(
                message="Invalid login credentials!",
                category="danger",
            )
    return render_template("login.html", title="Login", form=form)

class LoginForm(FlaskForm):
    username = StringField(
        "Username", validators=[DataRequired(), Length(min=2, max=20)]
    )
    email = StringField(label="Email", validators=[DataRequired(), Email()])
    password = PasswordField(label="Password", validators=[DataRequired()])
    remember = BooleanField(label="Remember Me")
    submit = SubmitField(label="Login")

@login_manager.user_loader
def load_user(user_id):
    return AppUser.query.get(int(user_id))

class AppUser(db.Model, UserMixin):
    id = db.Column(db.Integer, primary_key=True)
    username = db.Column(db.String(20), unique=True, nullable=False)
    email = db.Column(db.String(120), unique=True, nullable=False)
    image_file = db.Column(db.String(20), nullable=False, default="default.jpg")
    password = db.Column(db.String(60), nullable=False)
    posts = db.relationship("Post", backref="author", lazy=True)

    def __repr__(self):
        return f"AppUser('{self.username}', '{self.email}', '{self.image_file}')"

Generic Monk fucked around with this message at 18:13 on Sep 2, 2023

Generic Monk fucked around with this message at 20:12 on Sep 2, 2023

Generic Monk fucked around with this message at 21:35 on Sep 2, 2023