Ratty posted:

At my old job some one once wrote:

code:

  for(int i = 1;i < 3; i++){

    if(i == 1){
      
      //the code did something here
       
    }


    if(i == 2){
      
      //the code did something here
       
    }

  }

The guy that wrote it had a good sense of humour so we printed it out and started a wall of shame.

-- Ratty

pokeyman posted:

Found this in the PHP manual. It's like the guy knew he wanted some kind of conditional execution, but forgot about the "if" keyword.

code:

switch (TRUE)
{
 case ($phlen < 7):
   $ext = $ph;
   break;
 case ($phlen == 7):
   sscanf($ph, "%3s%4s", $pfx, $exc);
   break;
 case ($phlen > 7 AND $phlen < 10):
   sscanf($ph, "%3s%4s%s", $pfx, $exc, $ext);
   break;
 case ($phlen == 10):
   sscanf($ph, "%3s%3s%4s", $area, $pfx, $exc);
   break;
 case ($phlen == 11):
   sscanf($ph, "%1s%3s%3s%4s", $cty, $area, $pfx, $exc);
   break;
 case ($phlen > 11):
   sscanf($ph, "%1s%3s%3s%4s%s", $cty, $area, $pfx, $exc, $ext);
   break;
}

standard posted:

I found this in one of our apps this week.

code:

for (int i = 0; i < collection.getDetails().size(); i++) { 
       SomeObject object = (SomeObject)collection.getDetails().elementAt(i);
       count++; 
} 

if (count < 1 || count> 10) { 
       isValid = false; 
} 

what the hell

chocojosh posted:

Stack: I tend to code regularly like this:

code:

if(!isset($bravo))
   $blah = here($something)
elseif(isset($charlie)) 
   $blah = here($charlie)
else
   $blah = nothere();

My logic is I hate wasting an entire line just to show a brace.

Randomosity posted:

I want to kill the people whose code I now maintain. And wtf is an 'appaplexy'

ashgromnies posted:

Just ran across this while adding on some functionality to a project...

code:

my $id        = $req->param($unique_id);

That $id is an identifier given to us by one of our third-party integration partners. We also have different identifiers for users on our side and we map the two to eachother.

So that line grabs the user's third-party ID from the CGI request. Nothing weird, but then 20 lines below that in the same method...

It reassigns $id to $user->get_user_id() which is OUR identifier for users - and it called it on an instance of $user which it reassigns in the next line with the $id it just retrieved - what the gently caress I'm going to cry.

willemw posted:

Today I had to do some maintenance on the administration part on one of our websites. You can link some stuff to one of 15 different locations.

Munkeymon posted:

Just kill the guy who turned that poo poo in and maybe his job could be filled by someone who doesn't leave the # out of C#.

Lone_Strider posted:

Holy poo poo, this is like a tell-tale mark for crappy devs. I bet when he was called on it he said "well I'm just making sure"

Zombywuf posted:

On an SQL flavoured note, something I saw recently. With a table with an id and sub id, where the pair id, sub_id is unique, and sub_id is guaranteed to be 1, 2, etc... for each id.

code:

WITH cte AS (
  SELECT
     ...
     row_number() OVER(
       PARTITION BY id
       ORDER BY sub_id
     ) AS rownum
  FROM
    ...
) SELECT
  *
FROM
  cte
WHERE
  rownum = 1

chocojosh posted:

wrok posted:

code:

    foreach (string item in _ptAttributeDic.Keys)
    {
        string val = _ptAttributeDic[item];
        switch (item.ToLower())
        {
            case "mail":
                if (string.IsNullOrEmpty(base._email))
                    base._email = val;
                break;
            
            case "facsimiletelephonenumber":
                base._faxNum = val;
                break;
            
            case "telephonenumber":
                base._phoneNumber = val;
                break;
        }
    }

So this is such a bad varation of the for-switch that once it matches either "mail", "facsimiletelephonenumber", or "telephonenumber" it's going to exit the loop.

Unless the author meant to only initialize one of them, but then it would just be much easier to use

if(_ptAttributeDic.Contains("X"))
base._X = _ptAttributeDic["X"];
...

rt4 posted:

Professors: fine for theory, always wrong on code.

Broken Knees Club posted:

So why is this Epic thing treated like the bubonic plague?

clockwork automaton posted:

An entire class where the only comment is

code:

//?

Thanks guys. That comment is TOTALLY useful.

ColdPie posted:

So you'd argue that the library is small enough to just be memorized? I guess I don't disagree. It just seems harsh to me to call it a horror when someone isn't familiar with non-obvious functions like atan2 and fmod.

MrMoo posted:

C99 is ANSI C, along with C90 and C89. What am I missing?

http://en.wikipedia.org/wiki/ANSI_C

quote:

C89
[snip]
This version of the language is often referred to as "ANSI C", or sometimes "C89" (to distinguish it from C99).
[snip]
C99
In March 2000, ANSI adopted the ISO/IEC 9899:1999 standard. This standard is commonly referred to as C99

Flobbster posted:

I mean that's cool and all, but I chuckled at which of the words they deemed important enough to have special cases, like "buffalo" and "tomato", but "potato" gets left out.

shrughes posted:

Inheritance

"To an external observer, inheritance of T from U is indistinguishable from the presence of a conversion function from T to U."

- Confucious

I was simply saying that from an external observer inheritance of T from U is indistinguishable from the presence of a conversion function from T to U.

shrughes posted:

baquerd posted:

bobthecheese posted:

Speaking of poorly named variables...

code:

SELECT ...
FROM (SELECT ... 
     FROM ... 
     WHERE ...
     GROUP BY ... 
  UNION ALL 
     SELECT ...  
     FROM ...
     WHERE ...
     GROUP BY ...) AS tblFoo 
GROUP BY tblFoo.hour;

It's not a table, the naming convention in the database is to POST-fix 'Tbl' (I have no loving idea why), and 'Foo' describes precisely nothing about the purpose or nature of the data.

Fuckers.

Wheany posted:

Okay, so you're using Lua. These problems are somewhat understandable on a cross-platform language.

But loving Windows Poweshell. How in the gently caress can executing programs from under Program Files be so loving difficult in a shell designed for Windows.

I was tearing my hair out with the equivalent of "c:\Program Files\ImageMagick-6.8.2-Q16\convert.exe" "C:\Users\My Username\Pictures\some file with spaces 1.png" -resize 50% "some file with spaces 1.gif"

Where the number in the file name came from a loop index variable.

EssOEss posted:

The same way as you would normally? Or have you found some problematic scenario I have not discovered yet in my mere three months?

code:

PS C:\Users\essoess> c:\tee\tf.cmd help
Team Explorer Everywhere Command Line Client (version 11.0.0.201207250346)

 Available commands and their options:

JetsGuy posted:

Anyway, after a quick look at the git website, it seems like it's a standalone version control program. Is this true? Is it any good?

Steve French posted:

Which would be awfully nice for the compiler to know, but it doesn't.

Deus Rex posted:

Is Postgres the only SQL DB that can do indexes on expressions? I wasn't that surprised to see MySQL was lacking them, but SQL Server is supposed to be good

Plorkyeran posted:

You can't index the expression directly, but you can create a view with that expression and then put an index on that.

chippy posted:

I'm just gonna leave this here and let you pick your own horrors

code:

    'snip

chippy posted:

And this is my first real dev job.

Nipplebox posted:

Many are afraid of doing something damaging by accident.

zergstain posted:

I always thought the reason for mocks was you want to test A, which uses C, but C hasn't been implemented yet.

Bognar posted:

No need to be a dick about it. I'm well aware of the Parse overloads, but I still don't understand why Parse(string) defaults to converting to local time instead of just setting Kind to Utc.

canis minor posted:

What I've done is copied the entire column to notepad and back in - since copy to clipboard copies the displayed value, and not the "actual" value, thus dropping the formatting and preserving what I want, but still - how is that sane?

canis minor posted:

Still, as an inexperienced user with Excel this behaviour strikes me as absurd - if I saw "0.416667" in the top bar, but "10:00:00" in the cell, I'd know the matter is with formatting of a specific value. If I see 10:00:00 in both I'm thinking - this is definitely a string. And I know for sure the person that created the sheet didn't apply time formatting to this column, so why should the app in this case try to fix the data for the user?

quote:

edit: to clarify - if I open a blank spreadsheet, put in first cell: "10:00:00", second cell "=CONCATENATE("Time is ";A1)" I don't expect it to output: "Time is 0.416667" and I consider it weird that that's the standard behavior.

canis minor posted:

That are great points you're making - especially about sorting "9:00" and "10:00"; still, I'd say I prefer Google's approach - it is, what it is, until user makes a conscious decision about changing it

rjmccall posted:

Meat Beat Agent posted:

I assume they meant the smallest undefined program that always finishes normally.