SALR Chrome Extension - New browser, same great taste!

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Chrome Extension - New browser, same great taste!

«‹›56 »

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

kri kri posted:

Can you add an option to disable thread tags option like the salr for firefox has/had?

I'll add it to the To Do.

# ? Apr 11, 2013 03:43

Adbot: ADBOT LOVES YOU

# ? May 18, 2024 13:52

Rohaq: Aug 11, 2006

Tweak request: I noticed that there's a menu at the bottom of the forum now, it'd be nice if SALR removed the same items from that menu that I chose for the top menu.

# ? Apr 11, 2013 14:09

ClassActionFursuit: Mar 15, 2006

Rohaq posted:

Tweak request: I noticed that there's a menu at the bottom of the forum now, it'd be nice if SALR removed the same items from that menu that I chose for the top menu.

In the same vein, it used to be that you could add Configure SALR to the menu then hide the top menu and it would appear in the bottom one and have no menu at all at the top. Now adding Configure SALR does not do it for the bottom menu and furthermore it appears at the top even if you disable the top menu altogether.

Honestly if I could have any wish I'd rather the SALR and grenade icon that appears in the top left of a thread lead to the options instead of it just being there looking out of place with the wrong font.

Edit: Oh the ugly SALR grenade disappears if you hide the Search Thread box. I guess I can do that.

ClassActionFursuit fucked around with this message at 14:44 on Apr 11, 2013

# ? Apr 11, 2013 14:36

Sad Panda: Sep 22, 2004; I'm a Sad Panda.

Master_Odin posted:

So the text button works, it's just that the ignore option doesn't work as it should and that needs to be fixed. Like, what exactly would you all describe as the main issue with this feature for someone who didn't really use it till now and sees that if I click it, it opens any page in my bookmarks with unread posts, but doesn't ignore certain star colors, or is that really it?

My main issue is that when I click on it, it doesn't do anything.

# ? Apr 11, 2013 14:51

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

LastInLine posted:

In the same vein, it used to be that you could add Configure SALR to the menu then hide the top menu and it would appear in the bottom one and have no menu at all at the top. Now adding Configure SALR does not do it for the bottom menu and furthermore it appears at the top even if you disable the top menu altogether.

So the wanted functionality is two options:
1. Add Configure SALR to bottom menu (fixed)
2. Add option to remove top/bottom navigation bar (independent of each other?)
3. Don't display "Configure SALR link" at all if the menu is not displayed?

As it is, SALR is coded to always appear if the option is enabled, and I think that makes sense, but perhaps just have it appear a bit nicer?

LastInLine posted:

Honestly if I could have any wish I'd rather the SALR and grenade icon that appears in the top left of a thread lead to the options instead of it just being there looking out of place with the wrong font.

Edit: Oh the ugly SALR grenade disappears if you hide the Search Thread box. I guess I can do that.

~~I'll add an option for this as it shouldn't be too hard.~~ Added option: "Hide SALR Logo" under Thread Options.

Sad Panda posted:

My main issue is that when I click on it, it doesn't do anything.

First, can you check if chrome is throwing an error? Go to Tools -> Developer Tools. This will open a box at the bottom of the screen. Click on the "Console" tab, and then refresh the 'usercp.php' page and see if an error appears there (the error should have on the right side 'salr.js' and some numbers. I need that really.)

Alternatively, can you take a screenshot of your settings page so I can configure my SALR to be the same as yours as I'm having issues replicating the issue.

Master_Odin fucked around with this message at 16:20 on Apr 11, 2013

# ? Apr 11, 2013 15:52

ClassActionFursuit: Mar 15, 2006

Master_Odin posted:

So the wanted functionality is two options:
1. Add Configure SALR to bottom menu (fixed)

Excellent.

Master_Odin posted:

2. Add option to remove top/bottom navigation bar (independent of each other?)

This would solve both my issue and Rohaq's assuming the feature select checkboxes worked on both the top and the bottom bars at the same time. Currently they don't but what I was saying is that they used to.

Master_Odin posted:

3. Don't display "Configure SALR link" at all if the menu is not displayed?

Right, it should be treated as yet another menu option. It's in the menu if it's checked and gone if the menu is disabled but the option to display it within the menu is checked. That was the previous behavior which made more logical sense to me since the option is called "Display Configure SALR in forum menu" which to me reads "Display this in the menu, but if the menu is hidden the option will be as well." Your behavior makes sense given the option page structure though since if it were in the menu it should just be an item to be checked or unchecked with all the others. Either way can be justified but either the behavior should be reverted or the option page changed to read "Display Configure SALR always" in my opinion.

# ? Apr 11, 2013 16:32

JohnnyCanuck: May 28, 2004; Strong And/Or Free

Is there any way to force SALR to use the currently open tab yet, or does it still open everything in new tabs?

Last time I asked this, it was a limitation of Chrome, I think?

# ? Apr 11, 2013 16:36

ClassActionFursuit: Mar 15, 2006

I posted this a while back just after the CSS changes if it helps you find things to fix:

Some options are no longer needed:
- Thread Options > Display quotes in boxes
- Image Display Options > Enable timg fix
Some options are duplicated in the forums Control Panel and may not be needed:
- Thread Options > Show user avatar images (what is the difference between this and Show user avatars right below it?)
- Thread Options > Adjust window position after thread loads
Automatically collapse large quotes is listed twice, once in Thread Options and again in Other Options
Other Options > Protect against accidental quotes instead of edits doesn't throw a warning if the Quick Reply Box is used. It would be better to remove the quote button from the user's posts if possible.

Some things that would be nice but aren't technically bugs might be:

The color used by the page navigator and the mouse gestures is no longer used on the forums themselves. It should be changed to the darker blue.
Emotes in the quick reply box aren't in alphabetical order but rather several rounds of alphabetical which makes it hard to find things.
For mouse gestures, the down box which does nothing should either be eliminated or do something (I'd personally love Reload).

Obviously this shouldn't be construed as a to-do list but rather observations I just had in a convenient place. I went through and removed what I think has been fixed.

Godspeed and thanks for the work. I'd use Safari if not for this extension and I love you for picking up the work and Ferg for starting it.

# ? Apr 11, 2013 16:40

Kazy: Oct 23, 2006; 0x38: FLOPPY_INTERNAL_ERROR

Would it be possible to add some way to get to the right-click menu when mouse navigation is enabled?

I use the navigation a lot, but I also like to save photos and right-click-copy-link to share a bad post sometimes

# ? Apr 11, 2013 17:09

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

LastInLine posted:

This would solve both my issue and Rohaq's assuming the feature select checkboxes worked on both the top and the bottom bars at the same time. Currently they don't but what I was saying is that they used to.

Right, it should be treated as yet another menu option. It's in the menu if it's checked and gone if the menu is disabled but the option to display it within the menu is checked. That was the previous behavior which made more logical sense to me since the option is called "Display Configure SALR in forum menu" which to me reads "Display this in the menu, but if the menu is hidden the option will be as well." Your behavior makes sense given the option page structure though since if it were in the menu it should just be an item to be checked or unchecked with all the others. Either way can be justified but either the behavior should be reverted or the option page changed to read "Display Configure SALR always" in my opinion.

Alright, added settings to disable top/bottom nav bar (can have both or none or one!), moved "Configure SALR" to an option underneath the Navigation Bar settings group (right after Search the Forums). It will not appear unless the navigation bar is there. Added option to remove link to "Something Awful". Fixed UserCP not being able to be removed. That should wrap up the navigation bar issues, and so I'll release the next version as it's got a decent amount of fixes. I'll get to the redundant settings in the next release.

JohnnyCanuck posted:

Is there any way to force SALR to use the currently open tab yet, or does it still open everything in new tabs?

Last time I asked this, it was a limitation of Chrome, I think?

Everything is done in the same tab except for something like "Open Updated Threads" in the bookmark page as that opens all the threads in their own tabs.

Kazy posted:

Would it be possible to add some way to get to the right-click menu when mouse navigation is enabled?

I use the navigation a lot, but I also like to save photos and right-click-copy-link to share a bad post sometimes

I'll see if I can't add an option for this.

e: 1.5.8 will be released later tonight when I get home from class:

Change Log posted:

### v1.5.8 (4/11/2013)

- Fixed Show First/Last three pages feature being broken (from forum update)
- Fixed friend post highlighting not working
+ Added setting to hide SALR Logo in thread view
- Fixed "Configure SALR" not appearing in bottom navigation bar
- Moved "Configure SALR" setting to Navigation Bar setting group
+ Added setting to show top/bottom navigation bar independently of the other bar
- Fixed "User CP" not disappearing in navigation bar if setting was false

Master_Odin fucked around with this message at 17:41 on Apr 11, 2013

# ? Apr 11, 2013 17:32

Sad Panda: Sep 22, 2004; I'm a Sad Panda.

Master_Odin posted:

First, can you check if chrome is throwing an error? Go to Tools -> Developer Tools. This will open a box at the bottom of the screen. Click on the "Console" tab, and then refresh the 'usercp.php' page and see if an error appears there (the error should have on the right side 'salr.js' and some numbers. I need that really.)

Alternatively, can you take a screenshot of your settings page so I can configure my SALR to be the same as yours as I'm having issues replicating the issue.

I'm getting an error, but it's in miscellaneous bindings:236
Port error: Could not establish connection. Receiving end does not exist.

As far as my options...

https://dl.dropboxusercontent.com/u/952508/options1.PNG
https://dl.dropboxusercontent.com/u/952508/options2.PNG
https://dl.dropboxusercontent.com/u/952508/options3.PNG

# ? Apr 11, 2013 17:51

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Sad Panda posted:

I'm getting an error, but it's in miscellaneous bindings:236
Port error: Could not establish connection. Receiving end does not exist.

That kind of error should have an arrow on the left side of it. Clicking it will have it show more issues. However, I'll test the mod based off the settings you gave me. It does indicate that one of those settings is infact broken.

e: Hm, while I don't get the error, it doesn't seem to work for me either. However, it does work on 1.5.8. I'm guessing it had to do with the Display first/last 3 pages setting. When I release 1.5.8 tonight, please let me know if this continues.

Master_Odin fucked around with this message at 18:15 on Apr 11, 2013

# ? Apr 11, 2013 18:04

Sad Panda: Sep 22, 2004; I'm a Sad Panda.

When I load up a thread I get the following errors...

Error in event handler for 'undefined': Cannot read property '1' of null TypeError: Cannot read property '1' of null
at HTMLDivElement.<anonymous> (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1595:64)
at Function.c.extend.each (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/jquery/jquery.js:30:151)
at Object.c.fn.c.each (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/jquery/jquery.js:24:147)
at SALR.showLastThreePages (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1593:23)
at SALR.pageInit (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:123:10)
at new SALR (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:35:10)
at chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/background.js:40:23
at chrome.Event.dispatchToListener (event_bindings:390:21)
at chrome.Event.dispatch_ (event_bindings:376:27)
at chrome.Event.dispatch (event_bindings:396:17) event_bindings:380
Port error: Could not establish connection. Receiving end does not exist. miscellaneous_bindings:236
chromeHidden.Port.dispatchOnDisconnect miscellaneous_bindings:236

# ? Apr 11, 2013 19:30

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Sad Panda posted:

When I load up a thread I get the following errors...

Error in event handler for 'undefined': Cannot read property '1' of null TypeError: Cannot read property '1' of null
at HTMLDivElement.<anonymous> (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1595:64)
at Function.c.extend.each (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/jquery/jquery.js:30:151)
at Object.c.fn.c.each (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/jquery/jquery.js:24:147)
at SALR.showLastThreePages (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:1593:23)
at SALR.pageInit (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:123:10)
at new SALR (chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/salr.js:35:10)
at chrome-extension://bogegdelcjhoaakaepmoglademmhiboo/js/background.js:40:23
at chrome.Event.dispatchToListener (event_bindings:390:21)
at chrome.Event.dispatch_ (event_bindings:376:27)
at chrome.Event.dispatch (event_bindings:396:17) event_bindings:380
Port error: Could not establish connection. Receiving end does not exist. miscellaneous_bindings:236
chromeHidden.Port.dispatchOnDisconnect miscellaneous_bindings:236

Yeah, it's an error that got fixed like I thought. Published v1.5.8 so your browser should update it, and then let me know how it works out for you.

# ? Apr 11, 2013 21:07

SirJoeKCB: Dec 24, 2003

Uh...

I'm only seeing this on these two posts. No clue about what would be different about them.

# ? Apr 11, 2013 21:53

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

SirJoeKCB posted:

Uh...

I'm only seeing this on these two posts. No clue about what would be different about them.

Uh, can you do this:
First, can you check if chrome is throwing an error? Go to Tools -> Developer Tools. This will open a box at the bottom of the screen. Click on the "Console" tab, and then refresh the 'usercp.php' page and see if an error appears there (the error should have on the right side 'salr.js' and some numbers. I need that really.)

Alternatively, can you take a screenshot of your settings page so I can configure my SALR to be the same as yours as I'm having issues replicating the issue.

As I have no idea as turning on all settings didn't do this and I have no idea why those specific posts would mess things up? :psyduck:

# ? Apr 11, 2013 22:10

SirJoeKCB: Dec 24, 2003

Master_Odin posted:

Uh, can you do this:
First, can you check if chrome is throwing an error? Go to Tools -> Developer Tools. This will open a box at the bottom of the screen. Click on the "Console" tab, and then refresh the 'usercp.php' page and see if an error appears there (the error should have on the right side 'salr.js' and some numbers. I need that really.)

Alternatively, can you take a screenshot of your settings page so I can configure my SALR to be the same as yours as I'm having issues replicating the issue.

As I have no idea as turning on all settings didn't do this and I have no idea why those specific posts would mess things up?

There were no javascript errors either on the control panel or this thread, but I've since restarted Chrome and it's not happening anymore. Prior to that it had persisted through both closing/reopening the page and toggling the extension (worked fine without SALR enabled).

# ? Apr 12, 2013 01:32

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

SALR Redux Browser Button Released :siren:

The code that made this possible will make it upstream into the actual extension for the omnibar icon which I'm guessing is broken seeing as how I can't get it to even appear!

SirJoeKCB posted:

There were no javascript errors either on the control panel or this thread, but I've since restarted Chrome and it's not happening anymore. Prior to that it had persisted through both closing/reopening the page and toggling the extension (worked fine without SALR enabled).

Glad to have helped in solving the issue :v:

# ? Apr 12, 2013 07:51

Stare-Out: Mar 11, 2010

I still can't seem to get the quick reply box to go away with the Escape button for some reason. Using newest stable Chrome on OSX 10.7 with newest SALR Redux. There's also a weird thing with the live preview where pictures posted in the thread block out the preview window:

The drag/drop imgur upload still doesn't work either.

# ? Apr 12, 2013 12:58

Zen Punk: Dec 26, 2005; interfaced

There's one thing I brought up earlier - chrome's right-click context menu doesn't show up on forums pages when you have mouse gestures enabled, even if you click and release without selecting a gesture button. It does show up in firefox, don't know if it's possible in chrome. Ferg said there was something funny going on he didn't want to mess with.

# ? Apr 12, 2013 14:08

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Zen Punk posted:

There's one thing I brought up earlier - chrome's right-click context menu doesn't show up on forums pages when you have mouse gestures enabled, even if you click and release without selecting a gesture button. It does show up in firefox, don't know if it's possible in chrome. Ferg said there was something funny going on he didn't want to mess with.

It has something to do with that the right mouse down/up is getting overloaded to make the overlay appear/disappear. It seems that you get either/or, and there's no real way to make it appear anyway as far as I'm aware so long as no error is thrown and something isn't broken. Googling only really returns results on either a) building your own righclick or b) disabling rightclick all together making the issue hard to see if it is even possible.

However, I am looking into seeing if I can't get the same overlay to appear with a keyboard shortcut as it seems the best compromise and while I have it appearing on an alt key press, all that remains is actually using the buttons.

Stare-Out posted:

I still can't seem to get the quick reply box to go away with the Escape button for some reason. Using newest stable Chrome on OSX 10.7 with newest SALR Redux. There's also a weird thing with the live preview where pictures posted in the thread block out the preview window:

The drag/drop imgur upload still doesn't work either.

They keyboard shortcut is probably broken as I know there's several that are. That was going to be the main thing with this release as I know that the previous page shortcut is also broken. I'll look into the live preview thing, but the imgur fix is going to be coming later as that's going to require a bit more learning on my part to fix.

# ? Apr 12, 2013 14:39

Stare-Out: Mar 11, 2010

Master_Odin posted:

They keyboard shortcut is probably broken as I know there's several that are. That was going to be the main thing with this release as I know that the previous page shortcut is also broken. I'll look into the live preview thing, but the imgur fix is going to be coming later as that's going to require a bit more learning on my part to fix.

All right, good to know they're being looked into. Appreciate you working on this, too. Thanks!

# ? Apr 12, 2013 14:51

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Stare-Out posted:

All right, good to know they're being looked into. Appreciate you working on this, too. Thanks!

Hm, it seems the issues I was having a few days disappeared. Can you post the settings you're using?

e: Yeah, the imgur is broken in the same way the browser button was. The extension security policy became stricter in the new version of them, so inline javascript is completely disallowed. Have to rewrite the handler methods, so it might not be as complicated as I'd expect. Probably bump this up to something to try and do for next release.

Master_Odin fucked around with this message at 16:19 on Apr 12, 2013

# ? Apr 12, 2013 16:15

Stare-Out: Mar 11, 2010

Master_Odin posted:

Hm, it seems the issues I was having a few days disappeared. Can you post the settings you're using?

e: Yeah, the imgur is broken in the same way the browser button was. The extension security policy became stricter in the new version of them, so inline javascript is completely disallowed. Have to rewrite the handler methods, so it might not be as complicated as I'd expect. Probably bump this up to something to try and do for next release.

I had the timg fix on but I tried turning it off and it didn't fix the live preview bug, it only happens with timg images though, as far as I can tell regular img-tagged images don't obscure the live preview window. I have keyboard navigation off but quick format keys are enabled under the quick reply box section (which is obviously enabled as well). If there's an easy way to post all the settings I have I'd be happy to hear it.

Also glad the imgur fix isn't as tricky to fix as you thought, it's a really nice feature to have.

# ? Apr 12, 2013 16:23

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Stare-Out posted:

I had the timg fix on but I tried turning it off and it didn't fix the live preview bug, it only happens with timg images though, as far as I can tell regular img-tagged images don't obscure the live preview window. I have keyboard navigation off but quick format keys are enabled under the quick reply box section (which is obviously enabled as well). If there's an easy way to post all the settings I have I'd be happy to hear it.

Also glad the imgur fix isn't as tricky to fix as you thought, it's a really nice feature to have.

Alright, fixed the live preview appearing under images.

So the hotkey is broken when you don't have the hotkey manager going right? Like you just want the hotkey to close the Quick Reply, and when it's set like that, it doesn't work? If so, yeah, I get that issue as well. I'm guessing expected behavior is that hitting esc while Quick Reply is open will close it regardless if you have global hotkeys set?

# ? Apr 12, 2013 17:21

Stare-Out: Mar 11, 2010

Master_Odin posted:

Alright, fixed the live preview appearing under images.

So the hotkey is broken when you don't have the hotkey manager going right? Like you just want the hotkey to close the Quick Reply, and when it's set like that, it doesn't work? If so, yeah, I get that issue as well. I'm guessing expected behavior is that hitting esc while Quick Reply is open will close it regardless if you have global hotkeys set?

I just noticed that with keyboard navigation on, the Esc thing works fine, but it used to work with keyboard navigation off as well if I recall. Now that I think about it, having keyboard navigation on isn't a bad thing at all and I might as well keep it on as it's actually pretty useful. :downs:

# ? Apr 12, 2013 17:27

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Master_Odin posted:

It has something to do with that the right mouse down/up is getting overloaded to make the overlay appear/disappear. It seems that you get either/or, and there's no real way to make it appear anyway as far as I'm aware so long as no error is thrown and something isn't broken. Googling only really returns results on either a) building your own righclick or b) disabling rightclick all together making the issue hard to see if it is even possible.

However, I am looking into seeing if I can't get the same overlay to appear with a keyboard shortcut as it seems the best compromise and while I have it appearing on an alt key press, all that remains is actually using the buttons.

Update on this, changed the right click plugin within jQuery to not block the context menu, and then added bind within the mouse-overlay code to disable it on a sub-setting. You'll still see the overlay briefly when you quick right click, but you'll at least see the google chrome menu as well. Will probably look into implementing it into a key in the future for a bit more elegance, but that is on the back burner.

Stare-Out posted:

I just noticed that with keyboard navigation on, the Esc thing works fine, but it used to work with keyboard navigation off as well if I recall. Now that I think about it, having keyboard navigation on isn't a bad thing at all and I might as well keep it on as it's actually pretty useful.

I'm honestly not sure if it was ever like that. I've figured out how to do it, and I might put it into the next release if that was something that was a feature at one point/seems useful enough to people that don't want full on keyboard shortcuts. I'm undecided on the topic myself.

# ? Apr 12, 2013 18:52

Mak0rz: Aug 2, 2008; 😎🐗🚬

Just a suggestion to (possibly) make your life easier: Is there any way to program a button into the settings that dumps config/browser version/etc information onto the clipboard for easy posting rather than asking people to send you screenshots of their settings pages?

Thanks for taking up the task of keeping SALR alive and running. I love this extension and would hate to see it go!

# ? Apr 12, 2013 21:56

ClassActionFursuit: Mar 15, 2006

Master_Odin posted:

Update on this, changed the right click plugin within jQuery to not block the context menu, and then added bind within the mouse-overlay code to disable it on a sub-setting. You'll still see the overlay briefly when you quick right click, but you'll at least see the google chrome menu as well. Will probably look into implementing it into a key in the future for a bit more elegance, but that is on the back burner.

Holy poo poo I can't wait for this, thank you!

# ? Apr 12, 2013 22:17

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Mak0rz posted:

Just a suggestion to (possibly) make your life easier: Is there any way to program a button into the settings that dumps config/browser version/etc information onto the clipboard for easy posting rather than asking people to send you screenshots of their settings pages?

Thanks for taking up the task of keeping SALR alive and running. I love this extension and would hate to see it go!

Turns out there was a function to display a table of all the settings in the code already! Created button to display the dump so people can just copy paste it (hopefully to a pastebin or something first!)

Also, the next version of the extension may break things as I update the jQuery the extension uses. I'm going to try and test as much as I can, but just an fyi I guess.

Master_Odin fucked around with this message at 23:07 on Apr 12, 2013

# ? Apr 12, 2013 23:05

Sad Panda: Sep 22, 2004; I'm a Sad Panda.

Master_Odin posted:

Yeah, it's an error that got fixed like I thought. Published v1.5.8 so your browser should update it, and then let me know how it works out for you.

On 1.5.8 and still nothing happens. Only console error now is

ort error: Could not establish connection. Receiving end does not exist. miscellaneous_bindings:236
chromeHidden.Port.dispatchOnDisconnect miscellaneous_bindings:236

# ? Apr 13, 2013 01:15

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

Sad Panda posted:

On 1.5.8 and still nothing happens. Only console error now is

ort error: Could not establish connection. Receiving end does not exist. miscellaneous_bindings:236
chromeHidden.Port.dispatchOnDisconnect miscellaneous_bindings:236

The bad news: I have no idea about that port error. That basically means the extension has crashed horribly, and I have no idea based on the previous code line you gave if it's still doing that as I fixed that.

The good news: I have figured out the issue behind it and it's basically the forum revamp to the stars changed how they're defined (they're now classes, no longer images within the html). This means that if you set that option, it breaks SALR. Now, since this is a game-breaking issue and I feel dumb for not catching it because I'm bad at setting settings, I'm going to split 1.6 release and get this and two other things fixed for 1.5.9, with 1.6 coming later on (which will be postponed a bit more so I can hopefully get imgur working as well as fully test the changes to the code that updating the jQuery did).

Expect the patch to hit tomorrow.

# ? Apr 14, 2013 00:35

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

1.5.9 Released :siren:

changelog posted:

### v1.5.9 (4/14/2013)

- Fixed Preview Reply pane being underneath images
+ Added option to allow default right click menu to appear when mouse gestures enabled
- Fixed Ignore Star option in settings pane (as well as prevent script breaking when it was set)
- Fixed being able to change children settings when parent setting was disabled

Update the extension to get those sweet changes!

# ? Apr 14, 2013 16:27

Mak0rz: Aug 2, 2008; 😎🐗🚬

Yes! the Open Unread Posts link finally works! :neckbeard:

# ? Apr 14, 2013 17:45

100 HOGS AGREE: Oct 13, 2007; Grimey Drawer

Mak0rz posted:

Yes! the Open Unread Posts link finally works!

It seems to open all the threads twice each for me. Progress!

# ? Apr 14, 2013 18:12

Master_Odin: Apr 15, 2010; My spear never misses its mark...

ladies

100 HOGS AGREE posted:

It seems to open all the threads twice each for me. Progress!

I think I may have broken things slightly if you didn't actually have a value set for the ignore star (and I forgot a disabled option, welp!).

Try setting the value in that dropdown to a star you don't use for now and test it again.

# ? Apr 14, 2013 19:22

Sad Panda: Sep 22, 2004; I'm a Sad Panda.

Master_Odin posted:

I think I may have broken things slightly if you didn't actually have a value set for the ignore star (and I forgot a disabled option, welp!).

Try setting the value in that dropdown to a star you don't use for now and test it again.

Yup. When it's set to nothing it double opens. When I switched to red star, it opens properly. Thank you!

# ? Apr 14, 2013 19:41

ClassActionFursuit: Mar 15, 2006

Master_Odin posted:

1.5.9 Released
changelog posted:
+ Added option to allow default right click menu to appear when mouse gestures enabled
Update the extension to get those sweet changes!

I think this is broken. The menu and the gesture icons appear, but moving the cursor to the icons does nothing. That would occasionally happen before and a secondary click on the desired icon usually caused it to activate but this time there was no way to make the icons go away. I just had to refresh the page and disable the option.

e: Just checke the new SALR settings and the option to Enable default chrome right click menu to appear after overlay was not checked and yet I was getting the right click menu. As far as I could tell, toggling the checkbox does nothing.

e2: Now the option is working, but the one with both the right click menu and the gestures fails as I describe above. :confused:

ClassActionFursuit fucked around with this message at 21:06 on Apr 14, 2013

# ? Apr 14, 2013 21:02

100 HOGS AGREE: Oct 13, 2007; Grimey Drawer

Master_Odin posted:

I think I may have broken things slightly if you didn't actually have a value set for the ignore star (and I forgot a disabled option, welp!).

Try setting the value in that dropdown to a star you don't use for now and test it again.

Yep that did it. Fix that and split up the "Display threads with new posts first" into two options so I can have it on only in the UserCP and not the forums at large and that's basically all the features I want forever.

Thanks for picking up development on the extension!

# ? Apr 14, 2013 21:49

Adbot: ADBOT LOVES YOU

# ? May 18, 2024 13:52

Ferg: May 6, 2007; Lipstick Apathy

Folks, OP is updated with the new links. Head there to update to Master Odin's branch.

# ? Apr 15, 2013 03:57

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Chrome Extension - New browser, same great taste!

«‹›56 »